From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ECB0C61DA4 for ; Mon, 6 Mar 2023 14:09:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3417E280002; Mon, 6 Mar 2023 09:09:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F178280001; Mon, 6 Mar 2023 09:09:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 193AC280002; Mon, 6 Mar 2023 09:09:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 09C6F280001 for ; Mon, 6 Mar 2023 09:09:16 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B3F0E1A0303 for ; Mon, 6 Mar 2023 14:09:15 +0000 (UTC) X-FDA: 80538655470.26.7745242 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf10.hostedemail.com (Postfix) with ESMTP id 35CF4C0027 for ; Mon, 6 Mar 2023 14:09:11 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="FFh/7G+g"; spf=pass (imf10.hostedemail.com: domain of ldufour@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=ldufour@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678111752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c3indpg/sGES9cvcKerk+c5DowGaoIvM3MaLoRJwyJc=; b=CACbHwIcuwKMr6fm4bWEKKMNNhdmDUr/Fimj7IIVZ/iZ0VTz+LfG7APYcnEbUWi+nauMGI f8xorcAYbH4eY1Xy+s0B6CwUMif4KsQK/KW06h3yHBVApIuxt/n7s1Uf8YNH45j+vWeM+7 /FfIuzGYX/f27uywExl/9VqI7JuQ/os= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="FFh/7G+g"; spf=pass (imf10.hostedemail.com: domain of ldufour@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=ldufour@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678111752; a=rsa-sha256; cv=none; b=5rvXR7rus/6VIJVn17arAXm3dNj/uwCOSSWE5hRNAWK4ZeKGWVKw++2wes2eSQhWFh+Hj4 mtkIfVqvB3eqXiUj9KrFwsHg6+D5Ep5z15AWfKm2MU/yvjsbMLl4sTKHQrlpKbd5C+Lb7d bC3QcWHMiXf+SoxOnqo5B8Aj90tujcw= Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 326DXf2w007100; Mon, 6 Mar 2023 14:09:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=c3indpg/sGES9cvcKerk+c5DowGaoIvM3MaLoRJwyJc=; b=FFh/7G+gAIMVnQiOp3kG7MrD5HufFYH+uyOh163glbq2y7yucdESvresmSZ80Zgb2xDv 0cGB9eO7FyJ0CnkYqgits5HbozbmJlNFdc/AWnXCbdb0JSsHx82NWuyonPG4IgOmeHK2 lJhjyJ7nZLy+nioL9uoV5Y7dixh6ZV0f4oUA+whnvBCxEusTbTJaFNt51EABdeJnavjl Go3NimpEfhcnW+C1ely9f5jw/v/wsv+kSDu/a3Ys2ACBdgWKJGBV2pG6JLRaJxCCS0rz reYOcs7ai9otJqCqVvqb+2FGgGD8WNWNsgQnSHKMwXyDIwh2Z3+lq3r6RdtrBoXGUGeP Xg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3p4ysdnw81-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 14:09:10 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 326E37a5030003; Mon, 6 Mar 2023 14:09:10 GMT Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3p4ysdnw79-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 14:09:10 +0000 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3265c9tR011404; Mon, 6 Mar 2023 14:09:07 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma06fra.de.ibm.com (PPS) with ESMTPS id 3p418v2836-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 14:09:07 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 326E95Vd57672076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Mar 2023 14:09:05 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2B3C92004F; Mon, 6 Mar 2023 14:09:05 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DDCDC2004D; Mon, 6 Mar 2023 14:09:04 +0000 (GMT) Received: from [9.101.4.33] (unknown [9.101.4.33]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Mar 2023 14:09:04 +0000 (GMT) Message-ID: Date: Mon, 6 Mar 2023 15:09:04 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] powerpc/mm: fix mmap_lock bad unlock Content-Language: en-US To: David Hildenbrand , linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Sachin Sant , Suren Baghdasaryan References: <20230306135520.4222-1-ldufour@linux.ibm.com> <7161f75e-9f40-f881-84b8-1eaaec0b0e3f@redhat.com> From: Laurent Dufour In-Reply-To: <7161f75e-9f40-f881-84b8-1eaaec0b0e3f@redhat.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ZCAAo8REJb2cV2Ico_GTnCpjlwwTWbBY X-Proofpoint-GUID: OQ96FBNbuO1igKID2f6Mnsb6fP9PMYyn Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-06_07,2023-03-06_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 malwarescore=0 adultscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303060120 X-Stat-Signature: 4np5na4uziha97k3ffgai8uif587q78c X-Rspam-User: X-Rspamd-Queue-Id: 35CF4C0027 X-Rspamd-Server: rspam06 X-HE-Tag: 1678111751-995307 X-HE-Meta: U2FsdGVkX1/aaKAu4sh7216Zmpj9r1GpfYb0h2dM5HRz+F5dleEYQ74QcseSd49V/hpgA9mGybdVHHfckrtw/bo0VZrsCZnmqz7IuMVFcW7EuGYj479ZS8gSslHV25NGs4vdSeAzjAJE3ykvz551FoQRWAMH3ThF9HUfWIdCkMOh2Owwgs1ws7McS0CX/bVDSx7NaykNCL6EuDf0/F9sNhy/+mZhouHqvCxEro43HQYH1F1PkWbXmrmdq18WckY/hFRmdBL6Rz5kEmnun1jdRjAMfPSIT/V+gNPa6i+HnEtB24zbAaDagZ2cXMUGYwcaoaw5OXfepxNrqntH67maaZWfS8D7HQ3Ax2xwYZHckBV90G4xQT2dTgZLRb4fu5RymW6H4J8Vm/Pejn9cKkjEsZU4BDrs/xS3c/+DpKMc1SqRpTQAtwfzNIIA8JtmDukRxTXMI1qI7C/S+kWxO5bvMSfWaTYctvh85ICnQrHZF+0gAY+hR9S+hpMirKw0K19WWaH8UqQOVGtvZLp+S8nb2DavrQm6vjaM7wD7zrgzJeb42kNx/7/fNQ7/sK2qZDMjPe254igMlujI7nHDBysrHARptoWFEwrdAPGhqiCrFHv2Ew1SJ8H6NST8bUApIOC7QAi5XTivHevvhM82eWq0snINoFf8w2GimmIf56USW4stYKmfsQ6vzai/V+tT3Hn4G6YtfSdCZgkiF/p7ACP7ct09F1MYa2Dg1/zvZ9cAdBjw/QeJgXoCVgoU8A9Piq/P3LnnBAjCOaJkiT0odu7uvKp+C1SuDlv/zyk9i8fiKfRpIqDzbyvG9feOSfzHjX3bNqvVMqreYRUAg65imH+DHBfH6++O0Olh4omNKNREdxvDK8s+C82tgtKXFKyHG6HgIxYTiK7fOpLni9WlnnDFFzUcZ3SRE7SzYJ3iaoZ7V3KvbvryhKTRy+fY9FcVVizCdghfZ40jA7vD6lSuJtV GgXS/bZ5 ahxg3rpa+jhL4XGST9aO+F4kb/VROw9pTz5TNd1wSpZCwrqby7r2dCtg2w9w2NRs/7vELeOHViJM+xt+N93I0gOwFPj7CkDVUV9ZWuI3JF58/pLx6/Tn1Mipn6LbTnuC1uk1h9rkQUCVsJLfJoEuv69WaUKSR9ELSfmsZn3SXp5G1o7O5Xoh397Nk3XN73vIh02aIIkcNZnwQM6taBhpRPWrKuA44oHlFAd0WMte7gWjM8AMxfcuRNs9k+RGeNqQDPo7tIt18XjbqwDigdMavZrGDAPPLWLbqk9sAUBYECBu3s2c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/03/2023 15:07:26, David Hildenbrand wrote: > On 06.03.23 14:55, Laurent Dufour wrote: >> When page fault is tried holding the per VMA lock, bad_access_pkey() and >> bad_access() should not be called because it is assuming the mmap_lock is >> held. >> In the case a bad access is detected, fall back to the default path, >> grabbing the mmap_lock to handle the fault and report the error. >> >> Fixes: 169db3bb4609 ("powerc/mm: try VMA lock-based page fault handling >> first") >> Reported-by: Sachin Sant >> Link: >> https://lore.kernel.org/linux-mm/842502FB-F99C-417C-9648-A37D0ECDC9CE@linux.ibm.com >> Cc: Suren Baghdasaryan >> Signed-off-by: Laurent Dufour >> --- >>   arch/powerpc/mm/fault.c | 8 ++------ >>   1 file changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c >> index c7ae86b04b8a..e191b3ebd8d6 100644 >> --- a/arch/powerpc/mm/fault.c >> +++ b/arch/powerpc/mm/fault.c >> @@ -479,17 +479,13 @@ static int ___do_page_fault(struct pt_regs *regs, >> unsigned long address, >>         if (unlikely(access_pkey_error(is_write, is_exec, >>                          (error_code & DSISR_KEYFAULT), vma))) { >> -        int rc = bad_access_pkey(regs, address, vma); >> - >>           vma_end_read(vma); >> -        return rc; >> +        goto lock_mmap; >>       } >>         if (unlikely(access_error(is_write, is_exec, vma))) { >> -        int rc = bad_access(regs, address); >> - >>           vma_end_read(vma); >> -        return rc; >> +        goto lock_mmap; >>       } >>         fault = handle_mm_fault(vma, address, flags | >> FAULT_FLAG_VMA_LOCK, regs); > > IIUC, that commit is neither upstream not in mm-stable -- it's unstable. > Maybe raise that as a review comment in reply to the original patch, so we > can easily connect the dots and squash it into the original, problematic > patch that is still under review. > Oh yes, I missed that. I'll reply to the Suren's thread. Thanks, Laurent.