Re: [PATCH 0/2] add a knob to control whether to use other nodes at the same tier of the target node in DAMON

Re: [PATCH 0/2] add a knob to control whether to use other nodes at the same tier of the target node in DAMON

[Simon Wang (王传国)]

> Thank you for sending this patch series!
> 
> On Wed, 28 May 2025 19:10:36 +0800 wangchuanguo
> <wangchuanguo@inspur.com> wrote:
> 
> > In DAMON's migrate_hot and migrate_cold features, the code was
> > intended to migrate pages ​​only to the node specified by target_nid​​.
> > However, during testing, it was observed that memory allocation and
> > migration could occur on ​​any nodes​​, which is a BUG.
> > The first patch in this PR fix this issue.
> >
> > A use_nodes_of_tier file has been added under the directory
> > /sys/kernel/mm/damon/admin/kdamonds/<N>/contexts/<N>/schemes/<N>/
> > to control whether to ​​use other nodes in the same tier as the target
> > node​​ for migration.
> 
> I left a few comments on the patches.  Looking forward to discussions on
> each sub-thread :)
> 
> >
> > wangchuanguo (2):
> 
> I believe your name is Wang Chuanguo?  Sorry if I read/wrote it wrongly.
> But we disallow[1] anonymous contributions, and prefer more formal
> Signed-off-by:
> if possible.  Could you please use such formal Signed-off-by: identity, say,
> "Wang Chuanguo <wangchuanguo@inspur.com>" from next time?

I'm sorry, this was my mistake. I will be more careful next time.

> [1]
> https://docs.kernel.org/process/submitting-patches.html#developer-s-certifica
> te-of-origin-1-1
> 
> 
> Thanks,
> SJ
> 
> [...]

Re: [PATCH 0/2] add a knob to control whether to use other nodes at the same tier of the target node in DAMON

[SeongJae Park]

Hi wangchuanguo,


Thank you for sending this patch series!

On Wed, 28 May 2025 19:10:36 +0800 wangchuanguo <wangchuanguo@inspur.com> wrote:

> In DAMON's migrate_hot and migrate_cold features, the code was
> intended to migrate pages ​​only to the node specified by target_nid​​.
> However, during testing, it was observed that memory allocation
> and migration could occur on ​​any nodes​​, which is a BUG.
> The first patch in this PR fix this issue.
> 
> A use_nodes_of_tier file has been added under the directory /sys/kernel/mm/damon/admin/kdamonds/<N>/contexts/<N>/schemes/<N>/
> to control whether to ​​use other nodes in the same tier as
> the target node​​ for migration.

I left a few comments on the patches.  Looking forward to discussions on each
sub-thread :)

> 
> wangchuanguo (2):

I believe your name is Wang Chuanguo?  Sorry if I read/wrote it wrongly.  But
we disallow[1] anonymous contributions, and prefer more formal Signed-off-by:
if possible.  Could you please use such formal Signed-off-by: identity, say,
"Wang Chuanguo <wangchuanguo@inspur.com>" from next time?

[1] https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1


Thanks,
SJ

[...]

[PATCH 0/2] add a knob to control whether to use other nodes at the same tier of the target node in DAMON

[wangchuanguo]

In DAMON's migrate_hot and migrate_cold features, the code was
intended to migrate pages ​​only to the node specified by target_nid​​.
However, during testing, it was observed that memory allocation
and migration could occur on ​​any nodes​​, which is a BUG.
The first patch in this PR fix this issue.

A use_nodes_of_tier file has been added under the directory /sys/kernel/mm/damon/admin/kdamonds/<N>/contexts/<N>/schemes/<N>/
to control whether to ​​use other nodes in the same tier as
the target node​​ for migration.

wangchuanguo (2):
  mm: migrate: restore the nmask after successfully allocating on the 
    target node
  mm/damon/sysfs-schemes: add use_nodes_of_tier on sysfs-schemes

 include/linux/damon.h        |  9 ++++++++-
 include/linux/memory-tiers.h |  5 +++++
 mm/damon/core.c              |  6 ++++--
 mm/damon/lru_sort.c          |  3 ++-
 mm/damon/paddr.c             | 19 ++++++++++++-------
 mm/damon/reclaim.c           |  3 ++-
 mm/damon/sysfs-schemes.c     | 31 ++++++++++++++++++++++++++++++-
 mm/memory-tiers.c            | 13 +++++++++++++
 mm/vmscan.c                  |  2 +-
 samples/damon/mtier.c        |  3 ++-
 samples/damon/prcl.c         |  3 ++-
 11 files changed, 81 insertions(+), 16 deletions(-)

-- 
2.39.3