From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F6B0C021BF for ; Wed, 26 Feb 2025 11:30:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB102280007; Wed, 26 Feb 2025 06:30:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E39F8280002; Wed, 26 Feb 2025 06:30:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8D69280007; Wed, 26 Feb 2025 06:30:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ABDAB280002 for ; Wed, 26 Feb 2025 06:30:40 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4D06F52738 for ; Wed, 26 Feb 2025 11:30:40 +0000 (UTC) X-FDA: 83161878240.27.81D197C Received: from pv50p00im-ztdg10011301.me.com (pv50p00im-ztdg10011301.me.com [17.58.6.40]) by imf30.hostedemail.com (Postfix) with ESMTP id 667758000B for ; Wed, 26 Feb 2025 11:30:38 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=icloud.com header.s=1a1hai header.b=rWtw35VN; spf=pass (imf30.hostedemail.com: domain of zijun_hu@icloud.com designates 17.58.6.40 as permitted sender) smtp.mailfrom=zijun_hu@icloud.com; dmarc=pass (policy=quarantine) header.from=icloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740569438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SOdlXl7RXO630hj2D8KbTA/iuYN0f3n9ChpjV2oMRbU=; b=jv9+Qe0Nlsp952ofPqTgHQ3OFGDk4BHiE6ldC+5OveikjVK4el3xucWuu1Y0qLgp1JTzUq Jrkah9u7v+AR0qRwNtFeBDG49NGvq+4PMunCIzhc+B0QeE6k/gd1N/2V3VkDSefzWqA+0c BZtd4FLZINoEY9K1KBJYT2lv8rwM44M= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=icloud.com header.s=1a1hai header.b=rWtw35VN; spf=pass (imf30.hostedemail.com: domain of zijun_hu@icloud.com designates 17.58.6.40 as permitted sender) smtp.mailfrom=zijun_hu@icloud.com; dmarc=pass (policy=quarantine) header.from=icloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740569438; a=rsa-sha256; cv=none; b=jQzTFTfgQZiMUiZ/e/rEosPB0/vZRe302sxYdLcE+88YHUUSoy3d6/94YvXTXfFVfOD0Bu Lnm+lSRuuoft+tzcnp8dMsl1k4XQ9uEnzdsR4CKVuyJgLu1yXOA3CPw/qdLTmsIHKoD3So xta5+nkMW1z1tlgGIGYwgN+1vRppgoU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=SOdlXl7RXO630hj2D8KbTA/iuYN0f3n9ChpjV2oMRbU=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type:x-icloud-hme; b=rWtw35VN5C7ebUryxGYabBiGNkfRxevNXaKu3lmmbcfRwCfqvGmsARTKGVlEDc3vJ IUw+i/jF2/O7wPykYL7GtrScwR7YHPk2KZArZBlYEByVg4HG2euMsCf4SLAhxqqINe T4aLRNRVMNlFJyn+/hO3Lmf6LkZiGLt8eWLCMvUUCNYIgCuhqhS16/5+FYQBrqDBv9 cTNT5EvlskIwUWEEZthrUNkKMbaMBoPHtGY9C1f3/Wkj+mhDFLP1F1CqAqbIZvoN+x V8XpPNLsrc2QkugOEEdKPXC0Zg7dBaQpmDQ+gMVmCM7ShlzUTzFJzMqx6xBRgIBMy+ ioIbkere3zE9w== Received: from [192.168.1.26] (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10011301.me.com (Postfix) with ESMTPSA id EAC1C18036A; Wed, 26 Feb 2025 11:30:23 +0000 (UTC) Message-ID: Date: Wed, 26 Feb 2025 19:30:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH *-next 01/18] mm/mmu_gather: Remove needless return in void API tlb_remove_page() To: Przemek Kitszel Cc: Zijun Hu , Peter Zijlstra , Greg Kroah-Hartman , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Danilo Krummrich , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Johannes Berg , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , Bartosz Golaszewski , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux.dev, linux-mtd@lists.infradead.org References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> <20250221-rmv_return-v1-1-cc8dff275827@quicinc.com> <20250221200137.GH7373@noisy.programming.kicks-ass.net> <8f36be7c-6052-4c5d-85ff-0eed27cf1456@icloud.com> <20250224132354.GC11590@noisy.programming.kicks-ass.net> <15c121c7-aeed-480e-8b1a-8ff23b4a3654@intel.com> Content-Language: en-US From: Zijun Hu In-Reply-To: <15c121c7-aeed-480e-8b1a-8ff23b4a3654@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: BXt7ADwYEBiuzX8MsPltF1M0d6Q_8HN4 X-Proofpoint-ORIG-GUID: BXt7ADwYEBiuzX8MsPltF1M0d6Q_8HN4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-26_02,2025-02-26_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0 clxscore=1015 suspectscore=0 mlxscore=0 adultscore=0 mlxlogscore=993 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2502260092 X-Rspam-User: X-Rspamd-Queue-Id: 667758000B X-Stat-Signature: kq5i3h8trzxyajub3a79rf8xu6qtg31z X-Rspamd-Server: rspam03 X-HE-Tag: 1740569438-697111 X-HE-Meta: U2FsdGVkX1+/mCxD1HOeoPxdQ8xwDKkvVKgjkd9tohBYm9gqVne5Tk3tHeclJXV59HU/ebCUWI/wLPrtvtlVbNepYyUc7mn7WwLPiXq9cVbQUNmSe8eiOjSnrjkXXYBTYbubkjWzpxl0pxI851ZqHOgs51kiz8e7D/Et2jZhmBqsf2q5vzXoy4w06caLw7Imut8MZniAx4s7KTTisEjSsyK/YtPr6/6nqZQY0vMbXTroVta7jV01Si7de64ylBCdCeGwmy23hoyNohuLVoBvNbhHYRB+c9yBm8sIEv3z+WEoGRREDYoPXn0qrr3+RJtC82oH6Vb3g2kAPdowL76CJeQdDLCWU8pqqDRcFEtA03X8ifl7vyeiWag0Awaia4QQeoshJi5B6FVflp+0A4hG0Py3ua02OATJ4OvkhkwpubIKo4ssrcTfvAGD7aw+VxIf4h1EkfsjVLSuVUW3z7VF/xjCX+oDmAIlSobAnMFq7CTHYGglIXk3DLfcTFWLMq4Oo9u1+ObO6utZgbWzHUsLxlb6Hb+oeuyj3JG8JqgKZwRvBVraoZ6bribPwm07d/nakeFnqGkWkdvcRmSfbWgBvmepCUOd06HMcxE2vmIvHWax8rXuEjScnPHkrwKen/ESsu8rN9V4422GZ+JNrTyGXWBMBrL724se3C8tmxt1pQLZrPaAosTKNa8dEF0+LIniH8rs8Q4K+n1FfNQ7ZcTtkDUT6+0ExibY7uF/VbTWZhjcST3BxKSS1x1EMRIiUke4UgaJewuVDmN/7dEskG4y1EezjrQ4k8vLNQcna8iK5XbVpCqxRcJLOMEuGxlPd1Ayo82yTgygIESE3DGnFXVOv0gz6dOA/Y9N9wwykWXY2kdQ+RQhWL88BlFaGon55sQCz4cO8HpJEIXGZRCrifNK0iFs1mt35er/6EF+Krk5fK5FZiIuzykFcGlMR6AYlqdMl69lPGKvbz9IaNKd5yT vSVGBkuU GgKnm+l7/VcTpdbeD0GXo66RbF5pn/FiZiyxRwJidJlyt3bjSAfklzSowKKh/zNSnT7PrfDMsz0XZIf0XAtJpFMUpeKRl+y2wFpRG/lF9LYiTY/pYoWB9z2eSesASE2f+T3HpmokmPrQEzhxsLrUHeEkOFo6vo6Y0R2JghQnd7OsCm6Y/gI6XB9PZ5visEHHHxYDLddfcuR+OMVS2R66b6Z0DmQNTwZJy1yKKKIKMv9OgnuD5C3qjoCNg9jAKT95CKrfnbUV/u/8o2FFObl82nwI+2a9/LowCyUkS0aLq5DqbyI5sSL39gKoeb011v3/IujWN7qH0/XzQH6+8c7d5e2DkLV+QFs6yPiJDFIj3Yj3/rnH2/qQekcQ4ZeJkE8gjWz9valP37pSRgnvCRWgdgfhtOjo2BaM+7ngxj5Ey3l7ll2EATI76mAK+bVfgpcTXjKIi8wRGXF37se+FtBGKHf5E6oyohU2RcXXpKzlFwY7b52A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/26 01:27, Przemek Kitszel wrote: >>>>> It might not be your preferred coding style, but it is not completely >>>>> pointless. >>>> >>>> based on below C spec such as C17 description. i guess language C does >>>> not like this usage "return void function in void function"; >>> >>> This is GNU extension IIRC. Note kernel uses GNU11, not C11 >> >> any link to share about GNU11's description for this aspect ? (^^) > this is new for C17 or was there for long time? > Standard C spec has that description for long time. Standard C11 spec also has that description. > even if this is an extension, it is very nice for generating locked > wrappers, so you don't have to handle void case specially > > void foo_bar(...) > { >     lockdep_assert_held(&a_lock); >     /// ... > } > > // generated > void foo_bar_lock(...) > { >     scoped_guard(mutex, &a_lock) >         return foo_bar(...); above is able to be written as below: scoped_guard(mutex, &a_lock) { foo_bar(...); return; } > } i will list my reasons why this usage "return void function in void function" is not good in cover letter [00/18] of this series.