From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7178C388F7 for ; Thu, 5 Nov 2020 10:42:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2CD7E206E3 for ; Thu, 5 Nov 2020 10:42:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CD7E206E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1D0EE6B00D3; Thu, 5 Nov 2020 05:42:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 15A806B00D4; Thu, 5 Nov 2020 05:42:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 047116B00D5; Thu, 5 Nov 2020 05:42:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id C40436B00D3 for ; Thu, 5 Nov 2020 05:42:36 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 528A01EE6 for ; Thu, 5 Nov 2020 10:42:36 +0000 (UTC) X-FDA: 77450025912.27.pain42_340d2b9272c9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 396AC3D669 for ; Thu, 5 Nov 2020 10:42:36 +0000 (UTC) X-HE-Tag: pain42_340d2b9272c9 X-Filterd-Recvd-Size: 5099 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Nov 2020 10:42:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4FC27AD18; Thu, 5 Nov 2020 10:42:34 +0000 (UTC) To: Kalle Valo , Pavel Procopiuc , david@redhat.com Cc: ath11k@lists.infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org References: <87lffjodu7.fsf@codeaurora.org> <87ft5rszcs.fsf@codeaurora.org> <87ft5qsem9.fsf@codeaurora.org> <87blgdscxd.fsf@codeaurora.org> <229c31e7-9aff-18e6-a6db-be7b46331173@gmail.com> <87361onphy.fsf_-_@codeaurora.org> From: Vlastimil Babka Subject: Re: Regression: QCA6390 fails with "mm/page_alloc: place pages to tail in __free_pages_core()" Message-ID: Date: Thu, 5 Nov 2020 11:42:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87361onphy.fsf_-_@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/5/20 10:04 AM, Kalle Valo wrote: > (changing the subject, adding more lists and people) >=20 > Pavel Procopiuc writes: >=20 >> Op 04.11.2020 om 10:12 schreef Kalle Valo: >>> Yeah, it is unfortunately time consuming but it is the best way to ge= t >>> bottom of this. >> >> I have found the commit that breaks things for me, it's >> 7fef431be9c9ac255838a9578331567b9dba4477 mm/page_alloc: place pages to >> tail in __free_pages_core() >> >> I've reverted it on top of the 5.10-rc2 and ath11k driver loads fine >> and I have wifi working. >=20 > Oh, very interesting. Thanks a lot for the bisection, otherwise we woul= d > have never found out whats causing this. >=20 > David & mm folks: Pavel noticed that his QCA6390 Wi-Fi 6 device (driver > ath11k) failed on v5.10-rc1. After bisecting he found that the commit > below causes the regression. I have not been able to reproduce this and > for me QCA6390 works fine. I don't know if this needs a specific kernel > configuration or what's the difference between our setups. >=20 > Any ideas what might cause this and how to fix it? >=20 > Full discussion: http://lists.infradead.org/pipermail/ath11k/2020-Novem= ber/000501.html >=20 > commit 7fef431be9c9ac255838a9578331567b9dba4477 > Author: David Hildenbrand > AuthorDate: Thu Oct 15 20:09:35 2020 -0700 > Commit: Linus Torvalds > CommitDate: Fri Oct 16 11:11:18 2020 -0700 >=20 > mm/page_alloc: place pages to tail in __free_pages_core() >=20 Let me paste from the ath11k discussion: > * Relevant errors from the log: > # journalctl -b | grep -iP '05:00|ath11k' > Nov 02 10:41:26 razor kernel: pci 0000:05:00.0: [17cb:1101] type 00 cla= ss 0x028000 > Nov 02 10:41:26 razor kernel: pci 0000:05:00.0: reg 0x10: [mem 0xd21000= 00-0xd21fffff 64bit] > Nov 02 10:41:26 razor kernel: pci 0000:05:00.0: PME# supported from D0 = D3hot D3cold > Nov 02 10:41:26 razor kernel: pci 0000:05:00.0: 4.000 Gb/s available PC= Ie bandwidth, limited by 5.0 GT/s PCIe x1 link at=20 > 0000:00:1c.1 (capable of 7.876 Gb/s with 8.0 GT/s PCIe x1 link) > Nov 02 10:41:26 razor kernel: pci 0000:05:00.0: Adding to iommu group 2= 1 > Nov 02 10:41:27 razor kernel: ath11k_pci 0000:05:00.0: WARNING: ath11k = PCI support is experimental! > Nov 02 10:41:27 razor kernel: ath11k_pci 0000:05:00.0: BAR 0: assigned = [mem 0xd2100000-0xd21fffff 64bit] > Nov 02 10:41:27 razor kernel: ath11k_pci 0000:05:00.0: enabling device = (0000 -> 0002) > Nov 02 10:41:27 razor kernel: mhi 0000:05:00.0: Requested to power ON > Nov 02 10:41:27 razor kernel: mhi 0000:05:00.0: Power on setup success > Nov 02 10:41:27 razor kernel: ath11k_pci 0000:05:00.0: Respond mem req = failed, result: 1, err: 0 This seems to be ath11k_qmi_respond_fw_mem_request(). Why is it failure w= ith=20 error 0? No idea. What would happen if all the GFP_KERNEL in the file were changed to GFP_D= MA32? I'm thinking the hardware perhaps doesn't like too high physical addresse= s or=20 something. But if I think correctly, freeing to tail should actually move= them=20 towards head. So it's weird. > Nov 02 10:41:27 razor kernel: ath11k_pci 0000:05:00.0: qmi failed to re= spond fw mem req:-22 > Nov 02 10:41:32 razor kernel: ath11k_pci 0000:05:00.0: qmi failed memor= y request, err =3D -110 > Nov 02 10:41:32 razor kernel: ath11k_pci 0000:05:00.0: qmi failed to re= spond fw mem req:-110 > Nov 02 10:42:58 razor kernel: mhi 0000:05:00.0: Device failed to exit M= HI Reset state