From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FAAC4338F for ; Tue, 27 Jul 2021 12:19:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A33AD61A3F for ; Tue, 27 Jul 2021 12:19:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A33AD61A3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 093218D0001; Tue, 27 Jul 2021 08:19:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 043A66B005D; Tue, 27 Jul 2021 08:19:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4D7F8D0001; Tue, 27 Jul 2021 08:19:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id C83486B0036 for ; Tue, 27 Jul 2021 08:19:08 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6FE80181B0493 for ; Tue, 27 Jul 2021 12:19:08 +0000 (UTC) X-FDA: 78408272376.29.DB7B358 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 13CFFF003203 for ; Tue, 27 Jul 2021 12:19:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627388347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cyg4OzSfCVK2ArH8hMcR0QU6etJZdNnz5j7NaiTQwfM=; b=A1gqzgtgdu7+x37KOe4R+lmlTDVNXFYvhghjcMmRNIEKMbaGOVJUpwF4HvPh4/Ucc4ZJt1 qpTZXzPKYfMM5Pexkcvdp1jjTr6bc2vnDX4nSFwFGQvlCCnN4RhcaNyxCOb09zGOkhL+D/ /oPxxBwBpd0fgV0bFv924zRv/SGogXE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-587-M9KfwTZNORupoLXhhn09CA-1; Tue, 27 Jul 2021 08:19:05 -0400 X-MC-Unique: M9KfwTZNORupoLXhhn09CA-1 Received: by mail-wr1-f72.google.com with SMTP id l14-20020a5d560e0000b029013e2b4ee624so5996901wrv.1 for ; Tue, 27 Jul 2021 05:19:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Cyg4OzSfCVK2ArH8hMcR0QU6etJZdNnz5j7NaiTQwfM=; b=FHwUT+rpplDpbDmjItEVyHz/JZP37qLgIJdV+YNg0CxWRGmh2YEHCkg/TfPgELgm7D nBmoBrPTIq9ZMMvCR4PgvhS+0QdfdM+aMWHXbFTmFNqBtifn3ydsltOBfILxu+l5fTpg mbnyWZhApsWe1YzlTehDAbKdSkoWNwDLjfZSzGQG9jTiRvVpcH8gdvlPKR4ar5QwJM3o Gy3xjXkPAJFo48Ac1wKYLim55bggYj81l+xkw7kH9lmtQdQhPuoD5LakAaNnAjU8Heby 8erWI82YREP2S8WOZX2xjoxN72ro+NfoyC8T7KZu98/JxENXR2jp2R79CZF1SGnv+FP4 SJVA== X-Gm-Message-State: AOAM531lEoLukF/4Biw4vl01lb81yBYHz52eTsKWUnVrmgHQ0mjKGkcf 4svPbaEiNc+6aqjUn6KtkyJFCb6CSuUmkvo1o3guUd6c4vpcEPvEEhyGDupY27QHwRLTL0wcdAS XNi8YDbkY9i0= X-Received: by 2002:a5d:6da3:: with SMTP id u3mr24255759wrs.394.1627388344515; Tue, 27 Jul 2021 05:19:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoTD6xViLCv6Sh6eedwOX3/SDyry/1WTpnxYqWWSunam9tACK6ql5CgDJUDnxSNGHSYP0KSA== X-Received: by 2002:a5d:6da3:: with SMTP id u3mr24255732wrs.394.1627388344358; Tue, 27 Jul 2021 05:19:04 -0700 (PDT) Received: from [192.168.3.132] (p4ff23c36.dip0.t-ipconnect.de. [79.242.60.54]) by smtp.gmail.com with ESMTPSA id y66sm2904831wmy.39.2021.07.27.05.19.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jul 2021 05:19:03 -0700 (PDT) Subject: Re: [PATCH v2] mm: Enable suspend-only swap spaces To: Pavel Machek Cc: Michal Hocko , Evan Green , Andrew Morton , Alex Shi , Alistair Popple , Jens Axboe , Johannes Weiner , Joonsoo Kim , "Matthew Wilcox (Oracle)" , Miaohe Lin , Minchan Kim , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org References: <20210709105012.v2.1.I09866d90c6de14f21223a03e9e6a31f8a02ecbaf@changeid> <30dddfb1-388c-a593-0987-73e821216da9@redhat.com> <20210727120413.GB32265@duo.ucw.cz> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Tue, 27 Jul 2021 14:19:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210727120413.GB32265@duo.ucw.cz> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A1gqzgtg; spf=none (imf17.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 13CFFF003203 X-Stat-Signature: sgq7qadzdrx3hfatgtcy8owgkxztbstt X-HE-Tag: 1627388347-448134 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.07.21 14:04, Pavel Machek wrote: > Hi! > >> Let's take a look at hibernate() callers: >> >> drivers/mfd/tps65010.c: calls hibernate() from IRQ contex, based on HW >> event > > No it does not. Look again. > Oh, dead code :) >> kernel/power/autosleep.c: calls hibernate() when it thinks it might be >> a good time to go to sleep > > Ok, you are right, it is there. But I don't believe anyone uses this > configuration. If it's dead code, we might want to look into deprecating and removing it. It was introduced around 2012: https://lwn.net/Articles/479841/ -- Thanks, David / dhildenb