From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 174C6C433EF for ; Fri, 22 Oct 2021 12:29:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 90D7660F46 for ; Fri, 22 Oct 2021 12:29:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 90D7660F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0D4CE900003; Fri, 22 Oct 2021 08:29:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08424900002; Fri, 22 Oct 2021 08:29:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E66AE900003; Fri, 22 Oct 2021 08:29:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id D64A5900002 for ; Fri, 22 Oct 2021 08:29:04 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8947D8249980 for ; Fri, 22 Oct 2021 12:29:04 +0000 (UTC) X-FDA: 78724003008.21.6F2F6D5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf18.hostedemail.com (Postfix) with ESMTP id E5D88400209D for ; Fri, 22 Oct 2021 12:28:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634905743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YuUgTaC7SncRn/56fPFHOc3RSrpIisjOLVPx5zTF8wM=; b=Yo0ReFKCg99uRbF4u3kCBENaSLKDOSZjw+mlsShssRvqRbBJ5BLohR3SKBlWL5y3vb8PIB GWqsBcijeRMC+fWvviFFpnK2m0fUxTbG24rTD2PidPExpqYAczvbtLkl3D5VtfMTS4NkQ2 1aNRveSe32j+I3eJw3NwVDwAFt1ikZI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-517-JkgKiv-XPwWOG5ukhuRYBQ-1; Fri, 22 Oct 2021 08:29:02 -0400 X-MC-Unique: JkgKiv-XPwWOG5ukhuRYBQ-1 Received: by mail-wm1-f71.google.com with SMTP id g4-20020a1c9d04000000b0030dd4dd6659so1099188wme.3 for ; Fri, 22 Oct 2021 05:29:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=YuUgTaC7SncRn/56fPFHOc3RSrpIisjOLVPx5zTF8wM=; b=hSBgEEWuW5pxhI3k76QYXpJRTjlDV09xItEPRI1l3TXQpEmO1HTO6TCAvQMrfc6fru 19UErbAxJiReWEWL4hCq5YF3LNHmf0/6ps+zt1ULOxQiwxVpos2U16dys6ql++7RyIkW lXD0b98+2ta7QTePvclJwBqQun28lk7fnKT2pFdyROODZHzz/uksK0tawxHWniaj2kAy MmW1FRrm7Uu8KXDEyFmkpu8/cA3Afss/+pnRUi2dnjsOimqzNSN8s16s6wJm1A/M1dia TCIaMOfB/w3fRL0t1jrem73P7W8MdzbeVNGnx4f3k3JzwzIGMGr8tGk1R6g+haKKCytw Mu7g== X-Gm-Message-State: AOAM530BH4w+2TRZ0HSmfQiGjiFV2UyT5rmzR6PzCZgXZxEaylcgjvK7 DGki92JeB36I8KyvzKHKgp9o5N2nOYgsqqfHnGNmhUx88pKRvuKNfbk7lr45idMSxKAOAyEi+PT S49wjUBca8Os= X-Received: by 2002:adf:b355:: with SMTP id k21mr15307018wrd.380.1634905741162; Fri, 22 Oct 2021 05:29:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8b0jvSBO/rDYlcgNKG5q+gpSX25bwLoicK9Z2PsuXIXbBKjkxBVkfERN2zEYyrkQpuyMqbA== X-Received: by 2002:adf:b355:: with SMTP id k21mr15306985wrd.380.1634905740893; Fri, 22 Oct 2021 05:29:00 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6324.dip0.t-ipconnect.de. [91.12.99.36]) by smtp.gmail.com with ESMTPSA id h14sm3553851wmq.34.2021.10.22.05.28.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Oct 2021 05:29:00 -0700 (PDT) Message-ID: Date: Fri, 22 Oct 2021 14:28:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v3] kasan: add kasan mode messages when kasan init To: Kuan-Ying Lee , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Catalin Marinas , Will Deacon , Andrew Morton , Matthias Brugger , Marco Elver Cc: chinwen.chang@mediatek.com, yee.lee@mediatek.com, nicholas.tang@mediatek.com, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-mediatek@lists.infradead.org References: <20211020094850.4113-1-Kuan-Ying.Lee@mediatek.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211020094850.4113-1-Kuan-Ying.Lee@mediatek.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E5D88400209D Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Yo0ReFKC; spf=none (imf18.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: ek6tyjq9qi9b8ou1amb6kuun3t1yo5z3 X-Rspamd-Server: rspam06 X-HE-Tag: 1634905739-63638 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.10.21 11:48, Kuan-Ying Lee wrote: > There are multiple kasan modes. It makes sense that we add some messages > to know which kasan mode is when booting up. see [1]. s/is/is active/ ? Looks reasonable to me Reviewed-by: David Hildenbrand > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=212195 [1] > Signed-off-by: Kuan-Ying Lee > --- > v3: > - Rebase to linux-next > - Move kasan_mode_info() into hw_tags.c > v2: > - Rebase to linux-next > - HW-tag based mode need to consider asymm mode > - Thanks Marco's suggestion > > arch/arm64/mm/kasan_init.c | 2 +- > mm/kasan/hw_tags.c | 14 +++++++++++++- > mm/kasan/sw_tags.c | 2 +- > 3 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > index 5b996ca4d996..6f5a6fe8edd7 100644 > --- a/arch/arm64/mm/kasan_init.c > +++ b/arch/arm64/mm/kasan_init.c > @@ -309,7 +309,7 @@ void __init kasan_init(void) > kasan_init_depth(); > #if defined(CONFIG_KASAN_GENERIC) > /* CONFIG_KASAN_SW_TAGS also requires kasan_init_sw_tags(). */ > - pr_info("KernelAddressSanitizer initialized\n"); > + pr_info("KernelAddressSanitizer initialized (generic)\n"); > #endif > } > > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > index dc892119e88f..7355cb534e4f 100644 > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -106,6 +106,16 @@ static int __init early_kasan_flag_stacktrace(char *arg) > } > early_param("kasan.stacktrace", early_kasan_flag_stacktrace); > > +static inline const char *kasan_mode_info(void) > +{ > + if (kasan_mode == KASAN_MODE_ASYNC) > + return "async"; > + else if (kasan_mode == KASAN_MODE_ASYMM) > + return "asymm"; > + else > + return "sync"; > +} > + > /* kasan_init_hw_tags_cpu() is called for each CPU. */ > void kasan_init_hw_tags_cpu(void) > { > @@ -177,7 +187,9 @@ void __init kasan_init_hw_tags(void) > break; > } > > - pr_info("KernelAddressSanitizer initialized\n"); > + pr_info("KernelAddressSanitizer initialized (hw-tags, mode=%s, stacktrace=%s)\n", > + kasan_mode_info(), > + kasan_stack_collection_enabled() ? "on" : "off"); > } > > void kasan_alloc_pages(struct page *page, unsigned int order, gfp_t flags) > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > index bd3f540feb47..77f13f391b57 100644 > --- a/mm/kasan/sw_tags.c > +++ b/mm/kasan/sw_tags.c > @@ -42,7 +42,7 @@ void __init kasan_init_sw_tags(void) > for_each_possible_cpu(cpu) > per_cpu(prng_state, cpu) = (u32)get_cycles(); > > - pr_info("KernelAddressSanitizer initialized\n"); > + pr_info("KernelAddressSanitizer initialized (sw-tags)\n"); > } > > /* > -- Thanks, David / dhildenb