From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F97BC433F5 for ; Fri, 27 May 2022 01:34:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EBDF8D0003; Thu, 26 May 2022 21:34:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 698DE8D0002; Thu, 26 May 2022 21:34:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 588C38D0003; Thu, 26 May 2022 21:34:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 468998D0002 for ; Thu, 26 May 2022 21:34:38 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 17CC3120B98 for ; Fri, 27 May 2022 01:34:38 +0000 (UTC) X-FDA: 79509803436.15.2B991A3 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by imf13.hostedemail.com (Postfix) with ESMTP id 4C7522003E for ; Fri, 27 May 2022 01:34:06 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VEUq88P_1653615271; Received: from 30.32.82.202(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VEUq88P_1653615271) by smtp.aliyun-inc.com(127.0.0.1); Fri, 27 May 2022 09:34:32 +0800 Message-ID: Date: Fri, 27 May 2022 09:34:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] mm/hugetlb: Remove unnecessary huge_ptep_set_access_flags() in hugetlb_mcopy_atomic_pte() To: Anshuman Khandual , mike.kravetz@oracle.com, akpm@linux-foundation.org, songmuchun@bytedance.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <7cd55152c1a00910afda570d1543a97198b3665b.1653468078.git.baolin.wang@linux.alibaba.com> <428c7c69-6ac1-51d5-7c26-5f31de61a909@arm.com> From: Baolin Wang In-Reply-To: <428c7c69-6ac1-51d5-7c26-5f31de61a909@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf13.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.45 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4C7522003E X-Stat-Signature: khsfm7jaxcp19c7rr1rbs3pg33a48xi4 X-HE-Tag: 1653615246-234494 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/26/2022 3:01 PM, Anshuman Khandual wrote: > > > On 5/25/22 15:56, Baolin Wang wrote: >> There is no need to update the hugetlb access flags after just setting the >> hugetlb page table entry by set_huge_pte_at(), since the page table entry >> value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags() > > WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) > #9: > value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags() > > total: 0 errors, 1 warnings, 8 lines checked Sure, will remove checkpatch warning in next verion. > >> in hugetlb_mcopy_atomic_pte(). >> >> Signed-off-by: Baolin Wang > > Otherwise LGTM, > > Reviewed-by: Anshuman Khandual Thanks. Also thanks to Muchun and Mike for reviewing.