From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
mike.kravetz@oracle.com, akpm@linux-foundation.org,
songmuchun@bytedance.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/hugetlb: Remove unnecessary huge_ptep_set_access_flags() in hugetlb_mcopy_atomic_pte()
Date: Fri, 27 May 2022 09:34:59 +0800 [thread overview]
Message-ID: <d6f64c75-053d-57e0-a997-176758523d9e@linux.alibaba.com> (raw)
In-Reply-To: <428c7c69-6ac1-51d5-7c26-5f31de61a909@arm.com>
On 5/26/2022 3:01 PM, Anshuman Khandual wrote:
>
>
> On 5/25/22 15:56, Baolin Wang wrote:
>> There is no need to update the hugetlb access flags after just setting the
>> hugetlb page table entry by set_huge_pte_at(), since the page table entry
>> value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags()
>
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #9:
> value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags()
>
> total: 0 errors, 1 warnings, 8 lines checked
Sure, will remove checkpatch warning in next verion.
>
>> in hugetlb_mcopy_atomic_pte().
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>
> Otherwise LGTM,
>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Thanks. Also thanks to Muchun and Mike for reviewing.
prev parent reply other threads:[~2022-05-27 1:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 10:26 Baolin Wang
2022-05-25 13:25 ` Muchun Song
2022-05-25 17:39 ` Mike Kravetz
2022-05-26 7:01 ` Anshuman Khandual
2022-05-27 1:34 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6f64c75-053d-57e0-a997-176758523d9e@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox