From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84787EB64DC for ; Tue, 11 Jul 2023 10:23:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 205666B0074; Tue, 11 Jul 2023 06:23:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B48E6B0078; Tue, 11 Jul 2023 06:23:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07CC46B007B; Tue, 11 Jul 2023 06:23:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EDD936B0074 for ; Tue, 11 Jul 2023 06:23:24 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CCF0DAFBE1 for ; Tue, 11 Jul 2023 10:23:24 +0000 (UTC) X-FDA: 80998943928.18.3FD1799 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 93739140012 for ; Tue, 11 Jul 2023 10:23:22 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SBV64bMV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689071002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=up9Wd6IlUgX+685tcIeRwIiBa7KZEfihner4D6aXUpE=; b=uWWc0wo32Aun9zmLX7iPa9qZna3xqyiBiVI1YGdCIvHssHDA2ysn23NG7k7bl2JURU5GFo IrJD/jYbDch6cy/Udhmpgkg30DLEsbSuTxQYjcjQSwlty7EHFTGEDeN7H+lWRlKpzihyx9 TWG6DrP1AN0u1La58Ee4APHwTBovxyI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SBV64bMV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689071002; a=rsa-sha256; cv=none; b=H6TbFdIUkUOt0FnCvL7kuntZRMokmzFeA+0bGcBFwZa9IfNAbD7EhEwYYeD5leqJDQVGEy WwkhPPUa3M/04lKqZ7XMBgV9KakYkRrQVroagc27UfcGa1ZpA5bL8LChKRO3oBAIJZFOtO mp7TICSI8IOs3CTJEStPZsYzxrU7HeA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689071002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=up9Wd6IlUgX+685tcIeRwIiBa7KZEfihner4D6aXUpE=; b=SBV64bMV/dl8Z+sGyLHl5T0O1kxQfzdHHc4Cv0hi+SSEwh5Ytd7T67yNJCYTaMeex1JGA6 CnD4H+P/UvlBTRH3BtnAj2slHLwjEqNFSebhfV8FFpLnEwKnN1AkH8+PGfdJ2DlAxApW4T MMykRp8gcwvo5KFOE/c6Vm391d7d+D4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-391-k8baUYM2MimNXTnkJHIZ1g-1; Tue, 11 Jul 2023 06:23:20 -0400 X-MC-Unique: k8baUYM2MimNXTnkJHIZ1g-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fc020021efso26234635e9.0 for ; Tue, 11 Jul 2023 03:23:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689070999; x=1691662999; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=up9Wd6IlUgX+685tcIeRwIiBa7KZEfihner4D6aXUpE=; b=KmG6s+ESgRheS0m/qe8vc4lF7+ugVqpwL8IdB2kFBRWUT5wIFth+BrrFJw12mAq3kL RQYZmsAqxepwWhT3iERrO+jGpQBzJvxTIcOr2XHaSpVhr/U6lwU14Kww1+4wYyHkpOki Mtq0ByWKrdsHBXaDhMG+IIs/ZJjTISGRnbxOhRd+lr2S4OiI4U4kEidJDRRMBWD83bw5 E4kFsdWpd8A+zgRrYhH+AGlpQM7Bgorh57uAAfUQpsC4isvusA3w3VDYi6mMBdNwWaKt r7b332cTGPPspgz2dlj9/4QmQq3i2K4k7kb8G2kk7kNBvcmajqtZ7eEB+PDE1qTXGqka V8kg== X-Gm-Message-State: ABy/qLZ/qLjQpjuuDEUBjzhOpFcRSCiZCSP18KtMadCb8K+xX8sLiSa2 GJ+hS/WhGoDqiOk4cv+U9b2WF9jnSf0BDC53OaDtsH19LDP66v96uasAFOGnpMX8bu2K+Oihyqs DdO2BzmgNwDE= X-Received: by 2002:adf:ef0e:0:b0:314:1e47:8bc2 with SMTP id e14-20020adfef0e000000b003141e478bc2mr16635774wro.0.1689070999709; Tue, 11 Jul 2023 03:23:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlHoNQ5m+ASdMSmYWODgj0vIAuLSCLYIfL7R+h+/NTLZfVZg+5f1lWHOKvgvXm/YtBwMFpahzg== X-Received: by 2002:adf:ef0e:0:b0:314:1e47:8bc2 with SMTP id e14-20020adfef0e000000b003141e478bc2mr16635756wro.0.1689070999380; Tue, 11 Jul 2023 03:23:19 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:4000:13ad:ed64:37e6:115d? (p200300cbc745400013aded6437e6115d.dip0.t-ipconnect.de. [2003:cb:c745:4000:13ad:ed64:37e6:115d]) by smtp.gmail.com with ESMTPSA id o13-20020a5d684d000000b00314315071bbsm1877722wrw.38.2023.07.11.03.23.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 03:23:18 -0700 (PDT) Message-ID: Date: Tue, 11 Jul 2023 12:23:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 2/7] mm/hotplug: Allow memmap on memory hotplug request to fallback To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma References: <20230711044834.72809-1-aneesh.kumar@linux.ibm.com> <20230711044834.72809-3-aneesh.kumar@linux.ibm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230711044834.72809-3-aneesh.kumar@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 8aufuatfibjzwg597cozdf5hp9q51jj5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 93739140012 X-HE-Tag: 1689071002-310241 X-HE-Meta: U2FsdGVkX1/+TvHRRv+ev4lg/l7anlUiT1k+KBsleQ48kVmfW0BSqn95D3voxXr/NEPEKaFfueU+m9jCxPuatNkJom5/k7JJUgvph+XZA/11rBXnsK9Q6c9PakmjSE9t+U89ymWP5w0lduad4QxEI/9BuL2LUbVF3FT7JCQFDnASs29WUoKYVQJRAVSQdiSLos9benkeB5kMhdtIfuUm5+mRZnPU0zFHqfCoasQoDy0BX3qd0HTsuBdKdZ2scNLhz9QXzD9aDQ2sbb1x4TP4KItfvtsldjilcYehwe27zJEXmdWK4XzBUXpA6XM038815SdX47GF2rKjwmHFdGunemw42CjlCjIvCzxAAy5CqC3F6/7MxlEf5uu06UrTBlH9pAwfp/TUU7S7EI1aZlfbNKqsvn0CBHxfj3lOB4ORkrLWL4b+1MBtRx8c+nHCkppHpZ/3tfg4lPRtSpa4yYccW2SPKeLF8nz8Euf9j+P9+pxeTzlep1SJrobe+LP0R5N4wjyiRFmb0fvI8q7jXXuYePEjx2UeEHToZq5Pgray5DhGDESiL7JyLBzaiQN1zax6Sx/4MZyHZ4m7jRAe/4Ff2NGKo/B+/Huq2bAefXFUxQ5/pJ4AJT6O/3oBsOmyFDHsi4I4oA9FOldk4XY0UIA1J5W/oZVsLqHbrZ8V597BWnz34UbSL4SBivy+d2KsMDUM94oXAFVtLBj5yiCKEP7s2lVLxkEG531v9qvPD4bY2QbbiwPKOR++CF4ZcyDcuQ8ZXcO/hMalSjPHF6NlXCaLi3C6vEKfI4n9L63G18susMlNonLhMOZsv4nUtj6WZYyVv7g1ZiHM4Yuwc0n1T+wHiRGbF57zqVW7wxyLtQiCWo1I/Trb3oPOTXhVLvLIXtWgGVGO/FJfqovCM2lDSqoZCm1UBpnRKcMI21IaDHiBRS1QZvpcqxGJQRMPWppJFUIDRpLFBvdxzzQHgTQjs2g qatP1ytq 0mx4a3k8Q0KzvXDkJ9f0PVUBdC8Qz02wzslAfCEyhKqBUT5/NYXm5aNmxqTgSrVIkY0/1aBKqTWyrQyMXJ7vxcainrNwF6jrU1D8H9wisaKfUwig4j1/e99EiVBdNXa4EB6LNyIBXXwgk0EvaT0c8oWb9EwF4OylT2wdIgQssws/7Nf4isPktwxCDS834tEgPSzRbbyaoEgFOUHgj9+c+r0xy0cwmaRNOyYOjmo/Tsy2YFLpuUc2u07tSaAsnNyJeyIxhQeCZLODUcfjmYSd88OEFYHwYWI8TTYN9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -bool mhp_supports_memmap_on_memory(unsigned long size) > +static bool mhp_supports_memmap_on_memory(unsigned long size) > { > unsigned long nr_vmemmap_pages = size / PAGE_SIZE; > unsigned long vmemmap_size = nr_vmemmap_pages * sizeof(struct page); > @@ -1339,13 +1339,12 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) > * Self hosted memmap array > */ > if (mhp_flags & MHP_MEMMAP_ON_MEMORY) { > - if (!mhp_supports_memmap_on_memory(size)) { > - ret = -EINVAL; > - goto error; > + if (mhp_supports_memmap_on_memory(size)) { > + mhp_altmap.free = PHYS_PFN(size); > + mhp_altmap.base_pfn = PHYS_PFN(start); > + params.altmap = &mhp_altmap; > } > - mhp_altmap.free = PHYS_PFN(size); > - mhp_altmap.base_pfn = PHYS_PFN(start); > - params.altmap = &mhp_altmap; > + /* fallback to not using altmap */ > } > > /* call arch's memory hotadd */ In general, LGTM, but please extend the documentation of the parameter in memory_hotplug.h, stating that this is just a hint and that the core can decide to no do that. -- Cheers, David / dhildenb