From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C58CC19F32 for ; Wed, 5 Mar 2025 19:34:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 184AB28001C; Wed, 5 Mar 2025 14:34:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10DD9280003; Wed, 5 Mar 2025 14:34:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC9F428001C; Wed, 5 Mar 2025 14:34:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C9128280003 for ; Wed, 5 Mar 2025 14:34:31 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9D8DA801AC for ; Wed, 5 Mar 2025 08:58:48 +0000 (UTC) X-FDA: 83186897136.10.941BF16 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 4BEB9C0004 for ; Wed, 5 Mar 2025 08:58:46 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QBN2RoNq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jyQxrt2U; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QBN2RoNq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jyQxrt2U; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741165126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1OftoI1DB4cvJjGkzyU+iWO8yuvHidyReureSIR4PIs=; b=EpQkQXBl23Uju/N2ruSDyJFo8qZAs2tIvK3SXzrG3fO9QXZFlZAXXisSfUpqmHiLSuCUlb tfZufK6jdrSwTv0OwMAo3OV/WxdN7m3XrMy6pmSoVcqFXStvQ9OCaNVoWyTYdhULq2fOxF 3pF/qF6ZZBrBgIL8QpPaZKQPWX2503w= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QBN2RoNq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jyQxrt2U; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QBN2RoNq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jyQxrt2U; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741165126; a=rsa-sha256; cv=none; b=BRh2zvKa1fQBT9bAbM2haj0kn/1LooQfSMduXHzuvJ1OcNURGO6Ta8T4KtixYOa0V8ktGt DR3GStZ3+hfWgBYXcr/UltwY3ABxa6njri0YsbaphVSGpyCDjnWaSqYmwzxsUZlmPiyOn3 rx5YG0zA+9kbIsUqVGnAskk1aH16drA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 75C361F76B; Wed, 5 Mar 2025 08:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741165124; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1OftoI1DB4cvJjGkzyU+iWO8yuvHidyReureSIR4PIs=; b=QBN2RoNqesTQzH9mRSX/z7LKlelWfeVkZ0rpOvRRFOCUIKzCbz5qCW+Cixz6q8Nky8r52O 0Z+JcVUOnSZ0dLZ0HVo+c2sOnl+vmax7pMtHjJnHMHjdJq5+xf7g8Lc1XOCEi2O7Wkg7EO Pm8U5i8pIAvN3bJUQD4AJJv6k39dbNg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741165124; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1OftoI1DB4cvJjGkzyU+iWO8yuvHidyReureSIR4PIs=; b=jyQxrt2UtYe/Q15ojvONj4DeFt8UD8ievHqBWOrk3c4Ud+bcSwU70l10ykm+xSVjjhBrou /oHsda5GOedkosAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741165124; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1OftoI1DB4cvJjGkzyU+iWO8yuvHidyReureSIR4PIs=; b=QBN2RoNqesTQzH9mRSX/z7LKlelWfeVkZ0rpOvRRFOCUIKzCbz5qCW+Cixz6q8Nky8r52O 0Z+JcVUOnSZ0dLZ0HVo+c2sOnl+vmax7pMtHjJnHMHjdJq5+xf7g8Lc1XOCEi2O7Wkg7EO Pm8U5i8pIAvN3bJUQD4AJJv6k39dbNg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741165124; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1OftoI1DB4cvJjGkzyU+iWO8yuvHidyReureSIR4PIs=; b=jyQxrt2UtYe/Q15ojvONj4DeFt8UD8ievHqBWOrk3c4Ud+bcSwU70l10ykm+xSVjjhBrou /oHsda5GOedkosAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 51AA613939; Wed, 5 Mar 2025 08:58:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yfeOE0QSyGdyYgAAD6G6ig (envelope-from ); Wed, 05 Mar 2025 08:58:44 +0000 Message-ID: Date: Wed, 5 Mar 2025 09:58:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Kernel oops with 6.14 when enabling TLS To: Hannes Reinecke , Hannes Reinecke , Matthew Wilcox Cc: Boris Pismenny , John Fastabend , Jakub Kicinski , Sagi Grimberg , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , linux-mm@kvack.org, Harry Yoo , "netdev@vger.kernel.org" References: <95b0b93b-3b27-4482-8965-01963cc8beb8@suse.cz> <6877dfb1-9f44-4023-bb6d-e7530d03e33c@suse.com> <27111897-0b36-4d8c-8be9-4f8bdbae88b7@suse.cz> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: rf17ss99kc791qepabeo63hxg4z5b11g X-Rspamd-Queue-Id: 4BEB9C0004 X-Rspamd-Server: rspam07 X-HE-Tag: 1741165126-392583 X-HE-Meta: U2FsdGVkX18S8HJlmIUwl62yt4RCxONUppK+8bhZV2T7m1kBEi4Z8ODxRUNwmCdnflgFH3cuv5S7PuoIXKh7PEDe0pNnE7dulxs8AkJDhwT4E6eBEUasAsPR/9EF8T6uhNo1cSH6VJPp8L6pHX2dH3bD909304golvTKQqzUrlayzukj1UPui4Nw8mX6fmJbOdfb1e5jmxA+M4bkNMxRuo6gtfwdlByTT13MpAuFVsdIEMUQ1IU40LTgE6QEiw+7MIZc0jI6tjuM90GYlIwUy00HSKrEAw4kTXNWmrza6cpKqSexIEX2q06gAz5nrsc5LHewOeF0AHrHufDqxNwiB46I8ue6z1d1UkNevPN3SEsHLdU1KAcef3bn9Q0jgLdWhKdIwhGCHF/WZw6YUNF2geyAtvEpd8xfEGQGCEOKD0V1WSMnhtelx+n4SU1+HHiD7C26v2kv1+W02gqQPBI6kvHrPhRQEI1+oEeLn5a6vDn3lOGAgYEHkYFgTkdL7fYYzIEZjBi95rW14bHwpt642sRmGv5eYBPxprG44uCvDet/5pgKMzBvZ3nqUw1EpW7EMF+B95vjvSZWpfXA90g0WwDPFDItc3/ldvq6b56ZMFays0JuYPkVtN/ZfxJYhxYJ+6EUyy/PDTM9PoDaR0lHbmVCh/QaENMjsx7YsrMFTBp4pXCqoWQjVSsYkxsVrlDwq3m+jm0vk92AH8BGDwhU8l756ndZ6ZKgZ0gE7DdIgCdlp/JyjSvf88R8oRBdRkZKUVkW3RCgZhvBC3XO1KhEAQnaeR897viCpgKIQYeksJC6C/H+eWAQ7mrV9DNcDZ52MZkV6+lzZI/Zho3f0aFzP7Xj75qQPUQcD5yHvqOLPRZrQK2gfl3DTLcQu3ckebpVZdwWE22aHA/oePxXEd8oQQfuseUTvv+0WDJEyKzvI91qwkDBuIfV+ENkw7sSQgLq1QbJRCQDYS0uWOqDZNg fz+uMYr2 tEHMSGrluDufZaxrIpRUjZSaW3Pv15HGba/wDZXOBwTMF7SXpBVg7AXCQuMwGpTEqYOssUL7NG8K0ZKElsdGEcuYTewF7w6H3i3YpaAVa5Vjtl8OtJ8M+vLj5cV3frYK8No9waCaeW6c9dGhDETW8Dol/Y/ccPkZOnu4FNJ7yg7KAEhqUzniu9i+akV1dWoYN9ez/mIKuX/k4MmiR+vEoA5ctDAG3KTcAxqBXpv6oNvf2ZYSEEBvwOOLTjYXLMHQVKkZKhBRHgJVL6f6VNGJdQvUqqPK53TAoOX/MnFQ5P0i9DxUbzbReao7LPF2N0yRSPbsD7mm6VFsnIAt8PlyCfF+0mlcLtSbDYei0jXkqXNWEJoMrHkEoqmDAjAb5fn3YqwQioMeu5om6SgR3KOjh+wvY7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/5/25 09:20, Hannes Reinecke wrote: > On 3/4/25 20:44, Vlastimil Babka wrote: >> On 3/4/25 20:39, Hannes Reinecke wrote: > [ .. ] >>> >>> Good news and bad news ... >>> Good news: TLS works again! >>> Bad news: no errors. >> >> Wait, did you add a WARN_ON_ONCE() to the put_page() as I suggested? If yes >> and there was no error, it would have to be leaking the page. Or the path >> uses folio_put() and we'd need to put the warning there. >> > That triggers: ... > Not surprisingly, though, as the original code did a get_page(), so > there had to be a corresponding put_page() somewhere. Is is this one? If there's no more warning afterwards, that should be it. diff --git a/net/core/skmsg.c b/net/core/skmsg.c index 61f3f3d4e528..b37d99cec069 100644 --- a/net/core/skmsg.c +++ b/net/core/skmsg.c @@ -182,9 +182,14 @@ static int sk_msg_free_elem(struct sock *sk, struct sk_msg *msg, u32 i, /* When the skb owns the memory we free it from consume_skb path. */ if (!msg->skb) { + struct folio *folio; + if (charge) sk_mem_uncharge(sk, len); - put_page(sg_page(sge)); + + folio = page_folio(sg_page(sge)); + if (!folio_test_slab(folio)) + folio_put(folio); } memset(sge, 0, sizeof(*sge)); return len;