From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA32C433EF for ; Tue, 21 Jun 2022 02:36:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1660C6B0072; Mon, 20 Jun 2022 22:36:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F0DD6B0073; Mon, 20 Jun 2022 22:36:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF9898E0001; Mon, 20 Jun 2022 22:36:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DE5E46B0072 for ; Mon, 20 Jun 2022 22:36:38 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ACF2F31F9C for ; Tue, 21 Jun 2022 02:36:38 +0000 (UTC) X-FDA: 79600679676.16.506F6FA Received: from p3plwbeout12-06.prod.phx3.secureserver.net (p3plsmtp12-06-2.prod.phx3.secureserver.net [173.201.192.64]) by imf10.hostedemail.com (Postfix) with ESMTP id E10FEC008A for ; Tue, 21 Jun 2022 02:36:36 +0000 (UTC) Received: from mailex.mailcore.me ([94.136.40.143]) by :WBEOUT: with ESMTP id 3Tkoo9AD3AxqO3Tkpon5cA; Mon, 20 Jun 2022 19:36:35 -0700 X-CMAE-Analysis: v=2.4 cv=A6apg4aG c=1 sm=1 tr=0 ts=62b12eb3 a=EhJYbXVJKsomWlz4CTV+qA==:117 a=84ok6UeoqCVsigPHarzEiQ==:17 a=ggZhUymU-5wA:10 a=IkcTkHD0fZMA:10 a=JPEYwPQDsx4A:10 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=JfrnYn6hAAAA:8 a=FXvPX3liAAAA:8 a=NTb5vJx-PtTLRpkcHBgA:9 a=6RyHdP9wf0s6W1bbVaoE2bQoMl4=:19 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=1CNFftbPRP8L7MoqJWF3:22 a=UObqyxdv-6Yh2QiB9mM_:22 X-SECURESERVER-ACCT: phillip@squashfs.org.uk X-SID: 3Tkoo9AD3AxqO Received: from 82-69-79-175.dsl.in-addr.zen.co.uk ([82.69.79.175] helo=[192.168.178.33]) by smtp03.mailcore.me with esmtpa (Exim 4.94.2) (envelope-from ) id 1o3Tko-0002Om-4h; Tue, 21 Jun 2022 03:36:34 +0100 Message-ID: Date: Tue, 21 Jun 2022 03:36:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v7 0/4] Implement readahead for squashfs To: Hsin-Yi Wang , Matthew Wilcox , Marek Szyprowski , Andrew Morton Cc: Xiongwei Song , Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , "linux-mm @ kvack . org" , "squashfs-devel @ lists . sourceforge . net" , linux-kernel@vger.kernel.org References: <20220617083810.337573-1-hsinyi@chromium.org> From: Phillip Lougher In-Reply-To: <20220617083810.337573-1-hsinyi@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailcore-Auth: 439999529 X-Mailcore-Domain: 1394945 X-123-reg-Authenticated: phillip@squashfs.org.uk X-Originating-IP: 82.69.79.175 X-CMAE-Envelope: MS4xfNS7AbJIdt/krKe5xw8vl3lV+uxr6bKTLxedJb+oyvliyKLUN9QrfyJNYIG83YCOqt74Xd9VqU2Z5VH9MMUbB31WjV38f2hra5h6uS1+O6kDscw3PZxU WUIaWTj2Pzbm8EBwWnrQbkSDB5RasxqnrLveVE+BGvBBdMLyW8tzkB6fr0sC5Fm69do8ixonREasHA85VGMWjRZ7uYrlpxdbkmM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of phillip@squashfs.org.uk has no SPF policy when checking 173.201.192.64) smtp.mailfrom=phillip@squashfs.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655778998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CHkRWvTqfGmb/8IY8gMVTWaFNX72OsVVZ1uxr6pqjhk=; b=tbfUAM2S16Wdo7AWlpt0RwtT3NTW3xjQBdskGnn3pJcwJDLnPxeRiEhnT+Yjspl5YHnm3L t3paYcflyY9Awa3U2oKzbmpdUaye4DglIQG+uOoT+HouPovotmr7qp1iaMG6kvXS20Iz2B 8fO48GAWNOwVxkNhBqo3T9EsJHrImr8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655778998; a=rsa-sha256; cv=none; b=ghkl8iL/bX6wKmyG1138fXp/KAKZjDt7Q/4P84ifh6KRkBXkO9ImITxjVuvLknwaKwoeMy X88wMZeIzCdoCSC1mhllWzi/ZNq26FXo2lqicm5qFLK6SCSsrGaRnlLLJVg6fZIXklks8I BQZTKkz0Ne7pos3YG7CBaD1mL2bUkEo= X-Rspamd-Queue-Id: E10FEC008A Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of phillip@squashfs.org.uk has no SPF policy when checking 173.201.192.64) smtp.mailfrom=phillip@squashfs.org.uk X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: s45ojdmuc5ej4a9bj4p4dxjxpn96kiab X-HE-Tag: 1655778996-431302 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17/06/2022 09:38, Hsin-Yi Wang wrote: > Commit 9eec1d897139("squashfs: provide backing_dev_info in order to > disable read-ahead") mitigates the performance drop issue for squashfs > by closing readahead for it. > > This series implements readahead callback for squashfs. The previous > discussions are in [1] and [2]. Patch series looks OK to me. I will be offline at the Glastonbury festival from Tuesday 21 June to Monday 27 June. Thanks Phillip > > [1] > https://lore.kernel.org/all/CAJMQK-g9G6KQmH-V=BRGX0swZji9Wxe_2c7ht-MMAapdFy2pXw@mail.gmail.com/T/ > [2] > https://lore.kernel.org/linux-mm/Yn5Yij9pRPCzDozt@casper.infradead.org/t/#m4af4473b94f98a4996cb11756b633a07e5e059d1 > > v7 adds the patch to support reading fragments in readahead call[3]. No > changes on other patches since v6, which is included in next-20220617. > > [3] > https://patchwork.kernel.org/project/linux-mm/patch/20220617030345.24712-1-phillip@squashfs.org.uk/ > > Hsin-Yi Wang (2): > Revert "squashfs: provide backing_dev_info in order to disable > read-ahead" > squashfs: implement readahead > > Phillip Lougher (2): > squashfs: always build "file direct" version of page actor > squashfs: support reading fragments in readahead call > > fs/squashfs/Makefile | 4 +- > fs/squashfs/file.c | 133 ++++++++++++++++++++++++++++++++++++++- > fs/squashfs/page_actor.h | 46 -------------- > fs/squashfs/super.c | 33 ---------- > 4 files changed, 134 insertions(+), 82 deletions(-) >