From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C20C83030 for ; Thu, 3 Jul 2025 08:39:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6009B6B0144; Thu, 3 Jul 2025 04:39:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AFED6B014B; Thu, 3 Jul 2025 04:39:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 477746B014E; Thu, 3 Jul 2025 04:39:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 34F136B0144 for ; Thu, 3 Jul 2025 04:39:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 11FE21A0756 for ; Thu, 3 Jul 2025 08:39:00 +0000 (UTC) X-FDA: 83622303240.26.A85C85C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 8BFE914000F for ; Thu, 3 Jul 2025 08:38:57 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aFvV1K6F; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751531937; a=rsa-sha256; cv=none; b=aaYgQGc8ajkRycFrzXfL1zPhr5hJ0spjQLLSG9MpCp6/FcDKujtNpageCfVMM4jICbr5cp J2bPJoNICR9MU28TunFN0wijUIxoFBmCVcJCIQmoLOq3vczlGMcNEJXU6oPHIf9UJIhZPD rK9R/mcQsmyMq7fuJ8V3z1giEtWTL4M= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aFvV1K6F; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751531937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gwm34b4PAcYIoCMAqHNNcMIyyJWm1FjC0e6znIfowBQ=; b=WxJGKSmSLevQVSE8k3GHb8C+RPmXGf9NE6eSc2w4prX8mOvs1CdPfmRufAoRvM1QHG3N3O xGx5Aszb7dgWqr4bDgSgHvttzgf+bqlfirqhmhErjFYswdXrris+CZLqc5sceFNTQCBb8W U+zXaxIhFClF22nwRkIdJ/Ly6NPzfJk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751531936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Gwm34b4PAcYIoCMAqHNNcMIyyJWm1FjC0e6znIfowBQ=; b=aFvV1K6FauOVacgWV3B1Lpwop+XqLF/WBN5gf62w0Yr5VvdV4UsgeK3r1NzEwIyJOngwPG BJq8mWLM4wUxDXTFvwon7QX9QY3zVtwaWFtFrWapoUf1eBeyfCABtpkUnq3LCBRwmkUlON btuVVNmcBzuoiTukt/8sI+bqdKQKT2M= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-P-toxeTqMimPAvRmRJ9IIA-1; Thu, 03 Jul 2025 04:38:54 -0400 X-MC-Unique: P-toxeTqMimPAvRmRJ9IIA-1 X-Mimecast-MFC-AGG-ID: P-toxeTqMimPAvRmRJ9IIA_1751531934 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4a7f6e08d92so98285061cf.3 for ; Thu, 03 Jul 2025 01:38:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751531934; x=1752136734; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Gwm34b4PAcYIoCMAqHNNcMIyyJWm1FjC0e6znIfowBQ=; b=VVeasvxcSKqvfUcy/7TY/cl0bj/dwpv/eCrMZHuw+0CGKjHDWVKIJNgfBbK8oDY/pc qmN8Zb+k/X0vcx6LAl3vhZiBe0gNMG4eD7KWV91DLE8sIJEQKHjlt7VrFBkCmaEaWEOE cNd/6q1OujyRSr/zRJHu6F0HKx94XvA7ndtrwTUiI5oWbLGBDxxnLN0FTKVLqlUnL4U4 Roe7Zgj90FpGygy7ziqvt3BWevXGnYKbQbxOXPCBSz4WADY4kdtpqiskzQyfN0Le0ySL Y2Z7PMcFIzyf7zzuNc8VWe1D6oaNVWLBypeI5C1ENSerJkwJPeaISROh31xhWuZgPnWV 0/YA== X-Gm-Message-State: AOJu0YyyHDwM7Cew0OQQWMXCO5bbVEZzx7igEVHZDpyi2MkUIRladc9j Uc6dexkqEIny/YkIrZftYi/l1wYyCsEcy/fRdr5xY9cA3dXaFDYW9rutAaD4ivT1KQv9SzBCaG0 86eQZ54M3CRAfQkXRzJyn2skWylm82ID1RKe1RBponcP4gjFZgw01 X-Gm-Gg: ASbGncs46wymbPVXijnQppoMLbFpW0vTkGjtVFUpSMgF6vJKRjQVXBb0T14e/TkbzqU +5CagqO4j0A4hjV4b4iXKXxEfFwwQRcepXbbaLkUzgpHYizIgrGT7Lw59ukEuYktkAJQoJjCHwQ HvUwsdFphKHiseXJfZ0v0cc9FIQboYp9R2wt8d0Oh3Zk8lJVU6LOipow1vqjOZq1QAjAe8ZV+8X +oMEKWBps7pdjcG/KtY0rAjcunZP/pmISuUlKnjlHHQMWNUwS76+gRHIOtii7Ilc01bsG87lFhf pHaLj4HS4AQD98MJ/ElosRJx6m9N1vwF1NmFrLKWcTFt X-Received: by 2002:a05:620a:28d0:b0:7c7:739d:5cea with SMTP id af79cd13be357-7d5d1cc976bmr335587485a.35.1751531934189; Thu, 03 Jul 2025 01:38:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG66Bc+x/z1lMoRTJBPMfEoClFFZ2A277lXc5gjdCv9n4Sr9TbMvl9YfSBPbAiwce62LOrADQ== X-Received: by 2002:a05:620a:28d0:b0:7c7:739d:5cea with SMTP id af79cd13be357-7d5d1cc976bmr335583885a.35.1751531933764; Thu, 03 Jul 2025 01:38:53 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d443229ccfsm1072780185a.88.2025.07.03.01.38.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 01:38:53 -0700 (PDT) Message-ID: Date: Thu, 3 Jul 2025 10:38:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] selftests/mm: Skip hugepage-mremap test if userfaultfd unavailable To: Aboorva Devarajan , akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com References: <20250703060656.54345-1-aboorvad@linux.ibm.com> <20250703060656.54345-8-aboorvad@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250703060656.54345-8-aboorvad@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bzGls917MbnsjsPbpTOxXDkRBU3feYxQHiNTvj5FMOo_1751531934 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8BFE914000F X-Stat-Signature: opkppmaxiucajsbpsdqbdk3axane4wkg X-Rspam-User: X-HE-Tag: 1751531937-115033 X-HE-Meta: U2FsdGVkX19DQtu4KsZ7qVKIg7stbrwRCP9LIm2X61Db5gWhsjTTkxVch4tXShS/mUqz2RmZurhWooC2+heFGgPgZIdGw2jylFlVJNNWxyDSWi3QK2VkdgrzCsyeCgX4IlEQGoZbFCKq2XbR0xfQfF3U7nIc1oioIji9/ZTSKUi2+9CnYH1I2Mfy8kaO1OAx1yck/5nP8PrtSY180R2NVZCuFsH/sZeDzHr3qf32y4ZklzEnisHIjkUlW9xGkeU59dEWIgfdeGCCnBN6dGkRQRrjh8FXFtGA2g3Hy1QKUnDCBc8sz4o9MNVoV7FvipwpCk8iW04FzoQuxN+2QLrto707pp81N9IDxlGoSRhtJ4m+xeJU8GdfH/hO1YazRC26un+1FY1onWBo37YDWlnLr+YvUA1Ioa7s/IsFtgB9V95thtCdncljjX1I90p4BASIlu4dKzu5LLUZtvC2A5nKWserwjC4LXiQre/FM6u0QxsGuEUkYWXqvA3AG3GUcU5zysHrlnRIbG5tSzg90zfYzJdb7t/BJELuEj+UJHxPlM/FvxJs3EtlHPU78wVHCuAdRN6bJ+S7iFa1TA2SZbkmP7LSFuaxhHWaRqrsEvMX03z0tKTUpkJ1gIyXfUDoRjtnC1owU1NR3blPM0bF8IYRU4O7lU1Mz/0K+lBmrTw1mOxYhILnQUR3ROlViE/bkz6E5+Z3r2TDrvJq6hHQZNAtSVMECnGetlmwxgPtNNuPFbYh9q1YuOcOg19jAUGmUVBFv+L1adlJx9iQkuXxvM6J+u2CXDqpLap9tcAv2Z7UT3uKxO1lL2sNAVtMfmjMooeKAlWPd3nIVByf0yp6d6w/eAdLzntBp7RQ+xdDIz8iwBXHYgNlD+EtfAu+Act9ITJZIHwSg9NnneIVDH4hK1pBl6m4GAqwWCU7ZHfzDmxzpojg5mGJmTMZ7lkpISlYxLW2xdd7m41E3F2NpXbqXd8 dqBU/nYh Nf3DU+wb7lD414eH0NvNspwDvdLRsE4f5a0mfPNLBd+W9g/AnSCAoVSwa28dSDedYJpiICNp69klJEIoFp4/uRyea+IAH2JHk3rOxhCJw922RFz5SYON7d+rdS0fGzM38NGnSEZASWIBK/nuIXwknMSo52sT4w29Ti7PcRNsOPfi+0ZLXsyt3PPELPAFnM8bQRBiOd/L72URlWN6LFv/eKNYt+P5dT3dODXCLKThOiMPV8DpFyKGJ+MTmRSzn9Z9y7Bv82c4et/MGmoF98N7CRrTPp2DQXZBNQaSXIKgFmbxv8BEgq2Rr5NY6p7EwChRfr1Dqudn1bH8YDpPD2fSsqUsL5UehRXnJJ+EOK6LyJukEnBbma0kQ223Qhl1FTaqQ1q6koMi/tSvhPYBA1fNddp+fRx2p0F/IZwMu98zpzo5dppWoqlhGxiQhfTrH1QiU/rlU0KsNwiwDi2MbrHWQ7RiMdW1W2awfdq5NHxxpg+zEPtNR0+2GMsW8paQ6TA74rbZJ8aJTuz1UgrQW19kLeX3aVxBPHyKEBKxb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.07.25 08:06, Aboorva Devarajan wrote: > Gracefully skip test if userfaultfd is not supported (ENOSYS) or not > permitted (EPERM), instead of failing. This avoids misleading failures > with clear skip messages. > -------------- > Before Patch > -------------- > ~ running ./hugepage-mremap > ... > ~ Bail out! userfaultfd: Function not implemented > ~ Planned tests != run tests (1 != 0) > ~ Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0 > ~ [FAIL] > not ok 4 hugepage-mremap # exit=1 > > -------------- > After Patch > -------------- > ~ running ./hugepage-mremap > ... > ~ ok 2 # SKIP userfaultfd is not supported/not enabled. > ~ 1 skipped test(s) detected. > ~ Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0 > ~ [SKIP] > ok 4 hugepage-mremap # SKIP > > Signed-off-by: Aboorva Devarajan > --- > tools/testing/selftests/mm/hugepage-mremap.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mm/hugepage-mremap.c b/tools/testing/selftests/mm/hugepage-mremap.c > index c463d1c09c9b..1a0e6dd87578 100644 > --- a/tools/testing/selftests/mm/hugepage-mremap.c > +++ b/tools/testing/selftests/mm/hugepage-mremap.c > @@ -65,10 +65,20 @@ static void register_region_with_uffd(char *addr, size_t len) > struct uffdio_api uffdio_api; > > /* Create and enable userfaultfd object. */ > - > uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK); > - if (uffd == -1) > - ksft_exit_fail_msg("userfaultfd: %s\n", strerror(errno)); > + if (uffd == -1) { > + switch (errno) { > + case EPERM: > + ksft_exit_skip("No userfaultfd permissions, try running as root.\n"); "Insufficient permissions, try ..." ? > + break; > + case ENOSYS: > + ksft_exit_skip("userfaultfd is not supported/not enabled.\n"); > + break; Note that we have in tools/testing/selftests/mm/config CONFIG_USERFAULTFD=y But I don't have anything about making the test more versatile. Acked-by: David Hildenbrand -- Cheers, David / dhildenb