From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76BACC6FD20 for ; Fri, 24 Mar 2023 08:54:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BB396B0075; Fri, 24 Mar 2023 04:54:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06BA56B0078; Fri, 24 Mar 2023 04:54:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4DFC6B007B; Fri, 24 Mar 2023 04:54:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D570A6B0075 for ; Fri, 24 Mar 2023 04:54:52 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A32D91408CD for ; Fri, 24 Mar 2023 08:54:52 +0000 (UTC) X-FDA: 80603181624.13.F9B8FA6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf03.hostedemail.com (Postfix) with ESMTP id 678BC20003 for ; Fri, 24 Mar 2023 08:54:50 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zITtHtc9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3DYCY3JP; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679648090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NS9d7ZaLCL3KAZXneGHf8Dn544Z5QXJS4scN7Mds7nw=; b=1wwqzvx0X0K4od3lZrVISoVJIin03490aTtLXvcK/GXwiWxIjqW8Hw8hH7WVSSap5RiY5h OK9ltnnNy6uDnssnDS9xjV/AxE8ggSAACKIT5GvJHehh1003i8XMCCvzg+DYe0yxHqWezq AL2HZkKLx+yZugQXmKYrXE5gbFVPxFo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zITtHtc9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3DYCY3JP; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679648090; a=rsa-sha256; cv=none; b=Py8xVcUbJC3J2IgUTB/6Rv29RdKStMAXPJa9VHuNNEHm8wxhQ3KdCMFVL/fxAnVZSraMOs 2U0ZV3YFgy96C9FvQmG5cCHggH+rZvB4PTHaj+9CklSwouig+MCVS60Gv5tjOxhuL2J+Ke 2KI/tCV844G+yVxCEndA/oXQWsy5rGI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D21D933777; Fri, 24 Mar 2023 08:54:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679648088; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NS9d7ZaLCL3KAZXneGHf8Dn544Z5QXJS4scN7Mds7nw=; b=zITtHtc902VVsVw7+zKr5bkxsv6Mbx1+fbpm2ia5zTF3EWIm2QMai2vAIfAe0doNtU/crP T4sFLJuba0H6TQ3fzAdSP47lDfthRbDB3jBwo3m0IQp+jh4qaGUTXbU6gX3dhCFVp2t3v8 Sw1x9MwzQ/ARwVXmI/EwXcFa4XoasH0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679648088; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NS9d7ZaLCL3KAZXneGHf8Dn544Z5QXJS4scN7Mds7nw=; b=3DYCY3JP15PbKY5gZ4FAa9lC1CjGdXRUVpIXWH0RgpGHW3/IZRgwg0RpSKBDovX8Kj9oF6 cb8Dk7t0WzpREZAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9432E133E5; Fri, 24 Mar 2023 08:54:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id R/EgI1hlHWRkDQAAMHmgww (envelope-from ); Fri, 24 Mar 2023 08:54:48 +0000 Message-ID: Date: Fri, 24 Mar 2023 09:54:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v8 11/11] tracing/user_events: Limit global user_event count To: "Masami Hiramatsu (Google)" , Beau Belgrave Cc: rostedt@goodmis.org, mathieu.desnoyers@efficios.com, dcook@linux.microsoft.com, alanau@linux.microsoft.com, brauner@kernel.org, akpm@linux-foundation.org, ebiederm@xmission.com, keescook@chromium.org, tglx@linutronix.de, linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230221211143.574-1-beaub@linux.microsoft.com> <20230221211143.574-12-beaub@linux.microsoft.com> <20230324081824.b917c2944da217e5239e1223@kernel.org> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20230324081824.b917c2944da217e5239e1223@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 678BC20003 X-Stat-Signature: nguqr7p7w9tc4qiw99gus67e9jjiroh3 X-HE-Tag: 1679648090-152041 X-HE-Meta: U2FsdGVkX18D4xUpI8YuH+IapbPDHwu13A+BqM2VzlssGDaN28WLHg6hPktOwa2DmFojxuWGbC6K/xvceF04BioVsohF++Rplj0xLCUERWw8AKRJBQvJyj7D4+1KCZfYfCTjYxKOdR+1omZIpTClNMf5ogRT8Wo7uKXyIN8d+dQ+sgYytK3UVM9fJpCLniOIyeuxwSinBDxBlOsUVIOt7NsDez+S2xQPxHESjAeeAxsiXX6LaEJSyJSoMFIxgCH0fDEWoR6EB2E9sWhaoRM0/dou76hz9jzlGRi/1+oph0InT8XooO7ZJg1p8kyXHTFEnFq+3Hu7VOlvM9SKZb77S8yX2pWC2/O2EfyHICx5C9yVDlsDcsWPetBpwklKzt9EiP4JlS/p9abKD6G4mxQCzQwc4144+Sp9oDr+XDmIuMmwm2IUTMgw2Oxz5DPA8aTKoONT3rdHWTFIqUJuHgDwJIsnDHBxHHKM/sKmYOphPDRjyUY28WC7vHa0RgtKEvQ95QhCgGgmliekaPgN7M/o7UbKe3pwTEN3T5qKMWg75m+Dw1VpbWKTOnHYaWE5wVVLZVdxGPYhNzHTmpuLQuGtfeeMKy82U/gTh4vPhdkBqIyMgNsxZ6zkxRJM5I4etflIg5DdIrZt5R7LjdTvf+xlQQ+783O3PjcTDcmvsEr0cpoxubEZbHE+MvAKMFxBV1unxGK5opL4uG1mL6r8VGbE+SvglX+tCgsJ0G8LH6Ps7kxEEFTXmXc5jnYT6Fd1loJMvLrp1kQGGlEids6m+aGLPoKZdol0s9z9Ot2ZGzdXg9km2ur2bTQpiRlBmDNJWDrTUAfDt1CDGSlhiFKVQcTMS0smAYoeRMU4LOEiV9+ZoKm6xSIV20phVEmcEhWpVZEOUT4n6XTjZeStHekr4QZAeju8fl+97SgHLIg4Ez2Ka5LL2jzFcWyP69hJQft0y9zThIZV3LmTO7Waza4+jId UhhzqKfb +RUVPR4OfR9WnsfeJRKjjg8Lmd/U8N9ywwKGtRdxApG9fHyw/q5VHoWjiRD94gaoypsHXxFg1RlPTZCiFlHrYBfrm6xfj7xO5xi4Gy05AM3y6emhOkymR4KUPQurej2+JUASpqxkoPx8UVM/ycEg6XZiARNF+XOezkMYMOy+6QapkNMbb3AhSDdQh7+VDHS38EsklCt+GU1kTt1yZ1wwDHlKHYyvoRuBdzDkxbVL5WR6WlfHmwLsGcR+I7Wb8MGUUTNEaHX1V0Lm17SDI/HLoLhtATP8t+fN3PvpCL8jnagV9VGwiCSxzWR+8dee5zLUWiBY12x+TYZ1aBnZUFz6zKCI30w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/24/23 01:18, Masami Hiramatsu (Google) wrote: > Hi Beau, > > On Tue, 21 Feb 2023 13:11:43 -0800 > Beau Belgrave wrote: > >> Operators want to be able to ensure enough tracepoints exist on the >> system for kernel components as well as for user components. Since there >> are only up to 64K events, by default allow up to half to be used by >> user events. >> >> Add a boot parameter (user_events_max=%d) and a kernel sysctl parameter >> (kernel.user_events_max) to set a global limit that is honored among all >> groups on the system. This ensures hard limits can be setup to prevent >> user processes from consuming all event IDs on the system. > > sysctl is good to me, but would we really need the kernel parameter? > The user_events starts using when user-space is up, so I think setting > the limit with sysctl is enough. > > BTW, Vlastimil tried to add 'sysctl.*' kernel parameter support(*). If we > need a kernel cmdline support, I think this is more generic way. But it > seems the discussion has been stopped. It was actually merged in 5.8. So sysctl should be sufficient with that. But maybe it's weird to start adding sysctls, when the rest of tracing tunables is AFAIK under /sys/kernel/tracing/ ? > (*) https://patchwork.kernel.org/project/linux-mm/patch/20200427180433.7029-2-vbabka@suse.cz/ > > Thank you, > >> >> Signed-off-by: Beau Belgrave >> --- >> kernel/trace/trace_events_user.c | 59 ++++++++++++++++++++++++++++++++ >> 1 file changed, 59 insertions(+) >> >> diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c >> index 222f2eb59c7c..6a5ebe243999 100644 >> --- a/kernel/trace/trace_events_user.c >> +++ b/kernel/trace/trace_events_user.c >> @@ -20,6 +20,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include "trace.h" >> #include "trace_dynevent.h" >> @@ -61,6 +62,12 @@ struct user_event_group { >> /* Group for init_user_ns mapping, top-most group */ >> static struct user_event_group *init_group; >> >> +/* Max allowed events for the whole system */ >> +static unsigned int max_user_events = 32768; >> + >> +/* Current number of events on the whole system */ >> +static unsigned int current_user_events; >> + >> /* >> * Stores per-event properties, as users register events >> * within a file a user_event might be created if it does not >> @@ -1241,6 +1248,8 @@ static int destroy_user_event(struct user_event *user) >> { >> int ret = 0; >> >> + lockdep_assert_held(&event_mutex); >> + >> /* Must destroy fields before call removal */ >> user_event_destroy_fields(user); >> >> @@ -1257,6 +1266,11 @@ static int destroy_user_event(struct user_event *user) >> kfree(EVENT_NAME(user)); >> kfree(user); >> >> + if (current_user_events > 0) >> + current_user_events--; >> + else >> + pr_alert("BUG: Bad current_user_events\n"); >> + >> return ret; >> } >> >> @@ -1744,6 +1758,11 @@ static int user_event_parse(struct user_event_group *group, char *name, >> >> mutex_lock(&event_mutex); >> >> + if (current_user_events >= max_user_events) { >> + ret = -EMFILE; >> + goto put_user_lock; >> + } >> + >> ret = user_event_trace_register(user); >> >> if (ret) >> @@ -1755,6 +1774,7 @@ static int user_event_parse(struct user_event_group *group, char *name, >> dyn_event_init(&user->devent, &user_event_dops); >> dyn_event_add(&user->devent, &user->call); >> hash_add(group->register_table, &user->node, key); >> + current_user_events++; >> >> mutex_unlock(&event_mutex); >> >> @@ -2386,6 +2406,43 @@ static int create_user_tracefs(void) >> return -ENODEV; >> } >> >> +static int __init set_max_user_events(char *str) >> +{ >> + if (!str) >> + return 0; >> + >> + if (kstrtouint(str, 0, &max_user_events)) >> + return 0; >> + >> + return 1; >> +} >> +__setup("user_events_max=", set_max_user_events); >> + >> +static int set_max_user_events_sysctl(struct ctl_table *table, int write, >> + void *buffer, size_t *lenp, loff_t *ppos) >> +{ >> + int ret; >> + >> + mutex_lock(&event_mutex); >> + >> + ret = proc_douintvec(table, write, buffer, lenp, ppos); >> + >> + mutex_unlock(&event_mutex); >> + >> + return ret; >> +} >> + >> +static struct ctl_table user_event_sysctls[] = { >> + { >> + .procname = "user_events_max", >> + .data = &max_user_events, >> + .maxlen = sizeof(unsigned int), >> + .mode = 0644, >> + .proc_handler = set_max_user_events_sysctl, >> + }, >> + {} >> +}; >> + >> static int __init trace_events_user_init(void) >> { >> int ret; >> @@ -2415,6 +2472,8 @@ static int __init trace_events_user_init(void) >> if (dyn_event_register(&user_event_dops)) >> pr_warn("user_events could not register with dyn_events\n"); >> >> + register_sysctl_init("kernel", user_event_sysctls); >> + >> return 0; >> } >> >> -- >> 2.25.1 >> > >