From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72F3C3ABB0 for ; Fri, 2 May 2025 21:36:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 661D16B0085; Fri, 2 May 2025 17:36:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 611486B0088; Fri, 2 May 2025 17:36:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D8AF6B0089; Fri, 2 May 2025 17:36:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2DF3E6B0085 for ; Fri, 2 May 2025 17:36:35 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1E5FCC01CF for ; Fri, 2 May 2025 21:36:36 +0000 (UTC) X-FDA: 83399277192.19.AE6487F Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf22.hostedemail.com (Postfix) with ESMTP id DE94DC0006 for ; Fri, 2 May 2025 21:36:32 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dgMRPlK6; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746221794; a=rsa-sha256; cv=none; b=DTu95OW67m+ayhe+bS0QEtM9B1Y33G3Snrv/zYyVOzYgzqXcZN0PIzamQNElicsVqdVXJr Ajw9On805zakqmVqXAnnBfmSLfsNnW7zEsO+Ylkt/b5NvHKltK2M+IqIR3RQK1QJqNQUkM c2cajUFHmxPfCVdVUbw0kwbLVdnkLFU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746221794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f+O3P77Dqp9BgDVNcymDQyVbwMHsKZYmEmFhWL+CGe0=; b=RDrOVskSJX3+owznuuF7jp4KCGuhyoq/YBurBxvYwAckfxzQHRsiGvcYQa3+Ur29S+gkib I/cwqf62hdt87fIiI9ePQsQQXfJVEJ6LQDcZs6aeXT+/uMlfp/pbhZce2FWgrAdZFJp8hg 9pPrFb3/eW9oCYczK6st+IuYFxcXU30= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dgMRPlK6; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=dave.hansen@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746221793; x=1777757793; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=yGXalRNqfxRtXQ2JtLbUw9sW9Gy9K1M0ILzwPvTQPqE=; b=dgMRPlK6cDPLxRu4oCtu5zQNo4pz67yo11kXC22SAqKZ51KXg8lcoz20 Lu5ZEpvzFyAJe6DYD9kQxkTt9Zhaigpuru6dRmzmFeTZLofTOzKpZKsTW QY6H+JAiL5mjQlW0kyztCGRyxT4Uq3JacVTiMcrBNbQRNCgCi7Dx664Gc YNeAuaN57ClSLnXJKGqkS2XJetSuSRLun6yJPIi/MeMiDRNpLjG/A8y3R QEZl/MVr2SyOeVStJWmRTUyH4CUvH4RQdSSzHEOpilnX/1cSKA2/VJ0RV VN+Pt7qammEeGAZp6YMvF2EWGipNR6+8oyY/zlwHQXHX/DY1z2R+Weae7 A==; X-CSE-ConnectionGUID: 19PIqsEYSAOijbXjwvym2g== X-CSE-MsgGUID: Qw+fqsk3STmsKqZlh9DYpg== X-IronPort-AV: E=McAfee;i="6700,10204,11421"; a="47628492" X-IronPort-AV: E=Sophos;i="6.15,257,1739865600"; d="scan'208";a="47628492" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2025 14:36:30 -0700 X-CSE-ConnectionGUID: 0tv1uZKCRtiDDNTIFxekOA== X-CSE-MsgGUID: k8wn7LtvTyWv46JNpypiLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,257,1739865600"; d="scan'208";a="171986956" Received: from bjrankin-mobl3.amr.corp.intel.com (HELO [10.124.220.153]) ([10.124.220.153]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2025 14:36:28 -0700 Message-ID: Date: Fri, 2 May 2025 14:36:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 14/18] x86/boot: make sure KASLR does not step over KHO preserved memory To: Mike Rapoport Cc: Changyuan Lyu , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, corbet@lwn.net, dave.hansen@linux.intel.com, devicetree@vger.kernel.org, dwmw2@infradead.org, ebiederm@xmission.com, graf@amazon.com, hpa@zytor.com, jgowans@amazon.com, kexec@lists.infradead.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mark.rutland@arm.com, mingo@redhat.com, pasha.tatashin@soleen.com, pbonzini@redhat.com, peterz@infradead.org, ptyadav@amazon.de, robh@kernel.org, rostedt@goodmis.org, saravanak@google.com, skinsburskii@linux.microsoft.com, tglx@linutronix.de, thomas.lendacky@amd.com, will@kernel.org, x86@kernel.org References: <20250501225425.635167-1-changyuanl@google.com> <20250501225425.635167-15-changyuanl@google.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DE94DC0006 X-Stat-Signature: jh3kp1d7xdn6xjwwux1u7repsjet85zo X-Rspam-User: X-HE-Tag: 1746221792-742039 X-HE-Meta: U2FsdGVkX18m9NXo9FaySsmCBWoEdQl/NbJpfHDjirSYOWBbeuOL57ohQtN4WWUIvKvjCzUzQSMd6/mKB1DIQCVms1vaYoRQ5HkxebG6R0vIwM68g/s76X0pEboOVP7blzGWaLWvDQSeNV2TzIXCWb+ogdrLgeNI9kak8V4Vq4njw1dzabW2JepHJtHo98nvwQlDpvjUy1IvSslxD6bfu5NRRW+uCW6iYBh5kFBKhSf/yhVRDkX7MAkaxBb7ouNuBFiKMB7vnm3vrwpc6u/gMou/SGtYB08CcOl0u5dp5buwhj4oKOwFJOwaOEVIGPOT8L5IKQgUD4+5yfrxW0Wu+z3wNbW0XXyvwi4amXm4WKx+v129NkCObYAj0zQHXFyq04Cj/kL3DSUFXWgyOSfuNUEo35YZAb8xuQPOIph0ygCagQZ+trdBCBzxR/frzszzu0Qe3ZdCeiOKmzDJZsutCxFWkhTcU69ybtXsxq/l+jFTXqAp9pgkxrvCyMwCa/NwiWA6wOCRL1YhzYV3duFs/vtVvyD72qq9dmocblC0XLGwbXfuNqHXYJMoQfnZ0NItShpprxE6P6UXlIUC/huJPDXo1PocFFzAvNHWRyYy9K1NF+WwVOua5LgUa+OAaqnDIsmrLrGmcK5MPQ6yNYVjYRkZIEfKkCerwuL6ZHnkJT/vwmkTOIJHkkIkbFwCTS+6fl+iGkNPkzlW4orio29bAmXUXEPf3HqomUFr5Xw3+LSvhDCIW02MixhQhe93mt/DAVYrGPRjEq9QKMx7J2dany8qpILcRvyCkbXTUSrfvRCdmlgmFFSF9np1lPKxfmNjNvb+/c9NIiX4Ft1jOdBVFXLj46aWsin4c0A2QrPBJo5a2p36LPWVejk/zsdZMAj9tqx+C2VGOLiUqotzvJE0YjjHcUXImzFKjm7VCfnpx7Dx7QKDHGkeHDlFu2r5Yljlz3i6hedg2gCCEBMAoqS Xg1bLvb2 dJ25Zeu1CtHiQ8XPLEH8/QVQ/+/zEZqw7Ay/Mr3QdyunrYifjC/w74Y5B8VbyKOIXrJzZzMpnCyUw04lSXlyj/jNwSW4q/i6iNfuCcMJu6ksKuofJKMX5UJhKZb57d9aEqmMhHahtC1wKhPmcI5OOr2yPbv5phJBecVhX/VFxPbXSBdebBU0RJILz7VxiAYEBJtVhAocoqsiLoMA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/2/25 14:16, Mike Rapoport wrote: >>> +/* >>> + * If KHO is active, only process its scratch areas to ensure we are not >>> + * stepping onto preserved memory. >>> + */ >>> +#ifdef CONFIG_KEXEC_HANDOVER >>> +static bool process_kho_entries(unsigned long minimum, unsigned long image_size) >>> +{ >> I thought we agreed to rework this to unconditionally define the >> kho_scratch structures so the #ifdef can go away? > It's either #ifdef or double casting and my understanding was that your > preference was to get rid of the double casting. Looking back at the other message... Sorry, you did make it clear there and it just didn't penetrate my thick skull. The double cast is goofy, but it does seem to be the normal way of doing things. There are lots of examples of it. So, grudgingly, I prefer the double cast over the #ifdef. BTW, _please_ changelog this stuff. It would have saved this round of back-and-forth. The changelog is the perfect place to say something like: This looks goofy out of context, but it is unfortunately the way that this is handled across the tree. There are at least a dozen instances of casting like this. This series is generally a bit sparse in the changelog and comment departments.