From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ED05C3DA41 for ; Thu, 11 Jul 2024 08:11:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 801206B007B; Thu, 11 Jul 2024 04:11:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B1436B008C; Thu, 11 Jul 2024 04:11:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6515A6B0092; Thu, 11 Jul 2024 04:11:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 493DE6B007B for ; Thu, 11 Jul 2024 04:11:44 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 94678160436 for ; Thu, 11 Jul 2024 08:11:43 +0000 (UTC) X-FDA: 82326752886.03.CE839FD Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf19.hostedemail.com (Postfix) with ESMTP id 216511A000A for ; Thu, 11 Jul 2024 08:11:39 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wST6reP+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wD+j4QVQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wST6reP+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wD+j4QVQ; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720685476; a=rsa-sha256; cv=none; b=qrKH9CMJYA2mTV4eX8rddr4wltgOd+UjAkqzYjV+EoVMW4bsYrqhWuVE2MOp8aZftL7OWi P7XRDNcyBqI+FBHIz6EG8AWvk4i5Eg8jUFLVKKh6IEVcmOZ0KdQfimJO+STgAAGLXLgcpo Oem2QXtF3g5XWC2Cxvd4DF+7KWdZuXI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wST6reP+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wD+j4QVQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wST6reP+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wD+j4QVQ; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720685476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+9bFZhaPYxI9MVcY1EYwod8mYg8QgnvxONqpF1N/E/o=; b=CHo4k1LhbZOlOC+UuutRzYI9SvxAPUjcWXPwmx0RZWp9/tnsZu6Q6IUoIdI8mEahxvYbZ+ J2GOeS0MZ964qPktYoan0AE1qeDkRpgjxNXk0LSmY7Hcv1o5GHcb59s7fb4Q/AF6hv6VVH wAJb0AO0WjVpmZLjDeq1B2G372DjXic= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 88D922192D; Thu, 11 Jul 2024 08:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720685498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+9bFZhaPYxI9MVcY1EYwod8mYg8QgnvxONqpF1N/E/o=; b=wST6reP+Zs5NZJrS6nhyR6W/VvQqHAtvSAMOvI8aQjJ+K32n4N4/QVoRZ3ACkkfnhdN0rh gvxvNPCcJBe4+XvWyMHPrvnTVrus8Rjq8s0G9rvStOKTE+O593XOSVjeLZY17Aj/v3W8eh 1JOkvJN8E1K2oN4vhkrqWPp7+wDBRcg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720685498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+9bFZhaPYxI9MVcY1EYwod8mYg8QgnvxONqpF1N/E/o=; b=wD+j4QVQKvRix/y+AJJbTotp52gL5UwKVXOlkasK2M8cYCHOttL/R4vo50TjhBV3veIX2B q93+jVPg8J3f+CAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720685498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+9bFZhaPYxI9MVcY1EYwod8mYg8QgnvxONqpF1N/E/o=; b=wST6reP+Zs5NZJrS6nhyR6W/VvQqHAtvSAMOvI8aQjJ+K32n4N4/QVoRZ3ACkkfnhdN0rh gvxvNPCcJBe4+XvWyMHPrvnTVrus8Rjq8s0G9rvStOKTE+O593XOSVjeLZY17Aj/v3W8eh 1JOkvJN8E1K2oN4vhkrqWPp7+wDBRcg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720685498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+9bFZhaPYxI9MVcY1EYwod8mYg8QgnvxONqpF1N/E/o=; b=wD+j4QVQKvRix/y+AJJbTotp52gL5UwKVXOlkasK2M8cYCHOttL/R4vo50TjhBV3veIX2B q93+jVPg8J3f+CAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 63E9C136AF; Thu, 11 Jul 2024 08:11:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eszMF7qTj2YSHgAAD6G6ig (envelope-from ); Thu, 11 Jul 2024 08:11:38 +0000 Message-ID: Date: Thu, 11 Jul 2024 10:11:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [REF PATCH v3 2/2] mm/slab: decouple the SLAB_OBJ_EXT from MEMCG Content-Language: en-US To: alexs@kernel.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Randy Dunlap , Yoann Congal , Masahiro Yamada , Petr Mladek , Suren Baghdasaryan References: <20240710054336.190410-1-alexs@kernel.org> <20240710054336.190410-2-alexs@kernel.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240710054336.190410-2-alexs@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 216511A000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: bxkt9ciqeupu6jnbuyuraczd1zj4jg9h X-HE-Tag: 1720685499-310929 X-HE-Meta: U2FsdGVkX18qobvlEffQYrom1f5sebP9Q6w00c6dd9bycrdXCk62vnBYMEjvXAsec3ZQX9QVrqN5NIiIickSj6MpF6RwP6BAOVA3ZMAW7oHiAbfjMU8yyG9RKAq3Rbscyq4r5JBkXZ30X8lL108FSE6wO2xlClIr2wUmNxxbljctEgF7o7dmtzZS4qJRCPVBdpzlPW6aXJEwMvM5eX/V6QJHLggM0/lhHBiHMN48z4s21WG5Yb72rm9evcQ+ZtHGCuFJ41weib5xE5kr+VwsRRqdS4Pdt3pf3699FonA1aXOOZJJuWLMeI31bKLqDQbhFvT/DZHOOqnbPcOLGst1Gsyl7WLUT+h0uCTPIUT2KyJmV8otVdEcenVC8NxWCwBzCLY3+f+L/scgqrexyzIxhYNKb4/srk5xFigTcTU401ZphqGMSjGMGjemTFqFW0efotDfFwzOGXBDkOQeJOwsk6EZWFw+1nLDmoPNodPqowZkZQ+3QLule08xUpcFymOMQPxpiVL8FusBrbyUXQVWaRlLknqyuwGRL3coDq8afhXIY4igX2hVu7Zylnx9WQQjcbZIazZKyXUioMF7lkkFj0+tFZe4iKQKXTdfCLINFLJF1O1bbuPvkmhGfycKo8bqdXfQw3k/WgrC1c5AonEIF95IrhV33WXnAEFWwvfpybpQMHSMv4PSfsYsSd2lWrUrG99IZRhQ1SQ+F1J67hCjy/KS/eLGLJRxGtcq04quwiZX7ra6YrBMYruUWwIZoHxagT2MAxTGgwOGhWrsxDVln7+lrqL9/Se4LHM8CFG9dfMbDaJ31h4FY3FXMC/8pmccnIu3c8jV6iAT3X+F0v7H1bt8k5xGHt92rAVzAs/d/KHA5jo2iDo14xWdmvETiUvYaLmNFCX8v4qc7YfnWWXTKrrTkhIUHETr4JpCq5cNSNnpRssWqwd531qyjQWiHTChJV6ju2NXJzN8vmgXacB 5bQCSp/I oyYVboU+V2zgMBk2Tc24tMtGm7t4mEmJ2WkYLLhfBmEOkkWHaKftwOV9TLFmr88xU146HLA1uSTKDJxsCg5VVNNRE/upYiMupxst4qOedfprTW3tH2s3be8yh4ut4lLlvfmWW8k6hvmorahTZZKzPR4JVdwIVHc6XOLCP1vyRGHT+jh2YxutA4NMVIF7ar7cC5zuv9M3n3Ab2bXrbFREsbah7cktAfWnD3hr+tWZ4nXJtCZKy51R0Z3HV/Bbcatxjygq6NXetkTm9bjyiL9OYOmJG1+4X/+XTveGtthvMFxxSvCNaetCer5UBfbC9L1PCs093FUD7XMCArQOCi1/EUJfvtHtItW5BqWRuV3hPoVrAtrUSde+23Y8qYFqJyAwOMfaCnD/mnm0YeSDxLEnZH4Y0XOgtVwEwlvp8glldCMPGwLJKjpj+PBcocWikNwueQHGu33jAYqecPFPb2zbtgOS7cx4s9butin1q04vmKoCEFlt3NQZDgYwVvdOaEnVJdXYP04dvAl5vyABl4rwKgbuCtb5kO7/i2Wy7lAOs3FU25DWgb0tuF5o3mg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/10/24 7:43 AM, alexs@kernel.org wrote: > From: "Alex Shi (Tencent)" > > commit 21c690a349ba ("mm: introduce slabobj_ext to support slab object > extensions") selected SLAB_OBJ_EXT on MEMCG just for SLAB_MATCH > memcg_data, that included SLAB_OBJ_EXT for MEMCG. In fact, I didn't see > the necessary to enable SLAB_OBJ_EXT for MEMCG. > > Let's decouple the SLAB_OBJ_EXT from MEMCG and move out > alloc_slab_obj_exts() definition from SLAB_OBJ_EXT only. To alignment > the alloc_slab_obj_exts() return 0 for good. change its return value to > '-1' for always failed with !SLAB_OBJ_EXT. Now we could save unnecessary > code from MEMCG but !SLAB_OBJ_EXT. > > Signed-off-by: Alex Shi (Tencent) This seems just wrong to me. The memcg hooks for slab do use obj_ext. You made alloc_slab_obj_exts() return -1 and that will just fail all memcg charging (unless alloc profiling selects obj_ext). The kernel will appear to work, but memcg charging for slab won't happen at all. So no, it can't be decoupled for slab, only for pages/folios (patch 1). > Cc: Randy Dunlap > Cc: Yoann Congal > Cc: Masahiro Yamada > Cc: Petr Mladek > --- > init/Kconfig | 1 - > mm/slab.h | 6 +++--- > mm/slub.c | 6 +++--- > 3 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/init/Kconfig b/init/Kconfig > index 26bf8bb0a7ce..61e43ac9fe75 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -965,7 +965,6 @@ config MEMCG > bool "Memory controller" > select PAGE_COUNTER > select EVENTFD > - select SLAB_OBJ_EXT > help > Provides control over the memory footprint of tasks in a cgroup. > > diff --git a/mm/slab.h b/mm/slab.h > index 8ffdd4f315f8..6c727ecc1068 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -559,9 +559,6 @@ static inline struct slabobj_ext *slab_obj_exts(struct slab *slab) > return (struct slabobj_ext *)(obj_exts & ~OBJEXTS_FLAGS_MASK); > } > > -int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > - gfp_t gfp, bool new_slab); > - > #else /* CONFIG_SLAB_OBJ_EXT */ > > static inline struct slabobj_ext *slab_obj_exts(struct slab *slab) > @@ -571,6 +568,9 @@ static inline struct slabobj_ext *slab_obj_exts(struct slab *slab) > > #endif /* CONFIG_SLAB_OBJ_EXT */ > > +int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > + gfp_t gfp, bool new_slab); > + > static inline enum node_stat_item cache_vmstat_idx(struct kmem_cache *s) > { > return (s->flags & SLAB_RECLAIM_ACCOUNT) ? > diff --git a/mm/slub.c b/mm/slub.c > index cc11f3869cc6..f531c2d67238 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2075,10 +2075,10 @@ alloc_tagging_slab_free_hook(struct kmem_cache *s, struct slab *slab, void **p, > > #else /* CONFIG_SLAB_OBJ_EXT */ > > -static int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > - gfp_t gfp, bool new_slab) > +int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > + gfp_t gfp, bool new_slab) > { > - return 0; > + return -1; > } > > static inline void free_slab_obj_exts(struct slab *slab)