From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18028C2BD05 for ; Mon, 24 Jun 2024 10:30:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E84A6B03E1; Mon, 24 Jun 2024 06:30:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9982C6B03E2; Mon, 24 Jun 2024 06:30:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 838B56B03E3; Mon, 24 Jun 2024 06:30:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 638D96B03E1 for ; Mon, 24 Jun 2024 06:30:25 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 12F921A0E42 for ; Mon, 24 Jun 2024 10:30:25 +0000 (UTC) X-FDA: 82265412810.02.61347FF Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id CE31DA0027 for ; Mon, 24 Jun 2024 10:30:22 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IYladxw2; spf=pass (imf15.hostedemail.com: domain of hawk@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=hawk@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719225015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J9L6cb4/TIbxsw07Hh6WP0UQHPru+KMvi+CtJ1tsXik=; b=D0iFdsO5KK8EymboBk9UdjrcLOlGsZh13RtRkJUuBiVDQSawU1Xy/vDXxD/TrcbSTfcz79 IVgHOAPD/Lgo7t/TzHXT//77Av+ybtrHAG46hKpuDMR5FkTixYPoqP9DdvKvo8cTKjzP53 x0EPVetHXbrwybI5DN/X0OFyORFG0DE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IYladxw2; spf=pass (imf15.hostedemail.com: domain of hawk@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=hawk@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719225015; a=rsa-sha256; cv=none; b=Z8CwabDtzA2rLniDaKIe28MSxBcwMSugWwSxq/5JywHzUFbVpp1LBpOBJmXWYoNAgcs+vB HEY5VPQ5oITKDVxVS5OVAjR3fTqG0Ib6fg13BxwhSQP29BcdUJUB6Q5L5FBprR7n/5ZOCi 2mEicMvLQbhmgfpxH1RZt069qMZk5o4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1DA60CE1093; Mon, 24 Jun 2024 10:30:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A148C2BBFC; Mon, 24 Jun 2024 10:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719225018; bh=BhXMYPQ/+WmfR8YCkca+YfLTakDZXtfzOYcByJxFw4A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IYladxw2/FPfs/DZrCRC8LUMt6ManHKUelxki/tXBBGUV3GQq0tk7VSP4htkq2r3d bkUH02KJn1wbHlBYgzhWOi1rIlr+4qWLl9ErjXulKY884qkfRFne1kU67d+lyqe/ES UyB+PGtZ8Zu3+YL4BDRZLUHP4zt7v+f1eSixxgxtAekyCh21oEvcHNjBfDUiCyRTZM y/7t3Sj0Wy8qOyf/0D4OghtHoAX153ZvN+UlNP/T+qg8ARlCKFPUdKM2415o2vgE5C SbVWp5tNjNtMr4eKtm8MD0P85wL9Od7f0/kUxUMin2N52/x21ETRchYPyRkEfcoSw7 3KS1cG/ZuxnKQ== Message-ID: Date: Mon, 24 Jun 2024 12:30:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] cgroup/rstat: Avoid thundering herd problem by kswapd across NUMA nodes To: Waiman Long , tj@kernel.org, cgroups@vger.kernel.org, yosryahmed@google.com, shakeel.butt@linux.dev Cc: hannes@cmpxchg.org, lizefan.x@bytedance.com, kernel-team@cloudflare.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <171898037079.1222367.13467317484793748519.stgit@firesoul> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CE31DA0027 X-Stat-Signature: 99d5mf3ckx8xd817wose6noqjb8c1mwq X-Rspam-User: X-HE-Tag: 1719225022-234868 X-HE-Meta: U2FsdGVkX1+etK9E2la3JYuSIj5VTHG6G4jab4pYFprrGWQzWvtAgwy47g/vfH62kCXFrFIVRIUwBW0c2CiBlvMLstdRQTJ1cLkz4KxBw3KK6U0BB0NbDgWECqO079V9ZFk0O8QIdSy+y4GEPCsFIghiTmoubbdLKY9vg3kwVAPOHGyQYhztuhsftghxKpmJ24QASZTesmWI8Zgq4PZQq0srgSArfgD93PiDSxFPG6Ngz1Eos/pSN1C/uWNZF+iMhf1A9axr9TmoU5fbbEO8h/UZPu/tCfrWayDa8T6OAuJpMSIcujdAKE/H++40RVz3aZoGsJvKhg61Y3vhmio6R/clfngQ/YwP8Ph/7j6190PggaODTIhdUrVGOVjFsPu1vQkLkXyVXWxNueqomIuV9liUfPHyHFZ262gtYPt1cOVhT4RY/43pDZpAWfhzEPply18qEej1vdvBLPF1Xutqeg2YOCUypHIAoyJv7rgucTm5rzD6ndFFY/jYcmd7X2dJc+wb84QBL1guUOkqkTnymL1KYmjn0NV/QJZv7NjMD398wx6CBFtMdEvQcoRHW2b7KuAattNQa3TRI+JiaaMKpfXpRgg0VqqpayiKHJ255SrxAndP6HD/ySL+T5qARaeG/Jy2jA2gm0oTEE75aZE/Y1FCBN879VJYtF2XX0Y3VsTIUipeIQWJFt7nV0tGKq3qq7Oii38HtgEuX/vHbKoHxZtAgCaE3D4VJASd5rVnAbkGrY1R7keWwTapb+FjW7ozKJHBFrJ+yr2DEbtmEZwQRaIIQ1Y1+joJkovfZXcqY15eehl3rkvYI4VqoClp645It/7Y9c4gASQCckuBLlJGk/8WThiIpCs371LtXQhLPeuRn10mcBFDUqIlswBbBiJ83eHSVuMSa/IBfzXQfv9g6Si3Evhl12+foqT3+5s+OvS8Kdqs6fdtHyuUad5jLqeGwGw+VJ9oh+KAbNaf0qM L4ypxsYB lQZOrH46NrQezBoUN65v6vj8z+mqhpIh9CkBG+s0iCqEifTl3CHSgC5n4dHpFxJRy5X1To2j5zJ9zpGVHBa3Tux5QqXbAQlkCREPHMAblDaLaSEOhXHd/L/yVQnwGYSH0uhXmU11Bb+FLym2w5zx8QeDXJ6r/SN/RLLibrFDmRhpVlx3yp0PbDxCc4S/wYs6afALiI3IolkaPLSIoamLZq3zgNYdAKP9eVaLATkZNErdotCq5c2h2fmr5fI/9rdP2b7gw274EEjk5iy5ntFt0gEg1gg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000356, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21/06/2024 17.13, Waiman Long wrote: > On 6/21/24 10:47, Jesper Dangaard Brouer wrote: >> >> Hold off applying this patch, as test kernel didn't boot with this patch >> applied on top of TJ's cgroup tree (on commit ec9eeb89e60d86).  I don't >> know if this is related to this patch or not. > > Commit ec9eeb89e60d86 is just a snapshot of the Linus' tree. You should > use for-next/for-6.11 tag as a base. Patch works fine when applied on branch for-6.11. (This snapshot of the Linus' tree seems to be at fault). I would still like feedback on, if this code (for detecting "root" cgrp) is correct? : static inline bool cgroup_is_root(struct cgroup *cgrp) { return cgroup_parent(cgrp) == NULL; } Next step for me is to backport and deploy this on a subset of production servers. --Jesper