From: Jesper Dangaard Brouer <hawk@kernel.org>
To: Waiman Long <longman@redhat.com>,
tj@kernel.org, cgroups@vger.kernel.org, yosryahmed@google.com,
shakeel.butt@linux.dev
Cc: hannes@cmpxchg.org, lizefan.x@bytedance.com,
kernel-team@cloudflare.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] cgroup/rstat: Avoid thundering herd problem by kswapd across NUMA nodes
Date: Mon, 24 Jun 2024 12:30:14 +0200 [thread overview]
Message-ID: <d6bbb201-55a0-4630-a01f-fedae8d2eb96@kernel.org> (raw)
In-Reply-To: <f75c9256-1969-4b34-bc93-106581157042@redhat.com>
On 21/06/2024 17.13, Waiman Long wrote:
> On 6/21/24 10:47, Jesper Dangaard Brouer wrote:
>>
>> Hold off applying this patch, as test kernel didn't boot with this patch
>> applied on top of TJ's cgroup tree (on commit ec9eeb89e60d86). I don't
>> know if this is related to this patch or not.
>
> Commit ec9eeb89e60d86 is just a snapshot of the Linus' tree. You should
> use for-next/for-6.11 tag as a base.
Patch works fine when applied on branch for-6.11.
(This snapshot of the Linus' tree seems to be at fault).
I would still like feedback on, if this code (for detecting "root" cgrp)
is correct? :
static inline bool cgroup_is_root(struct cgroup *cgrp)
{
return cgroup_parent(cgrp) == NULL;
}
Next step for me is to backport and deploy this on a subset of
production servers.
--Jesper
next prev parent reply other threads:[~2024-06-24 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 14:32 Jesper Dangaard Brouer
2024-06-21 14:47 ` Jesper Dangaard Brouer
2024-06-21 15:13 ` Waiman Long
2024-06-24 10:30 ` Jesper Dangaard Brouer [this message]
2024-06-21 16:08 ` Waiman Long
2024-06-24 10:49 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6bbb201-55a0-4630-a01f-fedae8d2eb96@kernel.org \
--to=hawk@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox