From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7089CC46CD2 for ; Wed, 3 Jan 2024 02:36:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFE888D002F; Tue, 2 Jan 2024 21:36:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE33E8D0006; Tue, 2 Jan 2024 21:36:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A10058D002F; Tue, 2 Jan 2024 21:36:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8B6F58D0006 for ; Tue, 2 Jan 2024 21:36:19 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5D78680970 for ; Wed, 3 Jan 2024 02:36:19 +0000 (UTC) X-FDA: 81636435678.19.146EF0A Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf29.hostedemail.com (Postfix) with ESMTP id 9FA34120002 for ; Wed, 3 Jan 2024 02:36:17 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cIOoIXlG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of rientjes@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704249377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v52EQ/A6TAXr6Z6qExZ1s4TncM4K58Y7qBR/ZAdYtZw=; b=JLv8gO5PJLJ4XGzXEdGc9y+8V8VYHXsznmYhzJQ+VwLogCqUj310Gc9gl9znEZuzbOIupq 1fuS+8G6YpnxDtef2SFaAD45iK/8xbUHciNgBfDJpnJJ22y0AmQX1+ciAZIl/DIg7q0icE F+X0GlJKUk7ZLda6bSkSK/8avFkEm/c= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cIOoIXlG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of rientjes@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704249377; a=rsa-sha256; cv=none; b=OFOQPOmHK/0gM/TNKWizpyBT5uaD6sVOtJPJZJnDMRF+QkeW6I1M+dbAR65CLh7NQpBcAf gtxjoH2WlhWCFwU1JqJQDel5Z+YdbgJlfwdZ5xvF67B1uRWHFMjO3XZjnBL+uA6NTIZz0z Vz5lkl0x4HC5MICtYpBupVQKmJtyPjA= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d47fae33e0so76525ad.0 for ; Tue, 02 Jan 2024 18:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1704249376; x=1704854176; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=v52EQ/A6TAXr6Z6qExZ1s4TncM4K58Y7qBR/ZAdYtZw=; b=cIOoIXlGcYi2GdLOHsv2urmj3FTDsJUKIN78Uj8v9KKboP7WcuvU9EBEIZBcUXTZHn 7/1sFHtYjkqFVxH23HDkAmVb6pz3Fuog0xUqdPmoD1dzlpUo6+0f2M6dU+g+tmdV/+Ij DAMqWL6gn4IKtETEc2bcgmLyhWNIH/hvF0YNhwZw/tGWwdD/RfhzTiNtUu2lYcTW9wmt uFRotFBPb8Q2r8WqzSe7jzDQYri1dEaoZug1F4QMKvxW9BpC4emDasdbFM/eoVTLbX65 xCuS4qtqudjUQrjrUR/DE7CzDxxLax9dKFdC1OlHicmwT5vRp1CsvZOVtZczxu3tsPyp zj6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704249376; x=1704854176; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v52EQ/A6TAXr6Z6qExZ1s4TncM4K58Y7qBR/ZAdYtZw=; b=xOMgy2CMNx7RhsL1jgS8L9TBjsK0tlKyRubtV/F54vqZ80jsOqNfcz05Ua2fOwlqR0 dQNG8Zbg8ZSxcFDsNtAauinq2VKamt9uzTzpJMa5XK5++fgg+SByqi7ccxL05QWnJHFv datyPjqTLlJO/Ua0Hox7qg7BKWdZ3LrtpUoj9DkgvfJg9fvbtdLNcTx2Ul3JFZWiyXaa 3oALCq2UAChkC1hkZFwneF0bv7M3SQ3OHQ4DEtVTx74gnbW/do/CJbjRAmuYTyPN7JjM QJsYymY/oDrFO2fA7NmioIRzWevuIhyzHgdTEyKqfl0kckYnYpkINPmFBU+ky+Vg0O7U N51Q== X-Gm-Message-State: AOJu0Yxhv2GAhgr+FRM/OIQoHGkQRvTyFH0IIP2GOygOufcVo5turolJ WRLIcv95CraJlP9aG942Ut1wfEZsMnmL X-Google-Smtp-Source: AGHT+IHRLCBiISoazm9mVZrqDO51ftpMM1MRJLgMJGTk721tHqv+vKNga7SoDo23wTY/QHS60Zi41g== X-Received: by 2002:a17:902:ec85:b0:1d3:b085:5e4b with SMTP id x5-20020a170902ec8500b001d3b0855e4bmr84957plg.16.1704249376239; Tue, 02 Jan 2024 18:36:16 -0800 (PST) Received: from [2620:0:1008:15:c73b:7876:89ec:9102] ([2620:0:1008:15:c73b:7876:89ec:9102]) by smtp.gmail.com with ESMTPSA id si13-20020a17090b528d00b0028cbfdbd804sm336031pjb.45.2024.01.02.18.36.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 18:36:15 -0800 (PST) Date: Tue, 2 Jan 2024 18:36:15 -0800 (PST) From: David Rientjes To: Gang Li cc: David Hildenbrand , Mike Kravetz , Muchun Song , Andrew Morton , Tim Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com Subject: Re: [PATCH v3 4/7] hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc In-Reply-To: <958bf051-e776-4cbf-ae3c-76ee82d55bcc@linux.dev> Message-ID: References: <20240102131249.76622-1-gang.li@linux.dev> <20240102131249.76622-5-gang.li@linux.dev> <19b08bb8-1fbd-557b-2684-5c29c5c783e6@google.com> <958bf051-e776-4cbf-ae3c-76ee82d55bcc@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 9FA34120002 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ce11mfsnafc5j5c3fe4ynudqjw37ubij X-HE-Tag: 1704249377-581333 X-HE-Meta: U2FsdGVkX18p/S3/tUANEccbbQKswUTFjV9eMY9afMvYjamE3Aq3QgrnsEpBqSekjCWKbmcfH2JOx+YmIZn7aAqzuKIxeJ+sd3md5UCM1OAGU0jO6/dGK/QD2OtvuGbKQ8uGeDX96H1ebZKNDpuJrIrJY6+T4vZ6NwCCeHpbTMhQAtiDO3XdbhcK91AhE2E5HMt5VrsLHAsWJL+avuqx0RRuBXUDtaRn4WT5RlJ8n4b+LKi4MYxgnJE28vVAestvs/fKkJK127FdASKylIOV3tYL8xalBfCLeUWakou7wg1AS9UHtW1dNQGqQFlOXYshHqjmgpgtNoeDKS8oLn9H0noAXiTbNt7hOgE9Y3+jDVzYFWPoV25LagR8mdyVjJMKb9V7ms+dgW0acMjUjG00VyVDReaITdda2uAvB155Gc4/d5XhRjwXwLno9/bkbF0wZowez3PB23+dWSiL5CWMPlFrCi5sGpoL2WcD60K1ytoD1mt3f4lMVEqWseTFbrVi+rRGcspE6aphh++G2G3LVRjhOPiOsg3cjQ4Q+YG3k9CZT579rdITlb01KCJsrVd0MmyzRnBv0CEqAEEPXnFj/HMTzFPZNV84JiygIuNl/rHniuf/9LDt/aZQr6V+GHRtNUT0FI4qHIlJLUE5u0HvJzyyXetrphevzMETdvYAVEbFYuqYsV+2OuJSZz1Kg8ImPIlyfN6xu+fBm7VepKiQ1A8RekMkKnZr+KbWk0xjk9zSU5eG0ZehmWpdReKfTB0Zk7qU/fGix5p/Jtkln0ap31VWtOQKcvG8oRRG195CMR8QuDTdT8/b/FfRYDLtb1Y7cUWOClt9dV69uQ10yg1TWm9BCShgMX3OwxcobctcIfcOBqyMeJCCdlesZj2GNhMlEZehb/Ka5Ejl+N42fWJNouelUPX0IFtlsJOB7pdbLHl8tabnFTlgodG0nOPGPpxmBE7S38i9Ap+FaLQCrtZ uEt4KcR0 0thuPb2CduOn31PxyVNK0JIQVlwWbyQL3XuscISxIw3HxbTsLkjsjsSiP8NFSdYf7OFvNfPTHVhC2lKBsW0Ynzsl4WVnPwjYPpVqPbjXxNqpj3EdAr9ULiqtqsGySRIL4vYhLiOK4LQF0eTvOqYsc87S9A7XSOq2/L1/veDR/zpvW+BaVxXbiiE18WIX/cWuO2HFD+PJDbSqG96mIA24lcwXmEldMKDp3mKpHtRQt0O3cIbIWu8OnoKtmbl/gDOOjTwc9/00uiKLHzWSNva0fh7dI73uNnxwssFxkHkzl3SGx991ge2TdYq3U/oThWnZ9ni8OKB1EevQRz6iGnjOLlVYI7V5w/WHU20cO/Imk72pKcjG4zyYnBj6k259Ch5gu2pNH5qfp+Yc3SL+CaMTNtAQIhm4HRj/fJo+cpvvg9n8COoXk4t5dMUkUDeW6s8lbt14pqti9nVCmpZM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010110, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 3 Jan 2024, Gang Li wrote: > On 2024/1/3 09:32, David Rientjes wrote: > > Same error as v2: > > > > mm/hugetlb.c:3315:53: warning: variable 'node' is used uninitialized > > whenever '&&' condition is false [-Wsometimes-uninitialized] > > for_each_node_mask_to_alloc(&h->next_nid_to_alloc, nr_nodes, node, > > &node_states[N_MEMORY]) { > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > mm/hugetlb.c:1501:3: note: expanded from macro 'for_each_node_mask_to_alloc' > > nr_nodes > 0 && \ > > ^~~~~~~~~~~~ > > mm/hugetlb.c:3342:38: note: uninitialized use occurs here > > list_add(&m->list, &huge_boot_pages[node]); > > ^~~~ > > mm/hugetlb.c:3315:53: note: remove the '&&' if its condition is always true > > for_each_node_mask_to_alloc(&h->next_nid_to_alloc, nr_nodes, node, > > &node_states[N_MEMORY]) { > > ^ > > mm/hugetlb.c:3310:7: warning: variable 'node' is used uninitialized whenever > > 'if' condition is false [-Wsometimes-uninitialized] > > if (!m) > > ^~ > > mm/hugetlb.c:3342:38: note: uninitialized use occurs here > > list_add(&m->list, &huge_boot_pages[node]); > > ^~~~ > > mm/hugetlb.c:3310:3: note: remove the 'if' if its condition is always true > > if (!m) > > ^~~~~~~ > > mm/hugetlb.c:3304:20: note: initialize the variable 'node' to silence this > > warning > > int nr_nodes, node; > > ^ > > = 0 > > 2 warnings generated. > > > > How did you get those warnings? I got nothing in my compilation. > I'm using clang. You spotted the issue in your earlier reply about the potentially uninitialized use of "node" when adding to the list.