From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03707CD4F4D for ; Thu, 5 Sep 2024 06:54:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 559106B017E; Thu, 5 Sep 2024 02:54:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 508746B0182; Thu, 5 Sep 2024 02:54:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3815F6B0183; Thu, 5 Sep 2024 02:54:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 193166B017E for ; Thu, 5 Sep 2024 02:54:07 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8304B121931 for ; Thu, 5 Sep 2024 06:54:06 +0000 (UTC) X-FDA: 82529770092.30.9FF921D Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by imf01.hostedemail.com (Postfix) with ESMTP id 9377D40008 for ; Thu, 5 Sep 2024 06:54:04 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=leemhuis.info header.s=he214686 header.b=rRXuYDz0; dmarc=none; spf=pass (imf01.hostedemail.com: domain of regressions@leemhuis.info designates 80.237.130.52 as permitted sender) smtp.mailfrom=regressions@leemhuis.info ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725519137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J3h/pEXhWnamMRH/2xCgvLm05jD815BjkrZDVdDIF/Q=; b=KtOXp9WuenSd1l+sBnHkD/6IqxJFrslho6dhDejGmUTLAma4XoVNGxkqJ78XFweqr4NX43 oz2Jl5LnEYLGfCv/0GfU6qBXOKr/ZjTa6xBiJxhWkMTn3TL8jnbrSCPZ508uD7Sp2i8v4r ywUNVEPeklt4lssNMcCR3JSs3xf9Ivg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725519137; a=rsa-sha256; cv=none; b=hdxsVvkeIs+KYdxWuvpc/gkBhySyHxcd/diO3NANDj+mUkpSg7Mi6MNhxxqLeF6pGtgZ1d s2j4AuCtdL8wLXhr9/WGUDTyBShdEBJFs/e/b7ES7R54gmtf49NOSHY7dsQ/xGQqinZP8u klytHeHIHn0ObdSkf4VviXcesGBJE/0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=leemhuis.info header.s=he214686 header.b=rRXuYDz0; dmarc=none; spf=pass (imf01.hostedemail.com: domain of regressions@leemhuis.info designates 80.237.130.52 as permitted sender) smtp.mailfrom=regressions@leemhuis.info DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=leemhuis.info; s=he214686; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:In-Reply-To: References; bh=J3h/pEXhWnamMRH/2xCgvLm05jD815BjkrZDVdDIF/Q=; t=1725519244; x=1725951244; b=rRXuYDz0QrHDJVYlhK1JB+dDLtcrh3gWP7GFNy5V2eXxfckDYslr3gVNbH/y6 yzDCptyGCjGjQKcMBsREqMnWqmZokzfn66dfkE7GTuhTvNQtVwiCcE/EP+DbtmIGagMEACyhpFV9m Yn1+sLxTmKopG5BxJ1i7yzffP74RWwvv+bxKXCnVQAR1NWqIcEBV6Qy/Kgf3x16d2bUtjco0lMEGn i4FGGZdHPzPD1X8hm066s5V4t+sFRiuP+Sd7yq2ELs8mw1FfZP5vGyRSuQBNIgyL/fgkRJcufvsN4 /xHqQetGya3SESDmb53nB8grQQAQXDrGAcTZlNvMl1f+3e6CqA==; Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1sm6NQ-000111-FH; Thu, 05 Sep 2024 08:53:56 +0200 Message-ID: Date: Thu, 5 Sep 2024 08:53:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: vmscan.c: fix OOM on swap stress test To: Yu Zhao , Chris Li Cc: Andrew Morton , yangge , David Hildenbrand , Hugh Dickins , baolin.wang@linux.alibaba.com, Kairui Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Linux kernel regressions list References: <20240904-lru-flag-v1-1-36638d6a524c@kernel.org> From: Thorsten Leemhuis Content-Language: en-US, de-DE In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1725519244;f405935f; X-HE-SMSGID: 1sm6NQ-000111-FH X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9377D40008 X-Stat-Signature: u7e3ow9mef8tafwa3xyyzfayt7xr6yze X-Rspam-User: X-HE-Tag: 1725519244-644447 X-HE-Meta: U2FsdGVkX190HVndbmPJYMJAX9F3PJrgJwT9QLpyz2QkaGjx7cegDOIGIegxusi0SpoTYB/MDuiP5eWpu/4nqDavlcofF0uSDCD73n7y2wYbegdKSescAmer6Rxqwos5KfoCctMttIYXKXPBqgy9nOrjI4Gq+F6LDW9T1I2938UaLnTL7llpNGBv8xpr3mNWexSPtuxfzWw+tJopq48pGmq9CuPkFAZhcXIsvpIsEs9AvyhmECY5Iopumb7kP7AisqjJvGhhT0pb+3CGEgsy1bpCLdijeaaJqfmJHmOCNd3DGVhOKcGzFR9DfjtP/lBC/AyEcGBhomyigXkPWwD0MfTBC1C5J02LWH2oJaPKbMBi3NpPqG1lnjax3+7xJz+ISsdFUSGUSyKooHvuxthY/958KeDTeQQqaQXMJ7Y8UiZvmx7OF7657Yt7Str2vOWOsRsv1W65cm1IpKwkh1leQwoEIlQ5ClHNkSMMyMEkOftxeSMGpBy62vHED92mnM5YVGTeX7aOEIsiFzA9nAzBaTowYMC2L5BVlNAMD/AONHLv4amKSbgeV3gHkjKAg05QSsuUVexmVCyyL30HSQ+XYVHhtP7n5U+Shswka/T8lYx8XY3QRjk9+bDP457496tNUAIwv/Wm32NZjOp5l4dMIP5HMqgtXuVH14vMAvdDnmHVFDm6lip5f19QAlrnxxMz3+vhGEVQLDhdpwzXOOVmB1OQf5OvVVLjvtjrR33whQ+Lze+hzWIEeoLWz9uP0haDHkIp+KHGauu4BzHic0cuH7ym+byJSGRpLaPC0zulpITit+FV1j60WTrrObtAe+FEkRWm+OBNDPgrwOkob0cD1UwcR6dJWJIxizIsx4Nzk6HMFjUcazHpqSVGPgViDHdg0usPKyxS0r0P5Bq65lz33zvql9KZh5BBHmZ1GWUn9ya1dbPlVGUacfpLMYB6Xisf8LQHp8m1jrunXxdvjac fof0UFyG Rr3XwkDnnaBj5eLMU4yUTb4rXoHoNpyxJrPkZgUNpreWob4zAWMLgI/ScdnN+8brDpbElHogCu4kw1CyQ2Oz4ZY9M+hVm27raIofPhx+0+vvqSIVM8w8EuVC03oraA86pbQjctqUFkWLGc+tiEptyKSL6vgvaxF5/++2blIeudXv1HI9I4iWxwQl4rnQRslz9sd6LRKvVgyohGPYQx8vGH2Fc2faiRWbiZrkR0EFQZPm+MstBqCjQp/JLZMUS3UvYSlgVNLwBCVJLvVm4w0OOjb7BHMQm+Kf3vCMaVbefd9073MLEgPEqjMg9JdWi4S0DsMQyAjvckqJBk4vkfCt8YQhVARD97pWoGufBcOY43GviLPRBaoEWuPEAknpHCOOunreWR0tPAUJrsmLwkLwxg0s8AODLT97DmabO5RyATAqvH//W3ZL+ymKMaL9B3tlE8/SEcRWpIXDpHkkjz5xWZd9C4/YhHHXoqmUmmNaKpnxjunlnpVOzSdwwmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.09.24 08:42, Yu Zhao wrote: > On Thu, Sep 5, 2024 at 12:21 AM Chris Li wrote: >> >> I found a regression on mm-unstable during my swap stress test, >> using tmpfs to compile linux. The test OOM very soon after >> the make spawns many cc processes. >> >> It bisects down to this change: 33dfe9204f29b415bbc0abb1a50642d1ba94f5e9 >> (mm/gup: clear the LRU flag of a page before adding to LRU batch) >> >> Yu Zhao propose the fix: "I think this is one of the potential side >> effects -- Huge mentioned earlier about isolate_lru_folios():" >> >> I test that with it the swap stress test no longer OOM. >> >> Link: https://lore.kernel.org/r/CAOUHufYi9h0kz5uW3LHHS3ZrVwEq-kKp8S6N-MZUmErNAXoXmw@mail.gmail.com/ >> Fixes: 33dfe9204f29 ("mm/gup: clear the LRU flag of a page before adding to LRU batch") >> Suggested-by: Yu Zhao >> Suggested-by: Hugh Dickins >> Tested-by: Chris Li >> Signed-off-by: Chris Li Thx for taking care of this, Chris! > Closes: https://lore.kernel.org/56651be8-1466-475f-b1c5-4087995cc5ae@leemhuis.info/ FWIW, no big deal, but that ideally should be (in general and for regression tracking) the following instead, as that link above is just at the end of the thread with the report, but not the report itself -- and that is what often needed when someone needs to look up the backstory of this chance sooner or later: Closes: https://lore.kernel.org/all/CAF8kJuNP5iTj2p07QgHSGOJsiUfYpJ2f4R1Q5-3BN9JiD9W_KA@mail.gmail.com/ Ciao, Thorsten