From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE48C021B2 for ; Tue, 25 Feb 2025 16:52:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44D1828000A; Tue, 25 Feb 2025 11:52:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FBE4280001; Tue, 25 Feb 2025 11:52:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29E1428000A; Tue, 25 Feb 2025 11:52:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0C6B6280001 for ; Tue, 25 Feb 2025 11:52:53 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AE91A141A0A for ; Tue, 25 Feb 2025 16:52:52 +0000 (UTC) X-FDA: 83159061384.29.EEAFB5A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 1CD6380008 for ; Tue, 25 Feb 2025 16:52:49 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XDZezrhO; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740502370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ybxboWusnqyTjKvs03gdfQgRYiuSjJraiMkFJv9TEnw=; b=BFjS8lH0hHqTWRJViMdr8DoMRpUhYHjTktPpHxQ9JadPHDrbvwtYrlXBgLJI+LhTnGkdq1 1Sx4ROeGyAq9z1lh3Wm/egO7qIWowJFRROum+/SnSdRMLXmHWiMPcqYfi0MqT75mwmC9R2 Vrly87wkuf6Q9LI2zGsLWWlKuPYNOqI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XDZezrhO; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740502370; a=rsa-sha256; cv=none; b=Zy5QbltIsTFexDowooYiQcA9cbCG3tixmGSgQ6s4GulZ4002extQ9zxn2rKblKEveDJ2c3 0AWxy7lGFEzO0QZeQT3fBHLFuPU0F1FFwZNjkzjYShO1stTnwzlXEKbpQa7FNsvremCtRe v/tcDkMHoGWwnAWy3HJR2GZYVy98WFE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740502369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ybxboWusnqyTjKvs03gdfQgRYiuSjJraiMkFJv9TEnw=; b=XDZezrhOsWknMAzcJtBBOyRhNu5xuRpofBldrODUbIymPpkPf2Jk9BdWb0y0ZB/MvDyIJC trdptuj7VZ5l8/Mj5GAaTJ5Cc9bj0fgsvDedQd/Q8AfQaqEWHJA7XS+BWn5AX2PNd3OCul X0qQ2kseaqA0uMcgCbUtyVsCJGJweqE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-9WLA3DVpOradVgXsP7IDRQ-1; Tue, 25 Feb 2025 11:52:47 -0500 X-MC-Unique: 9WLA3DVpOradVgXsP7IDRQ-1 X-Mimecast-MFC-AGG-ID: 9WLA3DVpOradVgXsP7IDRQ_1740502367 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38f4e3e9c5bso2425926f8f.1 for ; Tue, 25 Feb 2025 08:52:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740502367; x=1741107167; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ybxboWusnqyTjKvs03gdfQgRYiuSjJraiMkFJv9TEnw=; b=I/vNkaFgJK8g5NW3Nmf5T9u1izllfTFOoumLX3spoc90LJ+KMEYZMPQx7fcopurwVs C6uFSHYxaCOr3nXFypUDOQA6c/t/0ZCwJ6D+FQ4W+KGAuXMR/ZPUKTIHrfhbiBTOk6wt 0A5m3YqFiyLxGGHmoQR1apdOFq3tQluDZfrwDPFaQEjVvOdfZT69waWMXw1yZ3xrdI/7 4wsCxs3Azu0DTURs+nndvD/MzIzX7L2RKkPWU5JDIzkwfAYqoifKSTBM450qf+WXchIY KF2vjWJNHfJexxNmYMjbHJgtEPE1WhkX8vGIZGbPFsbnPPGnMIqcjmV6HrIJ63b0nb2E Rp4A== X-Forwarded-Encrypted: i=1; AJvYcCXZn+eJNAxvgfPSJkW3fe4cCyT/GnJVyp78rrV4odJSuaU0ob/9goRFrOmvxp+q/WoGOgY5YUbrvw==@kvack.org X-Gm-Message-State: AOJu0Yz4VFscLNCyMJpyKDwkBKtgJL7YAdSKPw1/0ad7pREBux75DTkU KYhzFbSMn0dIlyyWqZwZlNUeEvHFrkPzxQaVYFtncbYdA6cisOK70l3Xfw2oAGeMsoYLfCGFIL4 p0qjuKSEuR2pdA4u+PxniGtF41oY4X5KeX1qbrYTz5xGJKzOY X-Gm-Gg: ASbGncvngF9uPYM/U9QQaBGF0K1IqDrrjWTBluYUXr0reze6G/iK+E8lBEFC4iirB20 259PwLXy+wn4XJmqCbmJHe+0Sfnx7pmoVukFnUhbnJf0/76YIEJEWgGAtDg4OoT1oXdYx652lRu r98MdQeCAW0rKHuh99OXv31PLSiZv5f6SuTSo4K3UDUG01YS9TlYCLTPOSiYI6QYno7w/uasTLx tpzMMHtrofhDOGi2jtKPLNEuse2DC84VG4JyDiVKZGke1pd2njteyPGLyckmmEsRPCaLzDxpYf4 Rups3y3pKdRCeMjCBmxlS2IgHbcLTYUGINxj+Ryqp10Bro1UiT7PKCrWxbc4yQDPJgjyWbADodW 0UENzQJ2DQ2mKehAYLMteVnT8f3tKIykYk+5z6Z/ULUg= X-Received: by 2002:a05:6000:1a8a:b0:38d:d0ca:fbd5 with SMTP id ffacd0b85a97d-390cc605518mr3098280f8f.22.1740502366821; Tue, 25 Feb 2025 08:52:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHkp5nTxzC3mH+QfPQ2OcYNGz6wgylsGdXkNqE7sPvdo2LKF2uZNL9mmhTxt1LgwuC8gCNgdw== X-Received: by 2002:a05:6000:1a8a:b0:38d:d0ca:fbd5 with SMTP id ffacd0b85a97d-390cc605518mr3098250f8f.22.1740502366450; Tue, 25 Feb 2025 08:52:46 -0800 (PST) Received: from ?IPV6:2003:cb:c73e:aa00:c9db:441d:a65e:6999? (p200300cbc73eaa00c9db441da65e6999.dip0.t-ipconnect.de. [2003:cb:c73e:aa00:c9db:441d:a65e:6999]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390cd866ec7sm2868347f8f.3.2025.02.25.08.52.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2025 08:52:45 -0800 (PST) Message-ID: Date: Tue, 25 Feb 2025 17:52:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/12] mm/secretmem: set AS_NO_DIRECT_MAP instead of special-casing To: Patrick Roy , rppt@kernel.org, seanjc@google.com Cc: pbonzini@redhat.com, corbet@lwn.net, willy@infradead.org, akpm@linux-foundation.org, song@kernel.org, jolsa@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, shuah@kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, tabba@google.com, jgowans@amazon.com, graf@amazon.com, kalyazin@amazon.com, xmarcalx@amazon.com, derekmn@amazon.com, jthoughton@google.com References: <20250221160728.1584559-1-roypat@amazon.co.uk> <20250221160728.1584559-3-roypat@amazon.co.uk> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250221160728.1584559-3-roypat@amazon.co.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DRoDZjYujRnDs6F0deqR58uvgRozcIbpwaw2aBdmqoE_1740502367 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 1CD6380008 X-Stat-Signature: zuyk8z48tewaudjrjbrmnt9sf678gcbk X-Rspamd-Server: rspam03 X-HE-Tag: 1740502369-903332 X-HE-Meta: U2FsdGVkX1+4MV2zIJLydXqr/rCQSug0VE7u7fCJs9XhXhXoRiRIdhtjm0hTfX2twHDijEZ1R2ESTHXRFR9y9EXw1F0uJpSQKti9OU7Zivxt6oynUQLgonJkpwu9tIDY3BPF6/gfFy/UCLvTjyasRwCxJvX8BZH6WikQF6EuMhy4XfyngveeaS2zFSnuu/nphqKd5Gskyr6RnEFnMyehcFW70Ex5Dw05RntzpFsS0JA6LatphXrfd6iSnCFKtU8TNbzN+I9u+HJuIDQrFE3407jJDuGaAYN0cK8vNfW53dDbMKj8EQPZQFYciwj59WBedZOthRyYPdmCRdf+5Fh9999Vm50WY2jNGb3jxnDH0tT8euGDWbt310tib6gqB2RHg4oFgSa5yWiI+p/lV7mYYOAnRkRrZdrj/TSTzL3HeZfL8TyrWnsvFle1tLiCLBwLotllLSUf17UrFV1xIrKsteGiQGjDzdwo6g2dWxMKMKY+2aUvJhu963rMjpQ53FMV+irJamxWc2EtJVOrdB6bdqCMpy5A1eC1PMtrchQtWGjjeV2AZz2eGBcL31WW74D/s4r5Okg6Z9hJmJtZNDHOcC5UJywbzIwTA5LG+n5oX5Pp+q1Q+XkjX5pO780kJOFdunCjqkOEas3zO2ePS/IfxwEH3ut/grgy0xKVOCgBKcCtK5CxIwTcYFJbKO7UNii/9JfpHCXMX09N5BPmnKCBsV7ki4/STSFiPHC83Pq8Rg3n2STVv+k0ZAFocGurd+gGm4FdkCEVBIDb1qh4Xs4Mtv5a7ja4Iy4646I7f7SWValFms/WAu9n5MeEuXyxFgDVLBT6vwpqlPCRl/feTA48oa8PALo5KpQpp3m8Pt+Hyim5igcsWDpZf4noCYvrXMOwvFWRPZLDv+R1UsTk9797OSS0oU1CQCtTMRvvolPmDEc5lSiiNGnAoc+w4oR8aXbkmFCcazwUTZfYTD0k2DL hi4wOBNC Ba6EKaZsLM4+lE+JRUjJSY4PNG0hEgMfYkXSlWz9oD+9ZFjDed6F+vMtM5H3jHyaEeUto8UHXZqeWYAgd4JZPuLHStQDVZqMXPVKeQvjTZ0KPAH8P3CuCfbPsHurp5pNeq25Swq1TZJbV20GPfCh6ySGZybWcp0NYc+/svTDxTq0cd8kAxahD/I+WUceWpNlzr+gP50ncle2ewuR1nvt60jVRiNX/E65kv2G2s90xBC487bfuzuMVM5u4SPpkCCzlfeHrwnANkpXPwZZLt1m7yllHNyy1g42JUzv825bfsSVVQMsK1v6KjprAL2OodqZ8luuY5aty5rv915NrVeatPe9yw0k9Pf2I0hOVi2dWU1JPBBcLFCIF5t0l5S6PseNY0x2lWZFyJnLfE0jotRVECDnxOfB283Iis/twkmfxgowWkMDaM49Tc6guWl3c+08/L+RCdSlsj2ooZG2FIzUHHJbGJUc/4CTubrsuXHKedXi380Q3Qtc8yXOTlvwBCl2Sa9uWptdVl8lW3n/EPR0UnjBdx7WVdv4wxbnEE5d7csWyjtpSACgc7wENFr9uJfPGU0uUYL1umr0Lgym4ez2AP6+ytAnGeNsYba6UZSK3mSnDWDMwsBUO1Rm62/mu5e7VMOKDxluZfjc9VL7cTl5OKsaVe3mJSa1G+faD1n/vayDZ1lfBXj3PIUP01g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000041, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.02.25 17:07, Patrick Roy wrote: > Make secretmem set AS_NO_DIRECT_MAP on its struct address_space, to drop > all the vma_is_secretmem()/secretmem_mapping() checks that are based on > checking explicitly for the secretmem ops structures. > > This drops a optimization in gup_fast_folio_allowed() where > secretmem_mapping() was only called if CONFIG_SECRETMEM=y. secretmem is > enabled by default since commit b758fe6df50d ("mm/secretmem: make it on > by default"), so the secretmem check did not actually end up elided in > most cases anymore anyway. > > Signed-off-by: Patrick Roy > --- Ah, there it is. Can both patches somehow be squashed? -- Cheers, David / dhildenb