From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20862D6EC13 for ; Fri, 29 Nov 2024 14:36:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4A266B0096; Fri, 29 Nov 2024 09:36:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FA8C6B0098; Fri, 29 Nov 2024 09:36:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89A546B0099; Fri, 29 Nov 2024 09:36:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 678116B0096 for ; Fri, 29 Nov 2024 09:36:09 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2F14E1A1202 for ; Fri, 29 Nov 2024 14:36:09 +0000 (UTC) X-FDA: 82839382080.13.967938F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 2DBB9140004 for ; Fri, 29 Nov 2024 14:36:01 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SVnsZJWR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732890959; a=rsa-sha256; cv=none; b=I1B+QVptk3xlRS7f7PkHcxfzkSzEyyk7rETw5VRymumNL96Sf03vsxZHYzqETzBPGp8EaC yaY0AtV9TbUvbzGGUwOWZZ5LG/wfYUDg5NtcYnNwJhx2kRrAyQKLXIFucIG+Ij+VkpH93Y Y81wL4WNZwDF8GCnw9J4wn5s41/keWI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SVnsZJWR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732890959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zi46MvL7lZlyUbjlm9CbWnzBK3iQIK8vJfeuDrtyBmg=; b=jd7zOgXuFHiU+7OZIaS7t1bEksDaB/rP6+RykZbY6+uxPr8a6uO3j6SPRFN5ZNyIvfWF2g Vo9UtdBM8vBtwjpJd55QElnTxooR9Jmx8ZcWUM0EfarkxMpyheABsyrEjyZ8WW3sc4XVpD 05jfAUHbqUyxOgkcusi5n8mAicj8e2c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732890966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zi46MvL7lZlyUbjlm9CbWnzBK3iQIK8vJfeuDrtyBmg=; b=SVnsZJWRtjaADozwKFb11LwtUvDHUfjabOioylJ1AyNMvSs+1COU/OKUS+nhhvepZ2t3WX 3JIELiYW8u+s2x6hkd6hxPzV0VEuXpSR6Ftu2fgOJD0/A/V/12vFhrTi5ypbqGhFbqd5fD yWhD3TuHokAvFSbQ9kn+4F4z5as0S84= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-M7ogHlYyNHWVl4SK5sTGoA-1; Fri, 29 Nov 2024 09:36:05 -0500 X-MC-Unique: M7ogHlYyNHWVl4SK5sTGoA-1 X-Mimecast-MFC-AGG-ID: M7ogHlYyNHWVl4SK5sTGoA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-434a96889baso11209665e9.2 for ; Fri, 29 Nov 2024 06:36:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732890964; x=1733495764; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zi46MvL7lZlyUbjlm9CbWnzBK3iQIK8vJfeuDrtyBmg=; b=rdk7kz4DYNbXsU+7zL3tQE3qanO9LmXE6cVHrvTrAiILCXVOGEx6tWlw0Wv2QCLKHZ Xe16zpBT8Dx8QTOtfPbH4Apjnu+FyjNkIGnSOfy+L/R5JNdrTpZhEUDFFQEqcEl1p2AI O/YGA6maI6QiNETwRm18+UERjqcZjDH5CYkfp1MqFXF6jAKGzg+15nP+mbTQ2H4Jb4o3 alJwcgi1J73aMIhz3nta5KCz1cb+a5ijWcwV27we0nqQ6l9qhn4Y2Vf8WVmUdL40R/B4 MN1zdTYUIGnvVhkfp0brxMA08Llisy2apQcXNe/PcGyPXsr3zDEOIvo+5KUHOj71+lNj gKLA== X-Gm-Message-State: AOJu0YyvVZ9sYu9QcthBoAl5UHIiE1HKCCwduuIcyninTPKyvcdEPnKT X7HEiwQQkFbzc42cXoYEiIgatKXqdZ8Q1/5avWmc0CciH42tMUWoNCHhlxEWtv5QUhxG9eathnK jojb0oL5p3oHwAN2SygRl7JdphvRtdUkylzSo9xQN7n5DB42w X-Gm-Gg: ASbGncs51dw+B6Yze0EonQx8JtdJohaOkc7S8FZMujn3ucwmCHKM3CaI0S/t/jWTqIs vmE80LjRAzoyIs/45e3x/qtpUTdrVmW2kHG7qsFIN60KkxYblOD6imV0IgWvGUxv6zMsvv/BFTo 5NYMM8eodxrkH2NTQo0NtlEw18MYk41tKvh34YxYw+Iq6tKTdCRngQTOWI5u28afkwb0URl3zxN YZ5SSLZl2rZLOI0lZ6MLQaTVvVyvtJcaEgoycZjtBMhbUOidRoAE8jV8jA/EIOvju6r+GqWXmEZ g0vfjzp3bVr2otrv1sdOlhGK+d2CXbOONa6P1zEmx4st9QjtJ2szFHblx9hNqQ3Ebq+iIzurfcJ 9qQ== X-Received: by 2002:a05:600c:458b:b0:434:a78f:3612 with SMTP id 5b1f17b1804b1-434a9dcfef2mr123520545e9.15.1732890963645; Fri, 29 Nov 2024 06:36:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEYtV9EJ+f4+z7kcOfXdSBR0Wn11uWinLOLhVrtNYI6saY+GRbtv+P4pqPy48koMe8tEYLKA== X-Received: by 2002:a05:600c:458b:b0:434:a78f:3612 with SMTP id 5b1f17b1804b1-434a9dcfef2mr123520025e9.15.1732890963273; Fri, 29 Nov 2024 06:36:03 -0800 (PST) Received: from ?IPV6:2003:cb:c71c:a700:bba7:849a:ecf1:5404? (p200300cbc71ca700bba7849aecf15404.dip0.t-ipconnect.de. [2003:cb:c71c:a700:bba7:849a:ecf1:5404]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0f70d91sm54069495e9.39.2024.11.29.06.36.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Nov 2024 06:36:02 -0800 (PST) Message-ID: Date: Fri, 29 Nov 2024 15:36:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 13/15] mm/page_alloc: Add __alloc_frozen_pages() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-14-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241125210149.2976098-14-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DDPhtFkHh14wvHaF52SpweV5VIYGsZb4HejX_3P83rA_1732890964 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2DBB9140004 X-Stat-Signature: zxtzu3rkm456pp6n4jrzpqk4p6fwcpj1 X-Rspam-User: X-HE-Tag: 1732890961-876206 X-HE-Meta: U2FsdGVkX1/ePquGeiqQcrHDJQK5KPfCx1YRPyfn4QHnxP2fc7/BuVr5LwEt0drkUu1yH38pRleNZgRN+McIBGhaGMv4/htDe0pcK8/e2SGkSRG6MK64WeXuwKRsUHuoceDmPDnE+F9IfoSqLF+Gmru+J80a/Yhi/5n2Mbcj3IG4qvbcgrhixokzH56MA7GA+9zc8uwPEk7+A59+xcxgvwuqAcYdmz4xuYzglxqOvC4hc4zwUO+d5nsWSCpGfErTQrFvXlvC/UfpWo1u5e0JBT4qQMg/dQQRzEQ8UPr/An3V2PbrP9M11nvDjggblPlmhIqCsBde0MGKR+uk894/I38bReMmgCEO28C6hbK4uMeIhpl9klNPLpdsavxf/f2df0UUO1uH/faGHv/rQYz6FzZLDXQHW52HkjoqqWWza8XYLi1u0n6f1odiArircLbfRDk6oDMCEHV6xuzvCKOKtM4vno7CKfGAbOp2nZnGUYAA0Rq4urRjks7J8XPe9i8f3mYSEKxzc6S2pAjqcZrGbE6d4tv3NTKlHjZIQmvrmWIsSoRUZGMtZKSTDYFTNFoNHDWKEfSHmYH5MMSCyiREk7arkAMovwfQk3pxGITiX5z64+akMSQ8Rxa2FtVTa7LynbtPQ78ZFule8l2LpZ0KJoWTmxxbZYyeDJaR2dz6hBoxvUcen6CsPFXlSLPrHvskeWNkuPPoKEEGiNVN5YdYeuE/6VgM5ia4G56WtW1gv4cOEJGMix3BaSixzh4Skuizsq/TGs03LCscOz7HjarzBdkLwFQrzddhTaHvUxhdEe/tOPkOPTOJxvy2jO4ra0oy/fxEmzG4yHS9Yg5LMK8KGWBQjO9np5ifqhsoVpffQYCaTQi6y4zsFfKYkHY++vaq1Xag5sSigLFw10KiGSPu41Omw7lt/dkzkf65P3BoCuy5ZtPyOG29BMRLdgcUO7OjbFxWYOwfMqTyfEpGR94 eG8DcVPD TewckiK2wuKNN3KNpZgi6H80jIWL3SXrX7pQNrYmFUKYdleH4ngr5aFdmU2JD5v8XZWgJJMN4Oo9+CQJUafklyLU8yKAGZa3uHD6ice02Srk1V+Ixdjpusm3RqAJ67yvE9dCvjEt0TpEZALwC1iGIqph14AXd4TKqV3OeqF9NqAMxJN2Fz66q4ZRku6fAWeRg66DNpWDp9L7cL37U3hlDSsB0nBhywzSdj/FNhGkKN/7mdPFXAi5QE623yyl8aq5DEo+CQbwKr5B1JZ1DamuHXdXHk02cNbaN8supkYvAj0fxWUd4yQx1DFZVDn30KHqvgyCRxZQuVYrfhUku0Qj3GCAx+TVlJA3nJHe2dV6gIbxzqgIgX9Gl8XnAkdEMTK60d4A/TCILu0AR8GxHuKrFyQ/OrzJh6WiexWEDbYDMVyovEx66O1yl/JAh28lk0jPpQyXtFfQXgxuzTZL1WV3cp96gEqYw8anxE7dtJfSWskQ5ecS+eWXpIM/MezcumainBrH/W5TJ5swV/7bC9UpNb0ycdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.11.24 22:01, Matthew Wilcox (Oracle) wrote: > Defer the initialisation of the page refcount to the new __alloc_pages() > wrapper and turn the old __alloc_pages() into __alloc_frozen_pages(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/internal.h | 4 ++++ > mm/page_alloc.c | 18 ++++++++++++++---- > 2 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 9cc5fdc614cf..55e03f8f41d9 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -740,6 +740,10 @@ extern bool free_pages_prepare(struct page *page, unsigned int order); > > extern int user_min_free_kbytes; > > +struct page *__alloc_frozen_pages_noprof(gfp_t, unsigned int order, int nid, > + nodemask_t *); > +#define __alloc_frozen_pages(...) \ > + alloc_hooks(__alloc_frozen_pages_noprof(__VA_ARGS__)) > void free_frozen_pages(struct page *page, unsigned int order); > void free_unref_folios(struct folio_batch *fbatch); > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 35fb45b8b369..67b1cb757def 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4747,8 +4747,8 @@ EXPORT_SYMBOL_GPL(alloc_pages_bulk_noprof); > /* > * This is the 'heart' of the zoned buddy allocator. > */ > -struct page *__alloc_pages_noprof(gfp_t gfp, unsigned int order, > - int preferred_nid, nodemask_t *nodemask) > +struct page *__alloc_frozen_pages_noprof(gfp_t gfp, unsigned int order, > + int preferred_nid, nodemask_t *nodemask) > { > struct page *page; > unsigned int alloc_flags = ALLOC_WMARK_LOW; > @@ -4804,14 +4804,24 @@ struct page *__alloc_pages_noprof(gfp_t gfp, unsigned int order, > free_frozen_pages(page, order); > page = NULL; > } > - if (page) > - set_page_refcounted(page); > > trace_mm_page_alloc(page, order, alloc_gfp, ac.migratetype); > kmsan_alloc_page(page, order, alloc_gfp); > > return page; > } > +EXPORT_SYMBOL(__alloc_frozen_pages_noprof); > + > +struct page *__alloc_pages_noprof(gfp_t gfp, unsigned int order, > + int preferred_nid, nodemask_t *nodemask) > +{ > + struct page *page; > + > + page = __alloc_frozen_pages_noprof(gfp, order, preferred_nid, nodemask); > + if (page) > + set_page_refcounted(page); > + return page; > +} > EXPORT_SYMBOL(__alloc_pages_noprof); > > struct folio *__folio_alloc_noprof(gfp_t gfp, unsigned int order, int preferred_nid, Acked-by: David Hildenbrand -- Cheers, David / dhildenb