From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA2AC02182 for ; Wed, 22 Jan 2025 15:27:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49C426B0089; Wed, 22 Jan 2025 10:27:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44C256B008A; Wed, 22 Jan 2025 10:27:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 251F46B008C; Wed, 22 Jan 2025 10:27:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F36AC6B0089 for ; Wed, 22 Jan 2025 10:27:46 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AB21B80313 for ; Wed, 22 Jan 2025 15:27:46 +0000 (UTC) X-FDA: 83035467732.22.09A0D2F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 1BC44160014 for ; Wed, 22 Jan 2025 15:27:43 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K1t5M16j; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737559664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T+YDgQGBJgVx1lvy+gZdC/Xrn6pGp2o2cfelN9+I6lc=; b=HeHj9+dbukmcrSTdbsUQCBGhj5gDlFHEopqG++8NrY7BMXkpyAJp21o1v6VM+4ZMbpyGqm RO62j3hcIPRDQqJh9R0D8fAON4WY9ZCJb9o9+emkBwRzLljdPi3aK+5tKeWwG5VXUBlENN wMFTwVZGxSFFKc7QGKKus+uS5sKGzvo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K1t5M16j; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737559664; a=rsa-sha256; cv=none; b=PuQicmryR/N61RYxn3LebhOkhYN9+IjUn8/qXifM9mvyvt4dLgdP9su+oS8VJRqZIKKXOL GfFrI6CD+rz6gdJktQgeQNcBLurVThHMCGsSbn+pwDyQ4+Y04GX7J6GuYQQ9xMRxI12PHr +0Hq2rx1fbodMNPXywr8TDQomRoCfOA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737559663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=T+YDgQGBJgVx1lvy+gZdC/Xrn6pGp2o2cfelN9+I6lc=; b=K1t5M16jwHJ2gwcx3z/i/838BcoOzvmLo01KVsLrvzYJo7qBOEF2vazE1A/CSMNwmwBUpt 2diwKQPTYY26sP+vKMDDoL+L2e2n3v8DQvLkYoFoFo5VRpDg01W9lOAS1k7rqVvEYYRuUL KqnxR2A0lDZWhSmXCbT87gqjslL7u0g= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-2uMmSM_WPbW1oH6B-UvGhA-1; Wed, 22 Jan 2025 10:27:40 -0500 X-MC-Unique: 2uMmSM_WPbW1oH6B-UvGhA-1 X-Mimecast-MFC-AGG-ID: 2uMmSM_WPbW1oH6B-UvGhA Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-5d3d2cccbe4so6879165a12.3 for ; Wed, 22 Jan 2025 07:27:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737559659; x=1738164459; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=T+YDgQGBJgVx1lvy+gZdC/Xrn6pGp2o2cfelN9+I6lc=; b=tuZsFsy6Q/zyGBhYhIVzo/bsyWgQV+A1XJ8/1hZirhzSrbwgx4osZBMqMTn9hCw1Jm NMW605pIFcq/7uOCWmZpMgLXm/ibcLi0buywjgKpjw+uB8jHVO6Gwv9nDLpU+GkJRRPu t7F18p/xfkZ0wdcLoIjm1hSd3hLt93djfS9Gke+AC3jYwofCuYPdhe7pUQojItZSetny gG0MG3vc+k/KxsgYU5P95w88tv44ma07hUdDXv4OgHimIluXJEby/DxpNfi5cV8mzwcK ARUNFztW4jAKWNyZ+2OdBZV9+8pAgWJc1GonOsm+p5dLV8gFa2FZqealXhlorFMOZ4ww mCrQ== X-Forwarded-Encrypted: i=1; AJvYcCXLLwgXnUsBGP2A6bonaspNLrN4oG4asn5NGb+xr+U5sVS7vwUm3YqVWTZG8MH43VBm0zqUkWvcRg==@kvack.org X-Gm-Message-State: AOJu0YxIdmqsjxMbBeWDQJ9DlLbjUoGAswAJjfWQ6IC2J/nTC7ZXw7hb xBom7RjCOt8680S3+XPx6Bv6MqyqMyjvjP/3K7Aj1feeZ+eIsEkEk3mN0RtG2LV9Y6abl9BlTnN 1B2IXSKEPtjqNgf2ZB1a9onlQymt25zK5fwOzrviUd7PLSXsh X-Gm-Gg: ASbGncsXy+pxAWIkj0VoWNUeCYsQilZ/ubi7vPCagX7/YZvk9wEYWYJ7e8K1OB+Zk7Q /MxzckPJHnxG4tXuEFQ4vzN+JPBtNedKd5NHl4WdaQymkW155q4hNjOekrOjlenDHUXh1yg81uK NibMWXI8LIW72O2dTro/ga02m1Fbq1PT3GTJN7yZ9X7KcYBA/1qcq4odFQ3ZZWJqOYc2VdZr7My ofh45EFcO1KJWNfZjbyBEJMbV/ZW28QIZoxotXR6d5f/PRDZSY+l9oQCwrmtmxYslBf8MKZjI70 NR9PuManytzbTlINkXYpjFXm58edt9CObXIM3Jteqk4QdzSMonjmGnfNdVSKAQVfYvMLIafgonl 76ozY+SDWOGTsFzKKs9U9eA== X-Received: by 2002:a05:6402:40c9:b0:5d0:214b:96b0 with SMTP id 4fb4d7f45d1cf-5db7d2e2f66mr19601831a12.1.1737559658890; Wed, 22 Jan 2025 07:27:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtKgLJQ8x85oYipwxoO34t91jw0XiOCoHNVStnorTPyuTG+XMi/NXmDH19FuoIbyrYXa+i4A== X-Received: by 2002:a05:6402:40c9:b0:5d0:214b:96b0 with SMTP id 4fb4d7f45d1cf-5db7d2e2f66mr19601802a12.1.1737559658396; Wed, 22 Jan 2025 07:27:38 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:db00:724d:8b0c:110e:3713? (p200300cbc70bdb00724d8b0c110e3713.dip0.t-ipconnect.de. [2003:cb:c70b:db00:724d:8b0c:110e:3713]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5db73684dd3sm8750534a12.46.2025.01.22.07.27.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2025 07:27:37 -0800 (PST) Message-ID: Date: Wed, 22 Jan 2025 16:27:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] selftests/mm: make file-backed THP split work by setting force option To: Zi Yan , linux-mm@kvack.org, Andrew Morton , Baolin Wang Cc: "Kirill A . Shutemov" , "Matthew Wilcox (Oracle)" , Ryan Roberts , Hugh Dickins , Yang Shi , Miaohe Lin , Kefeng Wang , Yu Zhao , John Hubbard , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250122124047.1216024-1-ziy@nvidia.com> <04002289-c78f-4e1d-b242-144dd53a62f8@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cvlWZKSAG5sB1syIHkN-FWbTJG4mUIs3Nf7OpZawyhw_1737559659 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1BC44160014 X-Stat-Signature: xth5rxnedrjxowkfmg9oohiw3s9e33yq X-Rspam-User: X-HE-Tag: 1737559663-522218 X-HE-Meta: U2FsdGVkX1/Wk6YQCxm+ZE8O+beLJlQMl/yrPNm17bgbz6AlhUx0T5Jg3Ch2SPZ1MlQRiiVd5PJogTHuoxnBchQV+cinMTnGLt2JUDZl9QsrVlS4nGcBimbzPpJL6cDssKcIO1/89HawzTf9NXec7bPPBdLR5ClTUePG9bLqaRZWslM7E6nJzsl0xxzbvaPrTyijxW9lBhjwAOXTNv+r8aIXfYeZQn5KQpP6SnXOEEe/um47v9t1fPb60g48KMijdv/UxSRK451V+XHd42L42xbw2EhwqjjskcSsViyAWlvqUOUtO8+bRXjEseXJTrdAzC2XzLpB5cE3Meuwwg9I5BpeJxg7lrBQLvgXClRF+9uaS3OayijhwPtQhQulRlqYcKRE35nUh41AWEC7xHtQUdmspcC3+2u2ZsnnwWJb7PHp5n9IS56g91PZT57eTTTwOSZh5uzg1yxSSe09yJM0RxnLnTddLHxje1AbleOccD5q0GozvaVwIQ5kfXz1bSLu2DDgpA2mb/yc3b2q2Nz7zDarqppNo1xOLBa+H5cMduO4Nut4hLjUUDZ8POKhlrQGK329fJRonfRHcV7v8giYc7MQyNuq2BEYRVas6kImHypYGz64QXa/iquVyUpcJn5/SFSBm6QNJKecSfVNiR7dmwHUgI2LbCY8C3z3YBbGJKgrTv8S9F5mox/ZVCk94LYIfNSmLnJfk1c2d7jtv00oqxxIbroeKi5e987y5/uSqpaot53nLgGKwEDk3HdeBSQgGDXx6GgCvK/ncm+Np7jCtaBPkQXnftJ4gVGdq6jR2zdHmilR3zt7IWYzHUPVM3w+3m/Lupx/N6SsBfG9nRwOwyOuvclcOwWqVIAoyFduxooO4+Ug0XQxmNywWwF1XPAaWJ50sRRieS7vLOCE/J8iIt1nxiu4CB2hlV1uczJazhTNvP9fTtiRmZqifOyLOPTOSQpYmUaZPKMWCQlUjbV 4aDPLcOr jKdnoPMY3Gv3FHr0FBAQVqq7zn1kMBW9OqwbcRGZPo9V9ULoCejWh/vwej9SJ+dMjj78rQ2T7L4/5z0C9RhtsCLQGbBrOBNBppfA04dDEnDkOOYHeTdRgIm8D6jRU5cg6hMw5l1y5YmDdbRA/SVeeESqzdwu68Nu3RVwq8Pj5F+ZJBbYZ+5LdPPZos/EnEW/p6i75h8gFWCEhQCWnHxDvNs4gDHBQyUvMCkVQARliJyeNF3urG40KlnLZvjg4U7O+CGNuB48iyn1pTXUETSgU2baMNi6lIRnnbuzfNL49qbcnGLdVsUU8PjIbfUtXkGNVM065/tMz4NCJ889dyRkqBkWaKokPKmRnivBtq03OmNOD2H8XHffs+cBIHRpChGcMLFGmE52IjAUeHi/ixYY6VGGWgfhaZMp7NGszXHewYPWu7Mg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.01.25 16:16, Zi Yan wrote: > On Wed Jan 22, 2025 at 9:26 AM EST, David Hildenbrand wrote: >> On 22.01.25 13:40, Zi Yan wrote: >>> Commit acd7ccb284b8 ("mm: shmem: add large folio support for tmpfs") >>> changes huge=always to allocate THP/mTHP based on write size and >>> split_huge_page_test does not write PMD size data, so file-back THP is not >>> created during the test. >> >> Just curious, why can't we write PMD size data instead, to avoid messing >> with the "force" option? > > It also works. I used "force", because I notice that it is intended for > testing. Using it might be more future proof, in case huge=always changes > its semantics again in the future. I recall discussing with Hugh in an upstream call that "force" is a relict from older times, so naturally I would have just adjusted the test case to trigger the PMD scenario. No strong opinion, though, was just wondering. -- Cheers, David / dhildenb