From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2ACAC433E1 for ; Thu, 27 Aug 2020 11:15:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 77A0222CF6 for ; Thu, 27 Aug 2020 11:15:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77A0222CF6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2105B6B0022; Thu, 27 Aug 2020 07:15:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E8AF8E000C; Thu, 27 Aug 2020 07:15:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D6916B0024; Thu, 27 Aug 2020 07:15:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id EB5BD6B0022 for ; Thu, 27 Aug 2020 07:15:09 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AA78F181AEF1A for ; Thu, 27 Aug 2020 11:15:09 +0000 (UTC) X-FDA: 77196091938.19.month91_5507cb42706c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 751C41AD1A3 for ; Thu, 27 Aug 2020 11:15:09 +0000 (UTC) X-HE-Tag: month91_5507cb42706c X-Filterd-Recvd-Size: 3027 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 11:15:08 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E8EF113E; Thu, 27 Aug 2020 04:15:08 -0700 (PDT) Received: from [192.168.1.190] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F18283F68F; Thu, 27 Aug 2020 04:15:05 -0700 (PDT) Subject: Re: [PATCH 26/35] kasan, arm64: Enable TBI EL1 To: Catalin Marinas Cc: Andrey Konovalov , Dmitry Vyukov , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <518da1e5169a4e343caa3c37feed5ad551b77a34.1597425745.git.andreyknvl@google.com> <20200827104033.GF29264@gaia> <9c53dfaa-119e-b12e-1a91-1f67f4aef503@arm.com> <20200827111344.GK29264@gaia> From: Vincenzo Frascino Message-ID: Date: Thu, 27 Aug 2020 12:17:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200827111344.GK29264@gaia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 751C41AD1A3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/27/20 12:13 PM, Catalin Marinas wrote: > On Thu, Aug 27, 2020 at 12:05:55PM +0100, Vincenzo Frascino wrote: >> On 8/27/20 11:40 AM, Catalin Marinas wrote: >>> On Fri, Aug 14, 2020 at 07:27:08PM +0200, Andrey Konovalov wrote: >>>> diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S >>>> index 152d74f2cc9c..6880ddaa5144 100644 >>>> --- a/arch/arm64/mm/proc.S >>>> +++ b/arch/arm64/mm/proc.S >>>> @@ -38,7 +38,7 @@ >>>> /* PTWs cacheable, inner/outer WBWA */ >>>> #define TCR_CACHE_FLAGS TCR_IRGN_WBWA | TCR_ORGN_WBWA >>>> >>>> -#ifdef CONFIG_KASAN_SW_TAGS >>>> +#if defined(CONFIG_KASAN_SW_TAGS) || defined(CONFIG_KASAN_HW_TAGS) >>>> #define TCR_KASAN_FLAGS TCR_TBI1 >>>> #else >>>> #define TCR_KASAN_FLAGS 0 >>> >>> I prefer to turn TBI1 on only if MTE is present. So on top of the v8 >>> user series, just do this in __cpu_setup. >> >> Not sure I understand... Enabling TBI1 only if MTE is present would break >> KASAN_SW_TAGS which is based on TBI1 but not on MTE. > > You keep the KASAN_SW_TAGS as above but for HW_TAGS, only set TBI1 later > in __cpu_setup(). > Ok, sounds good. -- Regards, Vincenzo