From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BD7ACD1283 for ; Wed, 27 Mar 2024 02:06:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 617FD6B0087; Tue, 26 Mar 2024 22:06:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A0466B0088; Tue, 26 Mar 2024 22:06:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 419E76B0089; Tue, 26 Mar 2024 22:06:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2F74E6B0087 for ; Tue, 26 Mar 2024 22:06:17 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BDD67408FB for ; Wed, 27 Mar 2024 02:06:16 +0000 (UTC) X-FDA: 81941179152.03.F535925 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf19.hostedemail.com (Postfix) with ESMTP id D09B31A0008 for ; Wed, 27 Mar 2024 02:06:14 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=W7DiTbud; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf19.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711505174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uwUOUJFev6SeeJTav481VchkFk0enH4AA6PGxDjAHGs=; b=h1HTnNppRhC+JkjivPQf9uLaemuO8DxK7paiDzFYoxhjD598erqNOaq8o9WEfy5GGEdtAn v3cQiiklLd80zYaojHElU/DgqGJ50V3aFqRES9lwpwHojaSAhnjqnS0Ny70/z190GXmx5R xSPYuSJp0UzEdeY3PFw1LzXdmwGrWtc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=W7DiTbud; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf19.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711505174; a=rsa-sha256; cv=none; b=xSCASg1rgJloIpv1eBThMtmZj3nUqgbWozFfPif+QYO00cabemMFlgtFP52Rc6JYBqymi3 XRdCoQVGqhUPmSMNWWE5gjpe6KusX9IF86VUOukr/9MO6TGTwHpRA3oN14C7uKop0Wio/O OHzU0xxaiB9jwbduGKGsTrlYxxmfunM= Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-58962bf3f89so1256626a12.0 for ; Tue, 26 Mar 2024 19:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1711505173; x=1712109973; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uwUOUJFev6SeeJTav481VchkFk0enH4AA6PGxDjAHGs=; b=W7DiTbud+syzEmFTVoPyFSrP3YiCOfrizdrtzyE/kOCagLg0YDV9BTJFJW7N/UX7za qcr2OINXjwY45lBx4ll4Kw9NQhEIr4TntNkNhYHP0/E7N/LL6I5VsfD7DWcGCSGqvZuW +0zhn2aAEScnvqswYnyaqwtv9tq2gN7AVRsuH14jMK2ZKHh82nGAT/bihUBhFBq6j+Qr NmOfHbzHwElG+iuJB80q2LbZdaROMClFCQR9l9WOxYU2j+jNqj8cUpzlRG8s03i7r6St C9LMdXj3iOJOpXEI1aDW1D99mPdKgDYktYM5kp9Fsa86+vF11vyFNDYQiRi7doF9Q8ja U3FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711505173; x=1712109973; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uwUOUJFev6SeeJTav481VchkFk0enH4AA6PGxDjAHGs=; b=lPQIwLviT2pMBkRIXZ+rhsL3g1KvIRrSJH47KNZYBWZ5oRJPOsHNP1LR1oVeGbn0ae dxuTsyDn5HT3ZRfwjn8eXcBrEruhUQNBTlNr5iLwXkMNXEYvKxBEpRREmxXItwblAfqt l4MS5h6XNJJuE4GuZT9LCK4/dkWLG6iNcPUvJc4POpRcYJptGB50IWD/ppSpk/I6uSyq xj1nan0KY9mgGZDcM0XnCbCKrJ3Di+CsUwKOJfDwkrlntBNTzMWTbyRTYFQ11XqRX748 KuUolKnjnNQ3IQviLLXfyRfCMvDRYGu8d9im0ciQOYFLMnGL83ZNr8Y6eIV1aqmKa4OP 6dng== X-Forwarded-Encrypted: i=1; AJvYcCVw0kSLhfEPdAK2/DAdW7EdZIvCT4WYDuVkwE1CawUbMTDAQGBmDB80oRYMEK5iH1J7urxAmSv2IU/HeKev818sEg8= X-Gm-Message-State: AOJu0YyZYwGfcNVu1/Ei1MCHtTlEm4GZVHu3no+Hn1tKC5vsLrwZ9MR8 2vpQVgOHmFOwFwsOhZEk1dJgP0QjeFzd8SCCcY0FZ3UQscqH6pmZCPcsdEtLuZk= X-Google-Smtp-Source: AGHT+IGfD8kxXoqXM9ss45RtxP+teLNaG0eXEfoVNsyy2oHStpBFx81guKfPstuUlABCC6y8qf6jrQ== X-Received: by 2002:a05:6a20:7fa6:b0:1a3:b00a:7921 with SMTP id d38-20020a056a207fa600b001a3b00a7921mr15025519pzj.5.1711505173271; Tue, 26 Mar 2024 19:06:13 -0700 (PDT) Received: from [10.254.105.249] ([139.177.225.230]) by smtp.gmail.com with ESMTPSA id ld8-20020a170902fac800b001e009717560sm7618786plb.232.2024.03.26.19.06.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 19:06:12 -0700 (PDT) Message-ID: Date: Wed, 27 Mar 2024 10:06:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm: pgtable: add missing pt_index to struct ptdesc Content-Language: en-US To: Vishal Moola Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, rppt@kernel.org, willy@infradead.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <283624c2af45fb2090b41a6b1b5481bb0a45bad7.1709541697.git.zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D09B31A0008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: h9ig57xnrg697mi5ysrdtf9jeqi18moe X-HE-Tag: 1711505174-333525 X-HE-Meta: U2FsdGVkX19k7TEsdkcPtFG6SLvFVHl2SM+RVG5wqJvxPM1bZ9vhefHIa0yz4i6xnHCqDjaCm6JQfyE8coPbqZvQ96N+A1UywAjuFiyULq/VWyt3rdBXppCtvj4Ts2feVDNczdzXu7wobaluXsehTHDbpHYq2SL9Pq+a8cbN/gebaUSGSL3+Y2k0tFa984ymxHMrTRbdqhmDfruwF1WpaiJ18pH/aloLteuL27VnW6c34YItDl12R9FRT6bH3kibmm6OIuqmqb0y0DmKY7TclTLFPr1kssAEjm+/tpLYe+3ylwJnxJQRVU6RV8Y8RLDKLMUXkCUCps6Yvm/pCU/9JK/NIHqzCqgAkKmmgtYJ4AgIm8nQhaXoMsYrp4wGIYR55frqG7kl34t4oAZurG306p/cglb/gyVvCUvar1GoMeA9ReibCPd+5A59cPlLklkRsYq95cyW3drQafule929nkxARgKGRbQjB3by7IYMXF73FxMHotsDNmYTZkXWrrmNhjWMZB4NQ/c7eyO73yidQXfPXbVMJEPjCoZzuciHFDB+u1mxB9Wd8u+2neiPiwf/2zYtz2AfPa6dY7LzubpmLp2iDNlcJk/WFYUsuoijHqNRQ8RZJ09nIyg9cKRw4bIG6Zl2jz+tK5gEHgJ0y7GjP4GLmMrMRmaqdeqdTfwo8UdHQy0t5mss7fBCUFPDV31zIh7FDRUeibTXyDo6RouYHMEX0OTA4k8RFTCESS+ozy1WSxyspKKlxWzdQdLXHuNrPimuvLqqoxiKTYE4r8Jk6KMfnZVwWy97YVl6eUrG6WA4DWkUTE4c6KueXxyx0Rv2auhLlo3nE2lD4f3P7G4T4l5o9QUJW+eh1zocDV0f+zeBNMbv397N18zNtGdhKwHxl5mqnAmoZIu+Hkk3nCQ14Rv5iGZ6SAU6gQnbnKQBp+tl2J/lJnedGM9X58i0+w+jLC0CNJDdwgLnOrrDcdE YWK+KU83 EbMkU2k4diLR1e+d8r6y2BmN5ybHj91TCS84N/Bkg5GNp4CpfjPiMmth0cDNuNfbVSsReeJm7bslqYIwPE+MzsI1tbs81YUvoZyXBf3BsdxP2yVdZZh/JwT5YxKXz5QPOpD3f5BfyV0miiBkCkTNNck6FdcmenpX7VwDx6QCJdAazXU6FJvVPVNom6KTfoMtBwKasHSdzpLmHJ046QH+M8PyhnF1bHIn7UftB9tZECwhItzpJL16f3eDN0oEKg5gGociaqgSzHSIuult1FDImfwl7nFGs+MDS2aQVElHGzvRFoNZLjzXaDw75gsTJVKzSgV2/1txkoLsNCWv+uJMPtJJr3vpDmzK3k3bdvadSfa7WLZT7DIIY8pW4c6MXUpn2EMhcJLW3Tz5nL3imlHbxXWSxS81LVep+iN2kl/RHIoxSaqLrY9Srf5y7DVMk2OROGJg/T0kgfqqSoWY+imDUe+2wRFe0OkThHoALmUsiMNfff/kOBQXBpYovm8jZTiJeCvNR4/DB09NkLbODLp/cvE+DxJHbO5dooqrHhcLXfpuhnN70dra3SpbUsnEnEnLmpxaIPKw7ZYGd4xVYlx2mhS61mvgOZKKnOL61NoPAYS3tJ7cVXLdqw6DxgXP31Ec8DujL5nNpOnYLZUT1O3UY23MKVSTcNOmbGgpJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/27 03:25, Vishal Moola wrote: > On Mon, Mar 04, 2024 at 07:07:19PM +0800, Qi Zheng wrote: >> In s390, the page->index field is used for gmap (see gmap_shadow_pgt()), >> so add the corresponding pt_index to struct ptdesc and add a comment to >> clarify this. > > Yes s390 gmap 'uses' page->index, but not for the purpose page->index is > supposed to hold. It's alright to have a variable here, but I'd rather > see it named something more appropriate to the purporse it serves. Make sense. > > You can take look at this patch from v5 of my ptdesc conversion series > for more info: > https://lore.kernel.org/linux-mm/20230622205745.79707-3-vishal.moola@gmail.com/ Oh, but it seems that this patch has not been merged? > >> Signed-off-by: Qi Zheng >> --- >> include/linux/mm_types.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h >> index 5ea77969daae..5240bd7bca33 100644 >> --- a/include/linux/mm_types.h >> +++ b/include/linux/mm_types.h >> @@ -425,6 +425,7 @@ FOLIO_MATCH(compound_head, _head_2a); >> * @_pt_pad_1: Padding that aliases with page's compound head. >> * @pmd_huge_pte: Protected by ptdesc->ptl, used for THPs. >> * @__page_mapping: Aliases with page->mapping. Unused for page tables. >> + * @pt_index: Used for s390 gmap. >> * @pt_mm: Used for x86 pgds. >> * @pt_frag_refcount: For fragmented page table tracking. Powerpc only. >> * @_pt_pad_2: Padding to ensure proper alignment. >> @@ -450,6 +451,7 @@ struct ptdesc { >> unsigned long __page_mapping; >> >> union { >> + pgoff_t pt_index; >> struct mm_struct *pt_mm; >> atomic_t pt_frag_refcount; >> }; >> @@ -475,6 +477,7 @@ TABLE_MATCH(flags, __page_flags); >> TABLE_MATCH(compound_head, pt_list); >> TABLE_MATCH(compound_head, _pt_pad_1); >> TABLE_MATCH(mapping, __page_mapping); >> +TABLE_MATCH(index, pt_index); >> TABLE_MATCH(rcu_head, pt_rcu_head); >> TABLE_MATCH(page_type, __page_type); >> TABLE_MATCH(_refcount, __page_refcount); >> -- >> 2.30.2 >>