linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scripts: fix the gfp flags header path in gfp-translate
@ 2023-06-08 15:44 Prathu Baronia
  2023-06-09  0:35 ` Andrew Morton
  2023-06-12  9:21 ` David Hildenbrand
  0 siblings, 2 replies; 3+ messages in thread
From: Prathu Baronia @ 2023-06-08 15:44 UTC (permalink / raw)
  To: akpm, masahiroy, linux-kernel; +Cc: linux-mm, nathan, ndesaulniers, nicolas

Since gfp flags have been shifted to gfp_types.h so update the path in
the gfp-translate script.

Signed-off-by: Prathu Baronia <prathubaronia2011@gmail.com>
---
 scripts/gfp-translate | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/gfp-translate b/scripts/gfp-translate
index b2ce416d944b..6c9aed17cf56 100755
--- a/scripts/gfp-translate
+++ b/scripts/gfp-translate
@@ -63,11 +63,11 @@ fi
 
 # Extract GFP flags from the kernel source
 TMPFILE=`mktemp -t gfptranslate-XXXXXX` || exit 1
-grep -q ___GFP $SOURCE/include/linux/gfp.h
+grep -q ___GFP $SOURCE/include/linux/gfp_types.h
 if [ $? -eq 0 ]; then
-	grep "^#define ___GFP" $SOURCE/include/linux/gfp.h | sed -e 's/u$//' | grep -v GFP_BITS > $TMPFILE
+	grep "^#define ___GFP" $SOURCE/include/linux/gfp_types.h | sed -e 's/u$//' | grep -v GFP_BITS > $TMPFILE
 else
-	grep "^#define __GFP" $SOURCE/include/linux/gfp.h | sed -e 's/(__force gfp_t)//' | sed -e 's/u)/)/' | grep -v GFP_BITS | sed -e 's/)\//) \//' > $TMPFILE
+	grep "^#define __GFP" $SOURCE/include/linux/gfp_types.h | sed -e 's/(__force gfp_t)//' | sed -e 's/u)/)/' | grep -v GFP_BITS | sed -e 's/)\//) \//' > $TMPFILE
 fi
 
 # Parse the flags

base-commit: 44c026a73be8038f03dbdeef028b642880cf1511
-- 
2.34.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scripts: fix the gfp flags header path in gfp-translate
  2023-06-08 15:44 [PATCH] scripts: fix the gfp flags header path in gfp-translate Prathu Baronia
@ 2023-06-09  0:35 ` Andrew Morton
  2023-06-12  9:21 ` David Hildenbrand
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2023-06-09  0:35 UTC (permalink / raw)
  To: Prathu Baronia
  Cc: masahiroy, linux-kernel, linux-mm, nathan, ndesaulniers, nicolas

On Thu,  8 Jun 2023 21:14:49 +0530 Prathu Baronia <prathubaronia2011@gmail.com> wrote:

> Since gfp flags have been shifted to gfp_types.h so update the path in
> the gfp-translate script.
> 
> ...
>
> --- a/scripts/gfp-translate
> +++ b/scripts/gfp-translate
> @@ -63,11 +63,11 @@ fi
>  
>  # Extract GFP flags from the kernel source
>  TMPFILE=`mktemp -t gfptranslate-XXXXXX` || exit 1
> -grep -q ___GFP $SOURCE/include/linux/gfp.h
> +grep -q ___GFP $SOURCE/include/linux/gfp_types.h
>  if [ $? -eq 0 ]; then
> -	grep "^#define ___GFP" $SOURCE/include/linux/gfp.h | sed -e 's/u$//' | grep -v GFP_BITS > $TMPFILE
> +	grep "^#define ___GFP" $SOURCE/include/linux/gfp_types.h | sed -e 's/u$//' | grep -v GFP_BITS > $TMPFILE
>  else
> -	grep "^#define __GFP" $SOURCE/include/linux/gfp.h | sed -e 's/(__force gfp_t)//' | sed -e 's/u)/)/' | grep -v GFP_BITS | sed -e 's/)\//) \//' > $TMPFILE
> +	grep "^#define __GFP" $SOURCE/include/linux/gfp_types.h | sed -e 's/(__force gfp_t)//' | sed -e 's/u)/)/' | grep -v GFP_BITS | sed -e 's/)\//) \//' > $TMPFILE
>  fi
>  

Thanks.  I added

Fixes: cb5a065b4ea9c ("headers/deps: mm: Split <linux/gfp_types.h> out of <linux/gfp.h>")
Cc: <stable@vger.kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scripts: fix the gfp flags header path in gfp-translate
  2023-06-08 15:44 [PATCH] scripts: fix the gfp flags header path in gfp-translate Prathu Baronia
  2023-06-09  0:35 ` Andrew Morton
@ 2023-06-12  9:21 ` David Hildenbrand
  1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2023-06-12  9:21 UTC (permalink / raw)
  To: Prathu Baronia, akpm, masahiroy, linux-kernel
  Cc: linux-mm, nathan, ndesaulniers, nicolas

On 08.06.23 17:44, Prathu Baronia wrote:
> Since gfp flags have been shifted to gfp_types.h so update the path in
> the gfp-translate script.
> 
> Signed-off-by: Prathu Baronia <prathubaronia2011@gmail.com>
> ---
>   scripts/gfp-translate | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/gfp-translate b/scripts/gfp-translate
> index b2ce416d944b..6c9aed17cf56 100755
> --- a/scripts/gfp-translate
> +++ b/scripts/gfp-translate
> @@ -63,11 +63,11 @@ fi
>   
>   # Extract GFP flags from the kernel source
>   TMPFILE=`mktemp -t gfptranslate-XXXXXX` || exit 1
> -grep -q ___GFP $SOURCE/include/linux/gfp.h
> +grep -q ___GFP $SOURCE/include/linux/gfp_types.h
>   if [ $? -eq 0 ]; then
> -	grep "^#define ___GFP" $SOURCE/include/linux/gfp.h | sed -e 's/u$//' | grep -v GFP_BITS > $TMPFILE
> +	grep "^#define ___GFP" $SOURCE/include/linux/gfp_types.h | sed -e 's/u$//' | grep -v GFP_BITS > $TMPFILE
>   else
> -	grep "^#define __GFP" $SOURCE/include/linux/gfp.h | sed -e 's/(__force gfp_t)//' | sed -e 's/u)/)/' | grep -v GFP_BITS | sed -e 's/)\//) \//' > $TMPFILE
> +	grep "^#define __GFP" $SOURCE/include/linux/gfp_types.h | sed -e 's/(__force gfp_t)//' | sed -e 's/u)/)/' | grep -v GFP_BITS | sed -e 's/)\//) \//' > $TMPFILE
>   fi
>   
>   # Parse the flags
> 
> base-commit: 44c026a73be8038f03dbdeef028b642880cf1511

Yes, works for me then

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-12  9:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-08 15:44 [PATCH] scripts: fix the gfp flags header path in gfp-translate Prathu Baronia
2023-06-09  0:35 ` Andrew Morton
2023-06-12  9:21 ` David Hildenbrand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox