linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Prathu Baronia <prathubaronia2011@gmail.com>,
	akpm@linux-foundation.org, masahiroy@kernel.org,
	linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, nathan@kernel.org, ndesaulniers@google.com,
	nicolas@fjasle.eu
Subject: Re: [PATCH] scripts: fix the gfp flags header path in gfp-translate
Date: Mon, 12 Jun 2023 11:21:24 +0200	[thread overview]
Message-ID: <d63da17e-78cf-22ec-a134-a2a2b4bf52e4@redhat.com> (raw)
In-Reply-To: <20230608154450.21758-1-prathubaronia2011@gmail.com>

On 08.06.23 17:44, Prathu Baronia wrote:
> Since gfp flags have been shifted to gfp_types.h so update the path in
> the gfp-translate script.
> 
> Signed-off-by: Prathu Baronia <prathubaronia2011@gmail.com>
> ---
>   scripts/gfp-translate | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/gfp-translate b/scripts/gfp-translate
> index b2ce416d944b..6c9aed17cf56 100755
> --- a/scripts/gfp-translate
> +++ b/scripts/gfp-translate
> @@ -63,11 +63,11 @@ fi
>   
>   # Extract GFP flags from the kernel source
>   TMPFILE=`mktemp -t gfptranslate-XXXXXX` || exit 1
> -grep -q ___GFP $SOURCE/include/linux/gfp.h
> +grep -q ___GFP $SOURCE/include/linux/gfp_types.h
>   if [ $? -eq 0 ]; then
> -	grep "^#define ___GFP" $SOURCE/include/linux/gfp.h | sed -e 's/u$//' | grep -v GFP_BITS > $TMPFILE
> +	grep "^#define ___GFP" $SOURCE/include/linux/gfp_types.h | sed -e 's/u$//' | grep -v GFP_BITS > $TMPFILE
>   else
> -	grep "^#define __GFP" $SOURCE/include/linux/gfp.h | sed -e 's/(__force gfp_t)//' | sed -e 's/u)/)/' | grep -v GFP_BITS | sed -e 's/)\//) \//' > $TMPFILE
> +	grep "^#define __GFP" $SOURCE/include/linux/gfp_types.h | sed -e 's/(__force gfp_t)//' | sed -e 's/u)/)/' | grep -v GFP_BITS | sed -e 's/)\//) \//' > $TMPFILE
>   fi
>   
>   # Parse the flags
> 
> base-commit: 44c026a73be8038f03dbdeef028b642880cf1511

Yes, works for me then

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb



      parent reply	other threads:[~2023-06-12  9:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 15:44 Prathu Baronia
2023-06-09  0:35 ` Andrew Morton
2023-06-12  9:21 ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d63da17e-78cf-22ec-a134-a2a2b4bf52e4@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nicolas@fjasle.eu \
    --cc=prathubaronia2011@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox