From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CA8AC25B74 for ; Mon, 27 May 2024 07:15:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B9C16B0082; Mon, 27 May 2024 03:15:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1698C6B0083; Mon, 27 May 2024 03:15:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00A706B0085; Mon, 27 May 2024 03:15:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D71A56B0082 for ; Mon, 27 May 2024 03:15:30 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 388E4A1421 for ; Mon, 27 May 2024 07:15:30 +0000 (UTC) X-FDA: 82163315220.13.D7AA231 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf19.hostedemail.com (Postfix) with ESMTP id C0ACB1A000F for ; Mon, 27 May 2024 07:15:27 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="m/B0+aLC"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DkP7wgtL; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="m/B0+aLC"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DkP7wgtL; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716794128; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SRLX4O6F2vJC5vzs06vjyX9BbI9jbKHvHebBkNNhvQ0=; b=jDLj/x162UqnHXBZ8xzfeZKe5CI12rfxyrpM+t2n80014TMbJM54K1qnr1AsF74QjP+yj+ 6ivfXcWt7LZtKdv9WXCWtEpt+V+X29oWRwxqWMldoN+x14oyqLOQWIasaSODjlbQCHIASQ a+x/jWX3unhjxHY5to0gDGpxepf+zT0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716794128; a=rsa-sha256; cv=none; b=qKaOd5guMEC4NkWBBAuIWF4sg38+KFE3gR8kro8m7DNxe40Ha2I+IvfJD4RlHHzfk9rYOl z70soFWXNSKDbLPh8aKIFT9QxczEzKrGrfr7rSmpronfYNAdJBgPkphXVamJzY4R6MAxwo Thfsq7GvawQSoP0PEaOQ4Wbzi/oF8uI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="m/B0+aLC"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DkP7wgtL; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="m/B0+aLC"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DkP7wgtL; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D690421CEA; Mon, 27 May 2024 07:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1716794125; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SRLX4O6F2vJC5vzs06vjyX9BbI9jbKHvHebBkNNhvQ0=; b=m/B0+aLC4pRrVtXuGeJkOFb8TE4lMqcoe/AsgvxX9e6wOmjZBj5u3j73GWAw83t1xtPuDu 8G2g/6byKpOG3D4vfhK7bFEgEiFN75fliaJSs4SYzdZmGDE6Pi7YI/Nj0evHglDWce09l6 Pbiyga9vBxM2Kkwi5NDo8f6DuPqkqDo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1716794125; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SRLX4O6F2vJC5vzs06vjyX9BbI9jbKHvHebBkNNhvQ0=; b=DkP7wgtLY1Tc3RoaIr0EAR2+h3toWfPg+uh7xGYUTDk6DrjOBGBJXTjpF1QBUtaBJFSvUd ON7zm5WUYNti2PBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1716794125; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SRLX4O6F2vJC5vzs06vjyX9BbI9jbKHvHebBkNNhvQ0=; b=m/B0+aLC4pRrVtXuGeJkOFb8TE4lMqcoe/AsgvxX9e6wOmjZBj5u3j73GWAw83t1xtPuDu 8G2g/6byKpOG3D4vfhK7bFEgEiFN75fliaJSs4SYzdZmGDE6Pi7YI/Nj0evHglDWce09l6 Pbiyga9vBxM2Kkwi5NDo8f6DuPqkqDo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1716794125; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SRLX4O6F2vJC5vzs06vjyX9BbI9jbKHvHebBkNNhvQ0=; b=DkP7wgtLY1Tc3RoaIr0EAR2+h3toWfPg+uh7xGYUTDk6DrjOBGBJXTjpF1QBUtaBJFSvUd ON7zm5WUYNti2PBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C351913A6B; Mon, 27 May 2024 07:15:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id T21cLw0zVGZBGwAAD6G6ig (envelope-from ); Mon, 27 May 2024 07:15:25 +0000 Message-ID: Date: Mon, 27 May 2024 09:15:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, slab: don't wrap internal functions with alloc_hooks() To: Kees Cook Cc: Christoph Lameter , David Rientjes , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kent Overstreet , Suren Baghdasaryan References: <20240522095037.13958-1-vbabka@suse.cz> <202405241625.9FF3B5E@keescook> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <202405241625.9FF3B5E@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: mudz3z6tgqxuj9y9khj9uujjm436fpwu X-Rspamd-Queue-Id: C0ACB1A000F X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1716794127-859651 X-HE-Meta: U2FsdGVkX1+99PvFZU1Bdgz5prPlZDOT8o3LE8hoBy53QqyuwcU4Zaj4X+iqF15LNGvBHXJwwJGXXgWJtDmP+75QaZclQZcu4nEdFYPTMuS7rO1KluN8+F83bKcZsRks4PAaW2yje48BkRB5xsnjmNEdcBqO8t+Xv0OdJdy3UNpVFX+V8SxjV1N52RXK+bs/WkCpJU71ga2czY5JVuv9uN9nh5ulggN1a6Z9OMAU78N2UteqfwAM69d2viwhN/TIX+GY8sclnYRjMaVE5kx0UGu5DwoZQX5tk+gl1vm4C4CkDoRb/9GqRF2+rKkU9rM9WICHXVntYOoG23DPQLdFegGbanKbjIBrzU9SSaa5MGqm9jVo5lUmMr6/7/f8IExtqwTBlLKJZIHX6ZGMs0eLvMLkk2D1iPLuno4MznToM68LYrtJm0bx0TWeG3gjar0u2aLuRmphg9Hu2FGR9+gBpobM+VG6wM5dGdEQzTxUDxb7p0Y518Ku5E1k+0nTD3SC95vh1DhD+MfkOnXRDpPVueZCyI9SX6c6YNWFIIF40Cqe73iGrm2axmdi+NGkwbHcZg5Bs6aZJtU406ljngA5YalEJ/NqweZcnaVrrDY+nOm1JCg/yIQ8Xb1CdZeK6JyA+odb4U9OtATME8SutigX2dH2MSe/OZFAEGxfQxMya1flOmDVHv53cO+yWE3l/5YlbBE7aX6GNoZ28dx4FP+GNxMGBa3f8R4aQ/bLYNiXCO9BV4fR3pdUJQ5j7lZTyNzb8qeX7NNGsn4fGQPgrSsiO2pxq8aJdgV/2e2umwCTGOOgZSP7WsuKeNXwcflXpqV+vuGX5bE8sjPU2+NlBsvkdDqCxV+n4yO0jCCzByGo00o645RtQZX8C0DpF/RlBiragbkR5K4xhRBEsuB/7K3chW3w8Hj5ZOH48PHc157KvNbBxaBlcYSSwsrWuoPVSkqG0fMZei+k/lCoA1Kpcef rN/5BixK AMoR7FRo0B2iouUyKikgUQNxAtd169yP9blgwrkjVU27/qr43+pqhDWEWbN3nmpJWpO/j/K5F/yvo/knae/U9p+09FoezvJVlqK5toa4vscCb3sbAgOPWPo9rOIxt8t0ZnVxCQkbD3ribpqqNKSModQZABmzDDgC6QmzUqsaqhYBOPgG6S+zgTLvIrDEYX29jmwbmFXjEcEEvweSJLHCGGWsr2qIEPPe0NCHxvsj24EfKeQgCZF31JER54C470u7Mec963iZox7pWq52DiAgWEgbUkyM3pytLSPaPSvG1F/i1DLeeDWmcb3wxkRDYrqso/IzeEO0oGAyRnoDzVdIbDYlCNSeet72iCS3WAee34qDNXrC8QtAvnxpGwKUZs9rn13OM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000490, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/25/24 1:26 AM, Kees Cook wrote: > On Wed, May 22, 2024 at 11:50:37AM +0200, Vlastimil Babka wrote: >> The functions __kmalloc_noprof(), kmalloc_large_noprof(), >> kmalloc_trace_noprof() and their _node variants are all internal to the >> implementations of kmalloc_noprof() and kmalloc_node_noprof() and are >> only declared in the "public" slab.h and exported so that those >> implementations can be static inline and distinguish the build-time >> constant size variants. The only other users for some of the internal >> functions are slub_kunit and fortify_kunit tests which make very >> short-lived allocations. > > If it's only internal, I'm happy to drop it from fortify_kunit. Yeah, looks like you already have static and dynamic size parameter variants of the tests so testing kmalloc() will call __kmalloc_noprof() in the dynamic case (ditto _node variant) and is the best way to exercise that. So So in v2 I will drop those from fortify_kunit instead of adjusting names. > -Kees >