From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A974C88CB7 for ; Mon, 12 Jun 2023 17:00:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A44B26B0074; Mon, 12 Jun 2023 13:00:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1C386B0075; Mon, 12 Jun 2023 13:00:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90AFA6B0078; Mon, 12 Jun 2023 13:00:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 784FF6B0074 for ; Mon, 12 Jun 2023 13:00:12 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7DB44AF6CD for ; Mon, 12 Jun 2023 17:00:09 +0000 (UTC) X-FDA: 80894708538.20.063CC4D Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf21.hostedemail.com (Postfix) with ESMTP id 280941C002C for ; Mon, 12 Jun 2023 17:00:05 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V9EcM7IN; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686589206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nHEuyVr8WoMRGwHVfv0DfxruHuLq9Y6B71Skb7fxoL4=; b=PCmmJtxTVGILLAQR3HBCv/Q+jj81h2piyj1EM2wE3DoeH486nItD3fY7YnKt26ZSg/He9A dJPK7XopF7i7taUGcNGyc4Mh68STuOKxh3C/W5iNg5V7A1vv6ShaQM7VCd9C/Y5YX4iLJX 4xokRoil6IUGON5oMy5MOsbw9KNVox0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686589206; a=rsa-sha256; cv=none; b=ttJiM4/rX3UDbd3q7JFrpPErNs+Gbtp+JGM1Ax89j81the/vB7rTagy5TaklwQ4Xz1U+kM b3aBfCqWaxxPyO2IZiXq1Q04oJaQ/HM4WMMAPBNaMIRwyo4xf7P5kfrqUk+Govnnpgj82v SZlExVHEI7y4ruWiS/zKf5hyaIcbY/A= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V9EcM7IN; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686589206; x=1718125206; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lINzTdir4qaEtcszrtUnYr0rUxQ02JyprEtg0yNn6yc=; b=V9EcM7IN5ZZwH0bX6cxe9o//8VWqs5Vo2MvV8Ql+rqwxqXT0nCPcvOMP N3S6L+Tv02JGtDmULZ75hoFTxNHy5mYYNw3jddjrf3FY6E2/F6J2FfEUM Cq0/QDN6voOZCoulju5BxSclZIm93Rjpwi2hJ83y9cGi7v0JzxmA9v63b uRskm54kKhYfRofyroXrIA13GWt72bEYW8EdQOhB3j7Hy3MxpWVy0DyfK nDLsRqo/1M7U4SJm0If/KoxC9nhx4CytsLJiZvqB7C62JtfLT0OQ4c+f9 kongrLY0LDF3YRIjmcPyxjrSYOLphwfNIY1rtd01eyflKI3rJd+2rC30j g==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="355600421" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="355600421" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 10:00:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="741098047" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="741098047" Received: from spmantha-mobl1.amr.corp.intel.com (HELO [10.209.43.2]) ([10.209.43.2]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 10:00:01 -0700 Message-ID: Date: Mon, 12 Jun 2023 10:00:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH RFC v9 14/51] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction Content-Language: en-US To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-15-michael.roth@amd.com> From: Dave Hansen In-Reply-To: <20230612042559.375660-15-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 280941C002C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ajb5b6k3awdoi5rq8oznq9j4h665ko3q X-HE-Tag: 1686589205-779366 X-HE-Meta: U2FsdGVkX18XL6I8QWkNwIioQlnSFGH+kZAUYCfE8bjslS0X7pIyG5A4zPAKdeyyBXnD1/or1GGxZQ6X2Zfpjytk/Bwim/2VVIdwDgHXh+DvSrmY6spCnjIjYOOjhN2/hF/Ex3h2cQZKm0zQ4V/amfprnfCWenQWQaP56Ne320iSXjb8mV/wV8BGjQRPGxt7EoCzIKW+tHoX+Xnjo3OwIZyNYMCnM72JDLJe9MjG/tcfWtXJ63tAH/D6C6hCg+eZfCvKtVwU1UXVlqWgVQeA1+eCkcSJOKzdms51cRYHi5GtSri0svR1w2R3j5lJOnMU5h55KP9jfQZRI2HN2MAG85+vY6AondFT7rYkfYjWJIh1ky7XWz93+mF37xBhCkQNLVsIUm/gpXPTXjGdJMKZBYKH0/fOjTdMXm4t6fuAeR0B75eUBm5bpqBTZNRbA2cKvJT7ttSIH5hFJIwCqMU8R5AiW3zNnyGDUoUOOEW8rUc52jptDuATmx9PVNdbNFtcC2Q04zMkHjYHP378tUSFBtvhVyWVNChdjb/xdJSecUiVoxaQsqT5Ulgmh+oJ60rkIsQFRGp31HBX1Fu9Qc9qABrPC36qTk3kcVA1T3A/UNhcAsiifbK3jAYCYA+GSfUTT8RohIRRKpJAGGiacKhYHx+Gwpl71qmc7eQt0D5GSvChgwxouQWdtHtx8mq9Bv7beHgxOrTHyPR4c5MI+WdN3rhs2k+ZumBGGwGbbiBV7hsvkWgKA6+nJqlfo2NkD4Xwn4JLrku4AgoSmeETOqgkQkNDl7ifniPsP9zBeEX4jLRJ0aoU0PoSo0NxkTGd46lfzDdOO2/OPKA41K/5bRbZbkodddYzNVB7HZ5jDPVIaEyqhJLMZSLwIpAl5iX9N2M+J67vSZkOyZsgG0jkUeis5gxxHPbQrx2Cwv1VVGOQKL5GaexQk3rWvS5L+L1ujJ57JietBiFSSAK1cPWZjgv 67+XYgYP QMezLcuA59Vgl2IT8ZudqGkn/YNI832JZE0kEDCe1jgG0RcsluvL3LGnbqTfDe6crC7MQOZcrjzw6HGgoXjnP6IlseGiKwl153dn6TGHeb37IsNQWrnX7+Zneh5+CHCRWdwNMEnQZtnER9Qw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/11/23 21:25, Michael Roth wrote: > +/* > + * Assign a page to guest using the RMPUPDATE instruction. > + */ > +int rmp_make_private(u64 pfn, u64 gpa, enum pg_level level, int asid, bool immutable) > +{ > + struct rmp_state val; > + > + pr_debug("%s: GPA: 0x%llx, PFN: 0x%llx, level: %d, immutable: %d\n", > + __func__, gpa, pfn, level, immutable); Is this needed *EVERY* time a page is assigned to a guest? As in, if I create a 4GB guest, I'll see a literal million of these pr_debug()s in dmesg?