From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B73DC433F5 for ; Wed, 9 Mar 2022 08:00:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 163DC8D0017; Wed, 9 Mar 2022 03:00:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EBAC8D0001; Wed, 9 Mar 2022 03:00:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA74C8D0017; Wed, 9 Mar 2022 03:00:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id D3BD88D0001 for ; Wed, 9 Mar 2022 03:00:27 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 95D9760465 for ; Wed, 9 Mar 2022 08:00:27 +0000 (UTC) X-FDA: 79224100494.06.4158094 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id CAEF2100004 for ; Wed, 9 Mar 2022 08:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646812826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O+zcul7Y4mG3bPoT64KcHkOlEBwFPJd5IbrPAZk9VZ8=; b=FjfoTuwowJG+7fCePKOZAv3jo4tS6DfuGPs5Ta3vNBHfvgidPYi1HmGxuMtneTSmnarlCm CpxVw35dIy6Wa6IPzHuqW1AanDsJeeTSAfq+cq61wcXKq4InVbFgHJVWpIh/+yHTjFejx5 aFFaRCowt269OZb2UJnc2Tdr4WRyFEc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-244-5EhWPHr_Om2bgNf4N-b9PQ-1; Wed, 09 Mar 2022 03:00:25 -0500 X-MC-Unique: 5EhWPHr_Om2bgNf4N-b9PQ-1 Received: by mail-wr1-f72.google.com with SMTP id b9-20020a05600003c900b00203647caa11so466706wrg.5 for ; Wed, 09 Mar 2022 00:00:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=O+zcul7Y4mG3bPoT64KcHkOlEBwFPJd5IbrPAZk9VZ8=; b=KfsDU7sDo5i4HmPF+PsAXYxp5d4eWabIQlJrzSAK1WBIUVp97zZwctNADFioQODHel b5p28CcUuP1pHdglCSbJTHSsKcZ2FHyAvbfwAiiNCz16Hpg/y3UrRB0YOazbRi03lvRW P9PHoYiQHLfiULob/zeN0AddgeOUQoH5UYYwc4fC/ph+ybqz28J/NKLMKylBUBxEz5Y5 SR0p3TJisXkEArg+DVD6caRuAGUpldKb/RaX/z87T/K0TPAmmxmDeCnsoq50gmwF9n4U T8gBuEOtIaYFSbrg3aUdmyYvNUOcmbiW3Vhm1EGO5PD5OgOz2bYr97JIaPfeeQjH1YHD /zog== X-Gm-Message-State: AOAM531Yu4gXLg327UUnYvUj/cwmHgBXFrmVjtXCLDESkVmjiRcTFmXR g+6NTuwNsT7YGhbC6zbzjZBx04le2Zv4HwhB8vJeQ9OPy/Z+qybrYkNbS1JPtBllLZegqapcxRM Ow2g9VJQsu10= X-Received: by 2002:adf:d4c8:0:b0:1f0:22df:d67c with SMTP id w8-20020adfd4c8000000b001f022dfd67cmr14881708wrk.510.1646812823974; Wed, 09 Mar 2022 00:00:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzFOehg1l5XZe3AiXYAKbHawb2OS36nEHSYzfhypBEi98srCSBnnaKrh3a1a+Sz1wf5A16JOg== X-Received: by 2002:adf:d4c8:0:b0:1f0:22df:d67c with SMTP id w8-20020adfd4c8000000b001f022dfd67cmr14881675wrk.510.1646812823670; Wed, 09 Mar 2022 00:00:23 -0800 (PST) Received: from ?IPV6:2003:cb:c707:6300:8418:c653:d01f:3bd2? (p200300cbc70763008418c653d01f3bd2.dip0.t-ipconnect.de. [2003:cb:c707:6300:8418:c653:d01f:3bd2]) by smtp.gmail.com with ESMTPSA id z3-20020a1cf403000000b0037d1f4a2201sm964689wma.21.2022.03.09.00.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Mar 2022 00:00:23 -0800 (PST) Message-ID: Date: Wed, 9 Mar 2022 09:00:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: Linus Torvalds Cc: Linux Kernel Mailing List , Andrew Morton , Hugh Dickins , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , Linux-MM , Khalid Aziz References: <20220308141437.144919-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v1 00/15] mm: COW fixes part 2: reliable GUP pins of anonymous pages In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CAEF2100004 X-Stat-Signature: jnp5acgfym17yxisg1i6ph4kwot58ix4 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FjfoTuwo; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-HE-Tag: 1646812826-178911 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.03.22 22:22, Linus Torvalds wrote: > On Tue, Mar 8, 2022 at 6:14 AM David Hildenbrand wrote: >> >> This series fixes memory corruptions when a GUP pin (FOLL_PIN) was taken >> on an anonymous page and COW logic fails to detect exclusivity of the page >> to then replacing the anonymous page by a copy in the page table [...] > > From a cursory scan of the patches, this looks sane. Thanks for skimming over the patches that quickly! > > I'm not sure what the next step should be, but I really would like the > people who do a lot of pinning stuff to give it a good shake-down. > Including both looking at the patches, but very much actually running > it on whatever test-cases etc you people have. > > Please? My proposal would be to pull it into -next early after we have v5.18-rc1. I expect some minor clashes with folio changes that should go in in the next merge window, so I'll have to rebase+resend either way, and I'm planning on thoroughly testing at least on s390x as well. We'd then have plenty of time to further review+test while in -next until the v5.19 merge window opens up. By that time I should also have my selftests cleaned up and ready, and part 3 ready to improve the situation for FOLL_GET|FOLL_WRITE until we have the full FOLL_GET->FOLL_PIN conversion from John (I'll most probably sent out an early RFC of part 3 soonish). So we *might* be able to have everything fixed in v5.19. Last but not least, tools/cgroup/memcg_slabinfo.py as mentioned in patch #10 still needs care due to the PG_slab reuse, but I consider that a secondary concern (yet, it should be fixed and help from the Authors would be appreciated ;) ). -- Thanks, David / dhildenb