From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BB3C3DA4A for ; Sun, 11 Aug 2024 20:24:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 129BA6B009A; Sun, 11 Aug 2024 16:24:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DA546B009E; Sun, 11 Aug 2024 16:24:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE3E56B009F; Sun, 11 Aug 2024 16:24:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CF7146B009A for ; Sun, 11 Aug 2024 16:24:42 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3B601120466 for ; Sun, 11 Aug 2024 20:24:42 +0000 (UTC) X-FDA: 82441092804.27.8FAF723 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf21.hostedemail.com (Postfix) with ESMTP id 707B11C000A for ; Sun, 11 Aug 2024 20:24:40 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OoHTqS2c; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of rientjes@google.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723407829; a=rsa-sha256; cv=none; b=lFmoQQ9K2Kw8vnPgDQE3uDfCMOY2G9WNEVba9r7GUIfLQpNcvsjx9xzjasFzfVgIP4wJwk 3T8J60cALBBMqIz744RXbO1Kx3A932APvs36ncj9b/dZZ2cjOcX9RHVZhr/H5zbkUewKHW UCTi5GnNlbyuohrQVURMiy31ShWwKIM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OoHTqS2c; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of rientjes@google.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723407829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QuYp6e/IcFOWO1Lvs+4x5nSa6kYnIOk0v8u1g+wL6ko=; b=hDFXyEW2sTDxnjFTdHqLryXfLNvoHFEUyfKg0M3Y2AIorjDcSs9jujIyoRVOixkpookdhh m8Gtc/vC38ziXFy/bBTev0pWWddIHOyhb0kXimvT5qOPBVks37IgPw56pSJbv3t6PRbbZT XcGRCbqJF9UDXKLo2bxEuKJaILJrbhk= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1fed726aefcso175015ad.1 for ; Sun, 11 Aug 2024 13:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723407879; x=1724012679; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=QuYp6e/IcFOWO1Lvs+4x5nSa6kYnIOk0v8u1g+wL6ko=; b=OoHTqS2cjMgehdAzxwT9mrvpGkfYzYSHrQF8eo7er2B2fFeX/RdNiYUf0MHYQqGs5T IGjg+f64BXtwURabGZ7PjnL70zrltQB0EUXN0DBwG3NqzDoWNiS1kQEnQr4loYMjO4KX kJCphx64LGixX2aU9I8OAx3PnZkhBaDTBdI3/LQFQmy8hKePcGwK9QcKPEBAtbQ/PAWv lzCd3oL4Pr2TcwGwhAKpAJIcNEZ9zBkBTnr6Gh4aWLoOFQ50Tq/1rXw5w/QtVk8GnWsN Xvw2/hhUfeiEju5rjjtEgacmZ9gusjmSv4UscRK+NcY8F2KxNvMS5jCAxgkFbI5jH+rO Cgig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723407879; x=1724012679; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QuYp6e/IcFOWO1Lvs+4x5nSa6kYnIOk0v8u1g+wL6ko=; b=WgtYw/wXQnSXe8la/DVKHH3BoqsVfTZmqjtE5HPBYhBbOZ/TxAINa3/OaJ13sKEoG+ yJsSLWv4ndtPpONK+FFoc2BtFf1Ui1/D7ZECtCR7LQ5BmIslWyDLBMrCoc/cZNVAQE1T gdsfHiMas4WWFSZ/K6sveyvxPLBPHPAxhRFHyleJvYhPRIq6ZiOtkXDoXsaGIm4ENnuZ 2QLQzn9E7dnxZt7++CEvH6isXTWpAQXFYTNYJ30tTo+z5pVER1NF6sPoftuNeIjqll/W IpTDmzcSCN46U4bDsL8gBMD2jHy2IFCfVbvi1pG85CIaQwFzHlQNzZEf3SIjZraOpgXp nXNQ== X-Forwarded-Encrypted: i=1; AJvYcCVRTJFbV8tyUPAVgXX97WUHH8g/BhmBIHEkm2U8OmHRTOLOUbEjaICGLVt744txDyRTJQqyk9CbDORod7D/NJjXHcs= X-Gm-Message-State: AOJu0YzSPDYCAp+i05SzzRqqzoOyEBELCISSJW+Ryos5Aql5ofFn1IzT +dWP0HdT9KhZ5n1SslBGy1JJA9NSYd2xHi/E6Vs5xko/0/FEirgFtHTsPJZcmg== X-Google-Smtp-Source: AGHT+IFA63r/xxYc2IBbgbRXl9jp8YQNn3yBx5+fTkInBrjtUZ5WM9pYaba539QHJ3AIkKLBBdIiGg== X-Received: by 2002:a17:902:f54d:b0:1ff:1cf5:491b with SMTP id d9443c01a7336-200bb7e0202mr3505935ad.0.1723407878857; Sun, 11 Aug 2024 13:24:38 -0700 (PDT) Received: from [2620:0:1008:15:49ba:9fa:21c6:8a73] ([2620:0:1008:15:49ba:9fa:21c6:8a73]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710e5a8d462sm2709760b3a.169.2024.08.11.13.24.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Aug 2024 13:24:37 -0700 (PDT) Date: Sun, 11 Aug 2024 13:24:37 -0700 (PDT) From: David Rientjes To: Pasha Tatashin cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, david@redhat.com, yosryahmed@google.com Subject: Re: [PATCH v5 2/3] mm: add system wide stats items category In-Reply-To: <20240809191020.1142142-3-pasha.tatashin@soleen.com> Message-ID: References: <20240809191020.1142142-1-pasha.tatashin@soleen.com> <20240809191020.1142142-3-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 707B11C000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 6za1zgi4dob7ixksihs6nadew8xqyxga X-HE-Tag: 1723407880-509644 X-HE-Meta: U2FsdGVkX19CgHrvgTc1E972DUrfNYqX/JNty3beExY30sHG51lgVrKp4U94ADwh0z4YAYvGM/1sWPMsKVc3NifY3ZJCadJv52uvg9dWaXjDavXcciINRRiTClI09kenBWX5RXdEhjTZ6dZ36Ha93OrVc7TbdjoVakM+Y+bFKzhvJHnuhUXBgJ0A8gMFuhkNFUDO+apv+uFJxaEVBNvSINcr9zqLcSqa4imfeFcoo6r01dY4ZhAoN197XzR359roQo+T5EkY4jL1NkmvKj9zrAAhY2KmftYopUFZoTiyFce3i89AVeaqxbl5d9q2lIJx5kz2IW581qU/CXS6DJyaXNtb4pDLKsR98z2rbzlfto6DIwpYkUoLe+T/RGC+B6r9+jVZ6hQH4AyLhyO6z0XA2Xl3okZF4lEN4XZg22Q3ZYlXHMLUVJr21Pjly/QxW2StMpHgyWbL4HLjWVjdYFrMti+kNsNTKmpvFRUNOHsHv/YxIa8Ex3UfrdSuMQbxgii5wYbp5c59XCoiPvCU9Cv9hsPbZu4DOH5A6KBrUiu6VnwLtlYjSvvw2WehY1kbFwzkMHm4HaJECL2oMDXZBQ/kmtmqJmU+sOtrYWnPlwfID9t4E6mPny4Ex+r31DTnBUNRzT0vr79fv7zbKSXaa15WZnWeQ3qo5LCpn/vsZcSh6SsD3XuHpWIVVIll3v+ClZ1sGrlQk7aGhTEdgr/j1z+rhlH+PNN3TrC2HJXxdL5yrj1YdBg1whoelW25In8AEZCdmiLuc68xQgN8IAekShdejMRw2jMldManVdZrE9wOhv1jXiEjnv8CwprpFMo5TTwKFCqKADVQ3Ya+m7dFmLOLgQfjun0w0AEJSzF7MfAOhL6KTFKmUGrOl69ejncZ9mM8vcjdom6K/AQ4aFXCuMSxkoT7QCohJHHJtJ1zM+id9MNaVPmnqq8HLd6P7PyrqeJEAuJhOlsXOTvntF4DCU8 s2/t/dcP mEsRJdgxTxz6pCPrYKdWsldRkbDJ5CdBbDb4ZQdG9gEtzJIc/vX7uXner2Xn2K33zad/7Eww8kfxtXriLW1udhSW0YuNEtJSO6GFpWePy5loofqB0trlXjx/exrFgEiCpPyDvnYcLN+UMVcR/F+fc6eGk0PbV+p1CYyfjUSgJH6G1mlMwJrxn+vZOze70JCvNl1Ws39SEbLBNoytASsDreYJ29UWDMweUFyMrrHi8ybYHe74cAO5P5r9+MoV3Bpx48H7OadM0SPPLqFd7yivgZrLRoMjL/S38mprb6NajK18rjMQNoVynNvi+apK6kq8pI3ws586cvYUA4jNF/GYYXgnKUQXddlAhj5sgWC7znSgougiskIJTL9W1302AwJReUEe5hIHwKSUA4XV+0u4Q7nIi3EMOgGk0BsIz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000888, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 9 Aug 2024, Pasha Tatashin wrote: > /proc/vmstat contains events and stats, events can only grow, but stats > can grow and shrink. > > vmstat has the following: > ------------------------- > NR_VM_ZONE_STAT_ITEMS: per-zone stats > NR_VM_NUMA_EVENT_ITEMS: per-numa events > NR_VM_NODE_STAT_ITEMS: per-numa stats > NR_VM_WRITEBACK_STAT_ITEMS: system-wide background-writeback and > dirty-throttling tresholds. > NR_VM_EVENT_ITEMS: system-wide events > ------------------------- > > Rename NR_VM_WRITEBACK_STAT_ITEMS to NR_VM_STAT_ITEMS, to track the > system-wide stats, we are going to add per-page metadata stats to this > category in the next patch. > > Also delete unused writeback_stat_name() function. > > Suggested-by: Yosry Ahmed > Signed-off-by: Pasha Tatashin > Acked-by: David Hildenbrand Acked-by: David Rientjes