From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D29EBC47DDF for ; Tue, 30 Jan 2024 09:25:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 602DB6B009B; Tue, 30 Jan 2024 04:25:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B3DB6B009C; Tue, 30 Jan 2024 04:25:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47B7F6B00A0; Tue, 30 Jan 2024 04:25:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3619E6B009B for ; Tue, 30 Jan 2024 04:25:54 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EB2421A07D8 for ; Tue, 30 Jan 2024 09:25:53 +0000 (UTC) X-FDA: 81735445386.26.5504A1D Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf08.hostedemail.com (Postfix) with ESMTP id E3F4B160013 for ; Tue, 30 Jan 2024 09:25:51 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=usqM2Erd; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706606752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RSk7it6b1JMh823m6ptl66Jh5MU45iWziHAMy2DNJmA=; b=GjbYy3gmnAMhZOdVnQuDS4AaL7FfXYJ4wJAY8BvHPk+XbbV5c/3LYe1JDlYnVMON2EkXwR CkF4uUdfh+ChDuQK5xA1GlGv8bbPTiTadEoFFZor7HguZNmrS3GVYoVM3hsGHW3TA13jek LIp5NhFaATSPj217txcj/EwRdueQbcA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=usqM2Erd; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706606752; a=rsa-sha256; cv=none; b=W10r+2JabjTjYFN7UM0sIcbxFXPP/VIypHY0l0CLfrybOnfCFPrHwLc4lb7Vok9v8LkW1h zUUY+gITVJv7QivO8kG0wGfhExL8I/Y9qT74nZHiHsYNbG71SxZj0tA8Nzy+dnBeXDoKF6 Fc4iI6zn5bJPytSOOUMLDEHCn44JHvY= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1706606749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RSk7it6b1JMh823m6ptl66Jh5MU45iWziHAMy2DNJmA=; b=usqM2Erdea00X8HzNmACoAbCZnm5HDokXtXhSQv93VoOKGqRQmjhulO7Qm5tXIJioBb77K X/au/eifMwJTdv6qjZiGAQ/vGDjqQZnXf4koQw7QhnQx9yEuRve1G1dMB4z5SOo1P9M4ox 02JkUv6XSszcfGxXCzoq/Dmmi6Y6A0U= Date: Tue, 30 Jan 2024 17:25:41 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] mm/mmap: use SZ_{8M, 128M} helper macro Content-Language: en-US To: Mike Rapoport Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240126085905.2835513-1-yajun.deng@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yajun Deng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: E3F4B160013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 4k3zxwweu9twwe9skkbsfxih5q3eosaf X-HE-Tag: 1706606751-764182 X-HE-Meta: U2FsdGVkX1+XLDdr+K5LltsAD2yhrEtZxWcScrl9JF+gqZI9BaXKnry9KeWOosR6kzrcCx6HvKmNFHM4+GgV/TnyqV81lcsstIW7d3XU4eZ2Vw99iK1MLdlI23r/F6MyZF4P9W5gaA14+Zn+cQO1Q/PCehyMpiFAk0Fr5NYVbWtDaaVe+Rc3L98CZ1iL/FPfyl4lEbr8/cxeZpiHZVf0OlJRsPLztlHPv+I773ltil1Ot5athaHk8AgIK8/blw1uFCr1pGni+XQEG8FzcZYSwBmETsTJpxwWYHHw2y95VUNh6BByPfAOhDsl12V8jrOZPUf8GI2jsnvyoIagVGOUv0sRWnQgwgNptwT2GG1WqIQW7/UKOcilCfodEto1k98hsTF6ScLbBgU9o68bjkZ/FMZdCgNCOjfr84NkqMmt3qagofusKj7XqmOhWwL6lm7tMoUP3XNQS6Waz6CyOviW0cCc5jD8CAFDStClhowB67tIDfC4dq9M10xDTpHEUnbHrpNfYz3yOWoU37IVGoLXAqzzeFIxJ0P1cxaXZ3sMTWcvBz97vgbABhERM61Y6CdnT4fVOy9zPQwQzZlxiekHQyQ1Yawvyujh3xnJyQQjDU4PH11ZV62kb3412tRvFb7XoQFyQ1+ztz1YoCXOdikzCGvlODeLCYMzDsgcIs50JhShU1Z7xnVCVTffH6UZv6WbCxCsc/otCoN4+tDwcn2So6AgCOMCjcwSBrFzk2j1HB9b/AjkfpP7XmB5w555uDYb0DBCV8EtCE0m6l6vPOOGC2Xqo53TrNrIFO8er9QEfUwIxlM5oggs9aQGbZcDbU1UmiIX7376Iicb9fZ8QUow12vEG6Jd8gCVY2h86V2Sl66ubMmedX1cs/q536+k81nvfN0WtOEuP4A+Yb2mHTzzsCcE/UwJBCiyQ8AVHQJsJxvYU+H1TlacCKEMwrWv8HMo61I62I40r9fZzZ4JO6U s/Jmt5je LXDzz4Jx9ei6evBoyQ/fFXcHmxhh7wyE9KHHrvoxtHOVk5ES4y8EodTrhC+3GtwJc4B9uRLCRVhbVrKcG/DMqt+KOCZjdd/BwdTR4HbmBe36hDvge0KgyDA6dyYsIMMU8Hj0jg27ZvJCEQC4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/30 17:11, Mike Rapoport wrote: > On Fri, Jan 26, 2024 at 04:59:05PM +0800, Yajun Deng wrote: >> Use SZ_{8M, 128M} macro intead of the number in init_user_reserve and >> reserve_mem_notifier. >> >> Signed-off-by: Yajun Deng >> --- >> mm/mmap.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/mm/mmap.c b/mm/mmap.c >> index 476de5daf598..f90924b2a6d2 100644 >> --- a/mm/mmap.c >> +++ b/mm/mmap.c >> @@ -3845,7 +3845,7 @@ static int init_user_reserve(void) >> >> free_kbytes = K(global_zone_page_state(NR_FREE_PAGES)); >> >> - sysctl_user_reserve_kbytes = min(free_kbytes / 32, 1UL << 17); >> + sysctl_user_reserve_kbytes = min(free_kbytes / 32, SZ_128M); > (1UL << 17) != SZ_128M I am sorry for this, I didn't realize that the unit was kbyte. > >> return 0; >> } >> subsys_initcall(init_user_reserve); >> @@ -3866,7 +3866,7 @@ static int init_admin_reserve(void) >> >> free_kbytes = K(global_zone_page_state(NR_FREE_PAGES)); >> >> - sysctl_admin_reserve_kbytes = min(free_kbytes / 32, 1UL << 13); >> + sysctl_admin_reserve_kbytes = min(free_kbytes / 32, SZ_8M); >> return 0; >> } >> subsys_initcall(init_admin_reserve); >> @@ -3898,12 +3898,12 @@ static int reserve_mem_notifier(struct notifier_block *nb, >> case MEM_ONLINE: >> /* Default max is 128MB. Leave alone if modified by operator. */ >> tmp = sysctl_user_reserve_kbytes; >> - if (0 < tmp && tmp < (1UL << 17)) >> + if (tmp > 0 && tmp < SZ_128M) >> init_user_reserve(); >> >> /* Default max is 8MB. Leave alone if modified by operator. */ >> tmp = sysctl_admin_reserve_kbytes; >> - if (0 < tmp && tmp < (1UL << 13)) >> + if (tmp > 0 && tmp < SZ_8M) > (1UL << 13) != SZ_8M > >> init_admin_reserve(); >> >> break; >> -- >> 2.25.1 >> >>