From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6BDECE564 for ; Tue, 10 Sep 2024 14:18:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 359CC8D007B; Tue, 10 Sep 2024 10:18:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E1E48D0002; Tue, 10 Sep 2024 10:18:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1831B8D007B; Tue, 10 Sep 2024 10:18:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ECF8E8D0002 for ; Tue, 10 Sep 2024 10:18:20 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AA681404CD for ; Tue, 10 Sep 2024 14:18:20 +0000 (UTC) X-FDA: 82549033560.30.E9B5D3E Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf28.hostedemail.com (Postfix) with ESMTP id 74F14C000C for ; Tue, 10 Sep 2024 14:18:17 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725977871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bfRl/RDnxg7GCn71/1feVyrBf8FVtbdeFOC6IiT1dO0=; b=jMlobgwf/NnQS9zDTAwsMQvlEjXF6mlpwaUtqUZxStoHMWQybSPecFTM1dpeqTlhcVrerB 1Dn2DUE9ZpLPO+K31yHYWgRIUqe5ZXTWiCgeNYO/0P8BjtUWHy0Oppu7nCCR8HWdGHgz5l QVaxlcKnvTDaCeaZxvHvI/DDYS1PBqo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725977871; a=rsa-sha256; cv=none; b=Art6pgo6ARnxGequYO7tzCEIjCtPCGnsFgeE3QgFWxCEUJOWL4kmnES2/uaswooSTCxH+Y CfUaha+kBGqBS7VMPINJB9DTXKxdT3jcsJ1cQf0OUBznQLTmm1ouHIOSQEVuYKVA67C8dA 6lw4SfgaLOp4rk+RW0mvOGFSwi8zuwE= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4X35QS0R1tz20nn1; Tue, 10 Sep 2024 22:18:08 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 1BAF11A016C; Tue, 10 Sep 2024 22:18:13 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 10 Sep 2024 22:18:12 +0800 Message-ID: Date: Tue, 10 Sep 2024 22:18:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: set hugepage to false when anon mthp allocation Content-Language: en-US To: Andrew Morton CC: Ryan Roberts , David Hildenbrand , , Barry Song , Hugh Dickins , References: <20240910140625.175700-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: <20240910140625.175700-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Stat-Signature: 7t4wz3fwqzgfgpf3k3z148ewy5zfa7jr X-Rspamd-Queue-Id: 74F14C000C X-Rspamd-Server: rspam11 X-HE-Tag: 1725977897-198853 X-HE-Meta: U2FsdGVkX1/LDFnIGLJ9jQvF7lKWAtvshFWgVOUhtzVIwCrxLOo5PICn+5XJMZmlRWEHPgH/sl5CRxcpdIDolwolJhL72WGiFxMAY+OLQhcb6vZ8LJYeB53xv1vBMSCBsWHj0393hIlUCtsAjqHDN6xOTlZK+w7KowEgaS21U21tZPkAWCL++MH8J5cohqvLBx2Fw1pb4AiuHaxJK2Ig5cBEdYIEq/VQsxuG4a1hZoKJxq6ROp6IuUezHf0M2UObEh4IScMSw3ls0knqLZyPZymoUN5F1TeVom5NerJEXOTRzTdCjIRaVG42EdCOnuQ87/R456+q1+9pRz9M8zc2w2l3mTTvfekvLF3o/DeKGKAMpOz1w1mAQbuFl5gHvLa6uY57AORz4u3teDKJUaQU8pwWi4IyFwfDLQfqdTSzGTnF66a8s51jl/WDDCG+JZ1l/XM/G4Gcp9IYBuKsF/GGVnENeViE87MKtuBN9SPJYZlQV3r6pm5ci8jr4vNv8PKBtH4cAJK2/sNX2/eLGVYuPMwxU7adBnOhppbk1qZc2giLrHLmwehLyvH80kdB/8SDs6a2YnqBhXMfffZ5WNA1Hsj2m8nvO04V14gVPHxRhrM6x2yHan1FABa6bPQF5ZSE7iwMdmJFYPhoLAs91ZoL37SrF5WYpVR2vr6p6sbrov6nrngeWoKDYUr/YJAp6qnhZXtfEvhBJ337SckhHR81pnUPKMGPwfZbju4v+DGW8xfOS/ZXo4x7/cZH5sc9lgxXFXHjJ3CtK1JqZ892NVbuoag7DKX6PDUSzjnIkzzPe9cmv869WXdfBoioDlynQJ/WfEHUgbUUH1JNMcUkYHZe/xCsYvm2kketVFr0fAGgdcAYoZQ67dDOduvqYd+KFvEV00LMADZCelpvLaM+Yddgh4OFsMso4onw1ZHJE5JepKIpYEPL6VoJIYZJT1vyPgME/8xnwck/Mv/OXyXeU8r stLPBbny TEc9hBLO84NIqdFiCEUPCrvrQ/p18r8fbp2XUGf261bCdun/Vb/7IQZFJBGzisR0gX8gcTeWS5hgpGLIfBmGQ/0B9RZxzh8HNmgN8tzs1InV4qebZYynANmL6acAerriZWEncNpDHslW8veuc+viLOyhZftLhoghJkjXsWpWXeugc9g2Mmrt+6bJDyZjIyVfHmVCc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/10 22:06, Kefeng Wang wrote: > When the hugepage parameter is true in vma_alloc_folio(), it indicates > that we only try allocation on preferred node if possible for PMD_ORDER, Should remove "for PMD_ORDER", I mean that it was used for PMD_ORDER, but for other high-order, it will reduce the success rate of allocation if without ddc1a5cbc05d. > but it could lead to lots of failures for large folio allocation, > luckily the hugepage parameter was deprecated since commit ddc1a5cbc05d > ("mempolicy: alloc_pages_mpol() for NUMA policy without vma"), so no > effect on runtime behavior. > > Signed-off-by: Kefeng Wang > --- > > Found the issue when backport mthp to inner kernel without ddc1a5cbc05d, > but for mainline, there is no issue, no clue why hugepage parameter was > retained, maybe just kill the parameter for mainline? > > mm/memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory.c b/mm/memory.c > index b84443e689a8..89a15858348a 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4479,7 +4479,7 @@ static struct folio *alloc_anon_folio(struct vm_fault *vmf) > gfp = vma_thp_gfp_mask(vma); > while (orders) { > addr = ALIGN_DOWN(vmf->address, PAGE_SIZE << order); > - folio = vma_alloc_folio(gfp, order, vma, addr, true); > + folio = vma_alloc_folio(gfp, order, vma, addr, false); > if (folio) { > if (mem_cgroup_charge(folio, vma->vm_mm, gfp)) { > count_mthp_stat(order, MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE);