From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22B8C4167B for ; Wed, 6 Dec 2023 14:59:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 382006B0085; Wed, 6 Dec 2023 09:59:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 331736B0087; Wed, 6 Dec 2023 09:59:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D1E76B0088; Wed, 6 Dec 2023 09:59:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0D79A6B0085 for ; Wed, 6 Dec 2023 09:59:39 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CEE06C0126 for ; Wed, 6 Dec 2023 14:59:38 +0000 (UTC) X-FDA: 81536702436.03.C99DB5E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf06.hostedemail.com (Postfix) with ESMTP id 4C10918000C for ; Wed, 6 Dec 2023 14:59:36 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701874776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R1at7IyG8DjqPaac4gu5ja/Ia1siWXS2Vu3m1SIFNNg=; b=rMs69smLTSUFps27VyynpMmpfW8PG+/PH+Hsz3yr0mB9mXmA04km7twmqJm2rsDbDm/1I7 TOFzv7Nnuq6jL399rwcXEDaCqmpu5AA18+J7knDy4d9uU8lubr0EIUNco6FR/BjLSXMHSA m+Ge3fplLOZe33G6uNK/w4GbEhHj1LY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701874776; a=rsa-sha256; cv=none; b=ObLB4Un/+WfSVFlb4iL6EtLWnyg0mWkd5YanhPkYaLiFF/TjcIbNHITPsx83mPVXFe37Tp fVq3A+oiNtCmZsTD7d/0ThO9HxZ8g3WequJpSGp6iqvsXb7/BKdwVcLnuFgAh4uArI1l3k QUflWqvkHS6eIu2VpgyxNHcrBiRSaco= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2472F21E31; Wed, 6 Dec 2023 14:59:34 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F01D2136CD; Wed, 6 Dec 2023 14:59:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Z+zDOVWMcGXmQgAAD6G6ig (envelope-from ); Wed, 06 Dec 2023 14:59:33 +0000 Message-ID: Date: Wed, 6 Dec 2023 15:59:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" Content-Language: en-US To: Kees Cook Cc: "Song, Xiongwei" , "sxwjean@me.com" , "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>, "cl@linux.com" , "linux-mm@kvack.org" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "roman.gushchin@linux.dev" , "corbet@lwn.net" , "arnd@arndb.de" , "akpm@linux-foundation.org" , "gregkh@linuxfoundation.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20231201031505.286117-1-sxwjean@me.com> <20231201031505.286117-3-sxwjean@me.com> <202312010945.7C5DB1FBB@keescook> <67b155dd-3731-489e-c3bd-333cb7e90801@suse.cz> <202312021329.86D56FA@keescook> From: Vlastimil Babka In-Reply-To: <202312021329.86D56FA@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: ++++++++++ X-Rspam-User: X-Stat-Signature: s5fj7j5pej3g99bunny8ipcr47oamxfn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4C10918000C X-HE-Tag: 1701874776-506823 X-HE-Meta: U2FsdGVkX19PN95FdT3RTZ7P9KSMVLSqUkTYrr0gS/oXuLyieokpeyFuAvKi5OiGJAmM3xwYNFalFNrxNNLayDMuuuYc8ibuGXOuRTun4SgRpWPmDzP2BlcOdQDLyOUvDuSCuUb6B/7JL2FOJTUjH00l5hFjvDeQZ0dyp0lZUmT37wY8diuw47cpHjJVgEP75J1IVRMlk/XReOlVRczyoedTwo0DYfY7hqH3VVqXW+57slLBBKiB6cp6YZ74T242vUZKsR2irOddpRss7GeNgEuDW9SJW3RHg8luFNN3hiP2NYyCu6fkLTbmjX0X+1RnpVSwUVudr/7rRIcCQgnoaug6AbZpUicKcUffJixBIL3W47FmmaXokonw/gPA+ZziGznSEXcly2PjpSxXhZHlhsJ6uLjbgIOEVsahHqc2SLxItthpYcHOV0FS6tGAxG9QsZtPGQUeXvMCw6rY7YI1wvw5yyUKMX5CP8JxWgeufKmn+akBh97QnwLOSK3aHYxzSUqgGwR2Fqe4RSH2b5hIoADtLrvG4hX5nZqBviw9ZGQYhfLhg/OtiWc76D3yEsta+439BrLEe/d6S4CmiDFiXpTfrovzHx9EoKwFn+I9LBF3TVNQFIMwxhG7KONMhHd8T/Cq/8H5E7+AHKClms7wewj+3j2rB906xDUtgGDGaI9zGo8G3scrji3AoSG0Ac8O0O8ff8nEQZx28/zgIClHkvsUBxEZdfbCUg36+l4v62MQrWDUcU2MHR3uVLHyBLaTys1j67T11hzzcZ+h+yLHyxsEkdyChk0k6fqgmAwgL05BMzYZb+mz3TBXQcq6sqNKh42C45yzGFTO6dqiUcU34IraVjlBi/IzDaeDXi5clJc7ituc3wa1NLiGOtDuW0Hu1ZjXGjJpoy/90zdFfSfthu7T18NlbykZUaVP4ZLme/kaI1e81QvLfiITQ0cL0YqTa3dNfyRXCdjFuwnMPhp Ws4fvSo8 1woN9bP5hPeN6OtrU4FAtdHgi+mJ8WTZcVs+/ooXAGt1V0ZwjZ7fNzUuXBwuKs2ezOF1t7yWS8bmuGdc8TkQQaIehMw9RhE9FUKuShqpNkFbjJZ8XflTbz2VIJxh1gZ16NhHBWmxxhueoVC5GTr/9ZfOpbYoekfho2qUZW8hjdmJ276bhv0uWB6GgvlfeUUQn/Zebbklv/UxSPGotDVLzUNjio+bS5ZJ4g1VU5Z2XGJXx/+uRVDzSXSpeCsDXY0d3ow4NG297bHOEykEbQzrCyuxRMthoYgjXN5gMQGWzrpdlKSJTRP7QaK9mHHQ7NQJXYQhY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/2/23 22:30, Kees Cook wrote: > On Sat, Dec 02, 2023 at 07:12:25PM +0100, Vlastimil Babka wrote: >> On 12/2/23 05:23, Song, Xiongwei wrote: >> > >> > >> >> Yes, they are already recognized by the patch. > > Ah, sorry, I missed that. I didn't see it when I skimmed earlier. > >> >> with a boot pr_warn() about their deprecation/renaming for several >> >> releases (likely across LTSes). I think it's not a good idea to >> >> wholesale rename these with no warning. That's going to cause a lot of >> >> surprises and broken userspace... >> > >> > Oh, yes, that's a good idea. Will update. >> >> I'd wait for a while with the warnings, no need to rush. > > Better to start ASAP, yeah? I find it a bit obnoxious to accept the slub_* names in one kernel release and immediately warn in the next one. I'd let the people who read the news/docs adjust on their own first :) After all, we wouldn't be warning about something that's dangerous if not acted upon immediately, or something.