From: Vlastimil Babka <vbabka@suse.cz>
To: Kees Cook <keescook@chromium.org>
Cc: "Song, Xiongwei" <Xiongwei.Song@windriver.com>,
"sxwjean@me.com" <sxwjean@me.com>,
"42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>,
"cl@linux.com" <cl@linux.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"penberg@kernel.org" <penberg@kernel.org>,
"rientjes@google.com" <rientjes@google.com>,
"iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
"roman.gushchin@linux.dev" <roman.gushchin@linux.dev>,
"corbet@lwn.net" <corbet@lwn.net>,
"arnd@arndb.de" <arnd@arndb.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param"
Date: Wed, 6 Dec 2023 15:59:33 +0100 [thread overview]
Message-ID: <d5dff423-40a1-3789-e5ba-68e6c0ab6130@suse.cz> (raw)
In-Reply-To: <202312021329.86D56FA@keescook>
On 12/2/23 22:30, Kees Cook wrote:
> On Sat, Dec 02, 2023 at 07:12:25PM +0100, Vlastimil Babka wrote:
>> On 12/2/23 05:23, Song, Xiongwei wrote:
>> >
>> >
>>
>> Yes, they are already recognized by the patch.
>
> Ah, sorry, I missed that. I didn't see it when I skimmed earlier.
>
>> >> with a boot pr_warn() about their deprecation/renaming for several
>> >> releases (likely across LTSes). I think it's not a good idea to
>> >> wholesale rename these with no warning. That's going to cause a lot of
>> >> surprises and broken userspace...
>> >
>> > Oh, yes, that's a good idea. Will update.
>>
>> I'd wait for a while with the warnings, no need to rush.
>
> Better to start ASAP, yeah?
I find it a bit obnoxious to accept the slub_* names in one kernel release
and immediately warn in the next one. I'd let the people who read the
news/docs adjust on their own first :) After all, we wouldn't be warning
about something that's dangerous if not acted upon immediately, or something.
next prev parent reply other threads:[~2023-12-06 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 3:15 [PATCH 0/3] supplyment of slab allocator removal sxwjean
2023-12-01 3:15 ` [PATCH 1/3] Documentation: kernel-parameters: remove noaliencache sxwjean
2023-12-01 17:45 ` Kees Cook
2023-12-01 3:15 ` [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" sxwjean
2023-12-01 17:47 ` Kees Cook
2023-12-02 4:23 ` Song, Xiongwei
2023-12-02 18:12 ` Vlastimil Babka
2023-12-02 21:30 ` Kees Cook
2023-12-06 14:59 ` Vlastimil Babka [this message]
2023-12-01 3:15 ` [PATCH 3/3] mm/slub: correct the default value of slub_min_objects in doc sxwjean
2023-12-01 17:50 ` Kees Cook
2023-12-02 4:22 ` Song, Xiongwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5dff423-40a1-3789-e5ba-68e6c0ab6130@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=Xiongwei.Song@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=sxwjean@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox