From: John Hubbard <jhubbard@nvidia.com>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: Ira Weiny <ira.weiny@intel.com>, <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Dan Williams <dan.j.williams@intel.com>,
Matthew Wilcox <willy@infradead.org>,
Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>,
Keith Busch <keith.busch@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast()
Date: Fri, 31 May 2019 10:05:45 -0700 [thread overview]
Message-ID: <d5dde9e8-3628-850e-f2b2-73c08098a094@nvidia.com> (raw)
In-Reply-To: <CAFgQCTtVcmLUdua_nFwif_TbzeX5wp31GfTpL6CWmXXviYYLyw@mail.gmail.com>
On 5/31/19 4:05 AM, Pingfan Liu wrote:
> On Fri, May 31, 2019 at 7:21 AM John Hubbard <jhubbard@nvidia.com> wrote:
>> On 5/30/19 2:47 PM, Ira Weiny wrote:
>>> On Thu, May 30, 2019 at 06:54:04AM +0800, Pingfan Liu wrote:
>> [...]
>> Rather lightly tested...I've compile-tested with CONFIG_CMA and !CONFIG_CMA,
>> and boot tested with CONFIG_CMA, but could use a second set of eyes on whether
>> I've added any off-by-one errors, or worse. :)
>>
> Do you mind I send V2 based on your above patch? Anyway, it is a simple bug fix.
>
Sure, that's why I sent it. :) Note that Ira also recommended splitting the
"nr --> nr_pinned" renaming into a separate patch.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2019-05-31 17:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 22:54 Pingfan Liu
2019-05-30 21:47 ` Ira Weiny
2019-05-30 23:21 ` John Hubbard
2019-05-30 23:53 ` Ira Weiny
2019-05-31 10:40 ` Pingfan Liu
2019-05-31 11:05 ` Pingfan Liu
2019-05-31 17:05 ` John Hubbard [this message]
2019-06-03 4:06 ` Pingfan Liu
2019-05-31 17:13 ` Ira Weiny
2019-06-03 4:05 ` Pingfan Liu
2019-05-31 10:29 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5dde9e8-3628-850e-f2b2-73c08098a094@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=keith.busch@intel.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox