From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED19E7717F for ; Tue, 17 Dec 2024 09:11:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F35B06B00A9; Tue, 17 Dec 2024 04:11:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE55E6B00B5; Tue, 17 Dec 2024 04:11:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D37426B00C5; Tue, 17 Dec 2024 04:11:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B3CE56B00A9 for ; Tue, 17 Dec 2024 04:11:06 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 62AECA0544 for ; Tue, 17 Dec 2024 09:11:06 +0000 (UTC) X-FDA: 82903880304.03.77FBFB6 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf27.hostedemail.com (Postfix) with ESMTP id 6346640002 for ; Tue, 17 Dec 2024 09:10:30 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="CYfEyj/a"; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734426650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C5VM3n7hNnnRBQt5LbKkQaziwSOAI765RsqifvciV4M=; b=Is7oMULlxFbLDAafcCm67E8WDtBX9i8aE7E3VrHYYTUPYxxgLcYEqOeXn59k+UsnF+9lm2 +AYv5Mvy+2x/GNVaazkrJGrvKc1hnE5wxpw3pdvpi3psUO7ALBJJbEwx4eZOqO4KrtAEBI cT0Rr6sP6WKxiHGAx7T8zLmBucuSy2A= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="CYfEyj/a"; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734426650; a=rsa-sha256; cv=none; b=ieQEbEwA9rZjTE1UQc8QSmcv408+cqARNOxZ4cqah4nML3YU6/3AR68jKh6vURdP5wxZ+/ NHtMruLoEoJEEUpJAl3f7Rljnl/RCGCz+bZWb93eRMTaa18prwDAO41kAGv1LskGjVSUaG XXHQcBMGsYV6OqMLqyRG3X5Ju9EzWuI= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2167141dfa1so41465155ad.1 for ; Tue, 17 Dec 2024 01:11:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1734426663; x=1735031463; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C5VM3n7hNnnRBQt5LbKkQaziwSOAI765RsqifvciV4M=; b=CYfEyj/aoBx1xq4IWPdfw29CUsq9ojn5Mm/QGMCbSorIj3Yq0u6lELZdH+b8WEpDmf 4V5LARvb3a8hxNQM1xT81W1yZ1yZX2aZC8QqMAbAy85jSrOxo/RLkl/quMdKzNrVUmHC iR4EgPVuCtu3apYp7nL88WChiIYuioa8MMW9UXnb4ZWVi/RTblyS5qMHwZ63J0riPU14 De7CJBSlWyWDQqsnqWcnXQSMP1s5GsfbgWwsah8QIj0MzIs8sOq/Nqi7+LmqAmIgaKr8 53Am5DYPn+gx7WFuTsz0IqSoIQ1mL/tMoPIu3GDYb40ae4UnmC9jff6d0y7J+chXuSN2 asMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734426663; x=1735031463; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C5VM3n7hNnnRBQt5LbKkQaziwSOAI765RsqifvciV4M=; b=HJzZVM+pc5RpiZbO4vF9ji91NiAStHIeKSm9JjIU3KZ0OtBSo0xAJNBCIkicPbwNqc xJYRecyaYK5BfH7e4NkvoNziClick2Cg4hKL1RkPYZvLTdKd2MvjtwsOxWBST67C5/mR quyyGeb/EMHNAcSBiw7QzUgI+DiboDf+8X3dCp5fRogYLserOrZ/lDZCY5w7xjN0WhLT b2OFf+azppekBTyBvSEaR89PwIG+gpK1SkZs5Eoe5InIY+JFGGsUxi0kB7KISJS+PZlT ekvaYUTuTnGUJDDKnrTDr+P7jshAAnyXoPiBoCfBRJL3Wme7S21T49b2hAQIlF3SS/6f lZFw== X-Forwarded-Encrypted: i=1; AJvYcCVGNK/30r6d2lam1McfKoIYtlxim1MQS+vzZhHs+Ua8gmCtQuLKs0oNAQS2F3UTcumV5iQS9UZYNQ==@kvack.org X-Gm-Message-State: AOJu0YztBM4xUlrCSFygHBjjp/hKIeB7wHP02LM+D7XZJu42oXBntDz1 1k+4dUwcd5oLcpBMHK0yEDLbQs3oyVF7Ze9WTWa7XUV/YIQX1jCIwb3apporPXc= X-Gm-Gg: ASbGncvX2vvpO+V8UUbleZNOIPFTlBJ9qc3c38m0EFcaY9MpGNKTXVNDilJqZ745Q1X kZklk5dPZQCsHiV8o9DojCCYD56mOzgsUZQ1gWeT/Pdu/GGf+NU/TXNKVVByulpvsV+rAunLwUZ U8ZVxhe3PaGMSkKUyPbVyjsO+dA3l6bSEHHmGXMFXpDaoMo5daudDqWpnEOQ/jkbgs9ZyOeVaiP rnweNsy/riIHxfDsv23K+ecUt+6im/NRMVjGHzxO1lPJ0PwFcbNY8lIXSoVFwUfj8TG9JI6k1Yl mmhAVA== X-Google-Smtp-Source: AGHT+IETGzZ3WKNiQdZbK8zpOJPBRPKIILb1zdFxy2//Eni/fk83RoZCauwq0oscGqj2wg6cWLgygw== X-Received: by 2002:a17:902:d4d0:b0:215:9c06:272a with SMTP id d9443c01a7336-218c9368bcbmr29948595ad.24.1734426662716; Tue, 17 Dec 2024 01:11:02 -0800 (PST) Received: from [10.4.194.102] ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e5011bsm55183435ad.152.2024.12.17.01.10.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2024 01:11:02 -0800 (PST) Message-ID: Date: Tue, 17 Dec 2024 17:10:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/12] mm: pgtable: introduce generic __tlb_remove_table() Content-Language: en-US To: Peter Zijlstra Cc: Vishal Moola , tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <271e58cd4ab808c4f402539b76d5916924e2bc6f.1734164094.git.zhengqi.arch@bytedance.com> <20241216120043.GA11133@noisy.programming.kicks-ass.net> <20241216181225.GB11133@noisy.programming.kicks-ass.net> <6666f651-2a59-40fb-b984-60669d4fdaa2@bytedance.com> <20241217090222.GJ35539@noisy.programming.kicks-ass.net> From: Qi Zheng In-Reply-To: <20241217090222.GJ35539@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6346640002 X-Stat-Signature: wuxthzg16angkto5xxe4sxs4mrswiryg X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734426630-158047 X-HE-Meta: U2FsdGVkX18koYYLRLssWnqwss7bKqOrCLxkQg0sOUpbfsb8hFT/Apxs9TQwKNC7vWwNC8Osy9s3IwwPmbS3OvRoYD0cizwOtKJKaHheSpCYngb79R4JQofHpGaf+KUZq3thVp68RjJ6i27OcKu1MJ0aa1yiY5gunbFdc3Tz5eQrngtxjlZwNqP/zqpwwzsHYIyJ8Y6GJU/u2+yKYJEeScOL1FHtCsSgNWp+RcLitTWMny5cUHPfJaCz9aZNXSXGQlKDAGqZAMxR3AXimX3UxXV7sH93Zej1SOGJDkUng1nIEHjqcsqYcBfxbn4sGvKPaPK0YLed8NiF3h/yQE1t9Y8zZG6s7yKfQABn1O/0cY089JictzTvyQlI2vQW3UFlYrR1q4jQogh9RHITVGo6FyUh4r+1k8XtfwX9mcLm5yit7FpWen2wFoZo8gLWbpPUxP/RMswqymugilk6oPcj78jXvhNrgmeRzKDXIS/GvCfskNC4yPx6N87NGRqJRZWlNU/0B6169TEXMZ8maVYLlx7gCyuqXjWSX8DHloq0pBF3GG6/T0uttMnDn7pmnHlUs+Oc1Wod9aASvA5vDldQpM1oAUJad3IOZ60kGe3O/bKZ9xMUIkU1GK39uyjiqWDgsV5ksj6pQKG5j+cAt8D0Fw/8ix3yQCnkeheCIxLuuIIySr8LZLuN1epRAjljCF8s7AQe/CUNJUmVBbgTQQmb7LH44V6LgS0dPaWkNQryBXQPTA479XSmy06SDtyE/HsUbTohuQUUhu6LZ1J74GYBvZ7a+vqa9fNtKZNc3x15lP42wTLRVXYfV8DT8aLK2toM9vTqyuWLJicAZUdWUHmWsFVVP9PnpUxaXgXv+aTyz0jC6ol8tdw/UE21K7crLhrC8BgK+jrMvXeCPrH/jNuCSbN1UUn6okmpgcGw3SYfU6l7zHIlZET878KHjuty9y2i0mVwCO0J5Yl14ZYmui0 527dhGgJ ZgnUudmvpjoyql/R47zg+7uNcNl5qWQBAC0DS0EX5zZPP4CI6R/yzS0czOCXn9qzJAJcMB+gCyxQcbZGU8a2bSZsoi8dxf0MaSFm7vD0W4tU09eFwkiFvSD20vawVC6LMlqxiYRTlj+Tc6Oofq3qTbPCoKY9K6PzMa0piPAA5zyvPzSFi27vEGJg4f0l70QFUiDEAQ1BIiovVjgUcj2Foa2rntHirmaUbP2b999Fd3bwwNJyEtht8cTp+xHIvTsjln9dRsIq3iGjWsQWqgtK7lZu47JTcLS1BBekzm+ovFUg98Wf+DpZFEsSZOnWSFZ+dSnBNky2q1ZU/rz4N7mw/+73E8VzULIgFZWfZvy7alU+E3k/OVQWa0vTx8OBpf++RwWSB8cI5zmR8YhIUM/X3gra62NvY6hUCt4mQXB0Pm5WISI0osZuycCDr+U2MyplGPMlIfjT6pASUEr4= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.480937, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/17 17:02, Peter Zijlstra wrote: > On Tue, Dec 17, 2024 at 11:42:02AM +0800, Qi Zheng wrote: >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 497035a78849b..11829860ec05e 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -3064,6 +3064,14 @@ static inline void pagetable_dtor(struct ptdesc >> *ptdesc) >> lruvec_stat_sub_folio(folio, NR_PAGETABLE); >> } >> >> +static inline void pagetable_dtor_free(void *table) >> +{ >> + struct ptdesc *ptdesc = page_ptdesc((struct page *)table); >> + >> + pagetable_dtor(ptdesc); >> + pagetable_dtor(ptdesc); >> +} > > Right, that works, except you have whitespace issues and I think you'll > find it'll work better if you don't call _dtor twice but instead replace > that last one with _free() :-) Ah, stupid thing I did, please ignore it. ;) Will add this to v2. Thanks!