From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E3C7C369B1 for ; Wed, 16 Apr 2025 09:40:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C9C5280105; Wed, 16 Apr 2025 05:40:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 753582800D9; Wed, 16 Apr 2025 05:40:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58125280105; Wed, 16 Apr 2025 05:40:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 36B7E2800D9 for ; Wed, 16 Apr 2025 05:40:41 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 14B29140345 for ; Wed, 16 Apr 2025 09:40:41 +0000 (UTC) X-FDA: 83339412282.21.22AB308 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 98A44A0002 for ; Wed, 16 Apr 2025 09:40:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GKJqhBDN; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744796438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a3qNFKxOG2VROH3Xg78LQUUOT835aefirG1coqjdIvw=; b=0ChdBx9r0pCd54NIhD8MBpiHyViQB59ktG5iUO21FC2y3jeg3RJY7gnDwyPrGfx5zCZ9md +u/oP1/Aog/AHp4xzWhhHC99aT7xcMAMOoN9gC7fdbrdXYxA+uoCjUol5ANtbVnblMcz4x oJzevL6Oli8wYRcgywGYshFTZ+AZzIM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744796438; a=rsa-sha256; cv=none; b=Blp5O0gdH4LwXIF2DAA5/UaeBHt+09uf41MIxoGdiMj1XP46WPhT2TpKRVABFKqXYiE7Ui in0iJpXQBYpcaZczT6qhyi+yDkFRIlzKOgaBiOIu2t8s/2cVOJdmP3SZu95Nr4dqaKkDzm cJqfP2DNnEhtVjWMCviILCippuW02xE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GKJqhBDN; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744796438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=a3qNFKxOG2VROH3Xg78LQUUOT835aefirG1coqjdIvw=; b=GKJqhBDNWnRzOVqPuJAA8qvVqwWcrHSwk6BBt8ccfK9pHSOA8eVGkBryG9RzfQhKcFxioW BylcFcXV/1u66eCBplhzkDgcloN0tdKC9pf8svU6dO67TJcikVyGE3d+swuQFx6oyBSvTa DT0ifsPyPyy73tWb4frmMzYytdYxZXU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-EawCxpmnNDi1WQZRBxKDuA-1; Wed, 16 Apr 2025 05:40:34 -0400 X-MC-Unique: EawCxpmnNDi1WQZRBxKDuA-1 X-Mimecast-MFC-AGG-ID: EawCxpmnNDi1WQZRBxKDuA_1744796433 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d51bd9b41so51980815e9.3 for ; Wed, 16 Apr 2025 02:40:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744796433; x=1745401233; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=a3qNFKxOG2VROH3Xg78LQUUOT835aefirG1coqjdIvw=; b=BzZFhpp7BzAXBAjM+rKjhKppJbJII7W5lwObebtuUf86LtkINAj50npjtL7og4N6I6 S2QaRTb243uGsSitu0dnlJAyQeLc643nBi4MwXuYG9S5X8Xvl1bO+ilGqyaSk5KtwhHW kokJI47sU10Q8FgRMGYoHHpftDGTMJIfqBjIuV0afn1NxRT5GiwuLkmOr4CVtU0ZLP5/ obS7Z6XY+IE2wo4kjwhYl2Aef1tU6HjJZlltcxdTiQYnl+IV6Wc/IMKcBPZuW6PAsMy2 mgeS6RljHSHJZgyxepQs46YjxR5EwB+1QAT006R+OnMuqhzwIwnmnYZvZ2tmjMw6UvCb p23g== X-Forwarded-Encrypted: i=1; AJvYcCUDfl9aWhSGgbwf2Y2V/weFrh23nedyR9lLrgogmpSBNVVBQBuIsdMXvu+FJqkF8cK0H4KQEJh7DA==@kvack.org X-Gm-Message-State: AOJu0YyCuw2Vo0l/aVjcVI/4FQQ/nDIIkpJlqzu+ugDjyz9Y2dyn4LB5 iO4nuH6V0O6mEaaBcJdkXiaEeIDbwEyMzyYYOw8oyvUvCJjE9N4yqUEvlX+3EhrHqgWyYdNGNfn KdFeo/OBkGrppIUt9Gx7dVwY1dj0REpOQZm64UPHF0r86cClu X-Gm-Gg: ASbGncuRoILde1Ei39/3/OUwAQThAkgCafEL39xpLFyKSwPF9Z14WpZrZJgrCcP+Usf 53g5ZxgLLnwq00pbKy7mkHwQoPGWG9aMPubqtytFQCDZljpeaKJGzlpi0BbuER36WiSWUUT5NP5 QTO+hrKSxR0Y2PR5kwbghEgoYs9ouK0Ij9U30vn3gbiH7ocE1WxMAFHh6nrblW8VQHsRqLjNZG9 T6UK9rLnGCgi7Bse7VQsUX4VeREEgpwRCsyEo7VTxLVNm89E0YwrGcyXE9mLMi3LZSnTzGQpirt vmEmvqjaZxqYBKhCkV+2KQKthbtfuqsvNw+1qvD3BjMRsFpGITDKq8xJiVWW6VqMf57NcXqQ6Z0 i+uxfVmSbqjLsC9v3zykBlVCcZ56kc6BO2f1tzg== X-Received: by 2002:a05:600c:1e28:b0:43c:e8a5:87a with SMTP id 5b1f17b1804b1-4405d63821cmr14036555e9.16.1744796433461; Wed, 16 Apr 2025 02:40:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEb5guqL9/wwiKV6Mj3UjKV6wVbSGuBpRQ5PFSwQkGEc5ks0iMgzwS8kwzayLT0kkrB7NujNg== X-Received: by 2002:a05:600c:1e28:b0:43c:e8a5:87a with SMTP id 5b1f17b1804b1-4405d63821cmr14036375e9.16.1744796433130; Wed, 16 Apr 2025 02:40:33 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4405b50b964sm15592645e9.27.2025.04.16.02.40.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Apr 2025 02:40:32 -0700 (PDT) Message-ID: Date: Wed, 16 Apr 2025 11:40:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm: don't promote exclusive file folios of dying processes To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Baolin Wang , Johannes Weiner , Matthew Wilcox , Oscar Salvador , Ryan Roberts , Zi Yan References: <20250412085852.48524-1-21cnbao@gmail.com> <34c54df6-9a7c-475d-9b91-0f8acb118231@redhat.com> <6259cc1d-93a8-4293-9009-a6119166f023@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8TIL0HrhOSH3X6xqnYUJdGKO2rGjD7l6xafLH2r6bi4_1744796433 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 98A44A0002 X-Rspam-User: X-Stat-Signature: 63f7rsuudpdk8a4a4bfm4qbjkahge3ah X-HE-Tag: 1744796438-690281 X-HE-Meta: U2FsdGVkX19WW2b0YW0zjryANLFRlLuW6YoJXNwyf2iUYJzP51elxHuYYkgKexPKO06hZb1nebyZG/GKctcdL2avnGscpYezSUWip0mZoKx6tgJ70R4vMGVaI9WgECfB27V4WoXnaV1yUVuLFo14IMEFIekQtzTeCiFCHRWw3ZaWpNv939y3z7IwhM3zFN/PnFnSJCrzwyUCi1H1SSQEVey1DQ5CyaL8D4eYmOWrkJniVcGp21BqDRPcsTsngt+ChkPpE+B9k+4EoMfwHffqz+1svwiJrzh0aNwWNSNGYYsgT+FCePEUyIWY9v6Y5+JAAQSGfj1PqhvBLqPMvpshWTgGPdgD8nQgyCRqz9HQMSyi73L2FU7EXTCHcy4Se+V/vlxiWcC3q7MJCbVlmLhyZumBVm4T5bGcyhc00cLYRM9JgWLY/q60G7fC8xCdgdQyS0gjtXSCRaOjjy5F+NmQGadJZAYVA44D7KIc0J9aB+4COKUt/+FAzVyv+H5CoI3yFrrmXxYQCMMSVAMnA3wRld8z94Hpy0yAzRNtt5OTEVkRXcNRPUlkNy2ntFVtrqfF8i7PCbuiDa1QQcNIl8aNiwobJpPwZ/1k2N/fCBKgDBUFAIDQzAnq0pgI0WxQG+oK7UqD/5QTmJ55y98HVaw0aex6+Q5Sukm9Ih03GF7/iT6HbMSloA2ViafAZA0+GlOOVb2/bI4gRX3moqR13YY7HoTAbVyGg5DRxAkuj+rcu+1EOoxMUW0ywbrMY+KUxH5VqrUnRwI9FhFzUAVQHJ/Kl6FR9iXZAQPhL5s3BkhAnm6xlGROx82Ozqt8CSSFIsLHSn6S+NTqEfvjmYNbj3XpMyYkG2FcpIIigK4MCU7ngE3lqxvvk3ZREeNRRz0k5DviollMFmY7wSUYpJp4DepxsAsHD4zq8zOlHSClUrspHd0zxoLlso1CG0uZLBiOQxNO66l2VHYd9QPs+DCwlbA 8qWPFmUS fwN0i1Lmym5NgCAC8k8WenZ5tizqEWuErdt1l/sT1PrKWzpOaslGTBVIMQ+0ydO9SJ7VxiMvjQycgMSuqTYrjVSAh77CrTiEVO2rQdcTQYtCgrNduFydfTfx+Ot2o/+DL5M5LcmiDunYf7jG7+Pc1WB9gQdNjBOO1M+wrpTjF6aA0f1BVYIytugpENTFVTPZsyVu7kzKw8vUDWTtDOhd84BqPDE19CIV2M8KjJuLAYVKxZqfEKyy2yGglDzT5tCfTEINWJoYbi7hsNKh6al/orN9e0OtJnuhYUpiGgU/d4L7Fdkh9XX2sk+uHv+Z7HhIBsyY7ztQcuLvslQbxJmf1k3F9hhnAbyYiIZValcsKziauiZiyXZlibq9S/gRifCfPHGiWTSYCNCjMTEyog3Ph52V/xFPjjGvg9vzQHgouPrHh3YFPkYQ7LwdaPyQWxg/wjOJ7NG8Oa4m0NkbSq7pCHrJLnkz+cYnbQ5zT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.04.25 11:38, Barry Song wrote: > On Wed, Apr 16, 2025 at 5:32 PM David Hildenbrand wrote: >> >> On 16.04.25 11:24, Barry Song wrote: >>> On Wed, Apr 16, 2025 at 4:32 PM David Hildenbrand wrote: >>>> >>>> On 12.04.25 10:58, Barry Song wrote: >>>>> From: Barry Song >>>>> >>>>> Promoting exclusive file folios of a dying process is unnecessary and >>>>> harmful. For example, while Firefox is killed and LibreOffice is >>>>> launched, activating Firefox's young file-backed folios makes it >>>>> harder to reclaim memory that LibreOffice doesn't use at all. >>>> >>>> Do we know when it is reasonable to promote any folios of a dying process? >>>> >>> >>> I don't know. It seems not reasonable at all. if one service crashes due to >>> SW bug, systemd will restart it immediately. this might be the case promoting >>> folios might be good. but it is really a bug of the service, not a normal case. >>> >>>> Assume you restart Firefox, would it really matter to promote them when >>>> unmapping? New Firefox would fault-in / touch the ones it really needs >>>> immediately afterwards? >>> >>> Usually users kill firefox to start other applications (users intend >>> to free memory >>> for new applications). For Android, an app might be killed because it has been >>> staying in the background inactively for a while. >> >>> On the other hand, even if users restart firefox immediately, their folios are >>> probably still in LRU to hit. >> >> Right, that's what I'm thinking. >> >> So I wonder if we could just say "the whole process is going down; even >> if we had some recency information, that could only affect some other >> process, where we would have to guess if it really matters". >> >> If the data is important, one would assume that another process would >> soon access it either way, and as you say, likely it will still be on >> the LRU to hit. > > I'll include this additional information in the v2 version of the patch since > you think it would be helpful. > > Regarding the exclusive flag - I'm wondering whether we actually need to > distinguish between exclusive and shared folios in this case. The current > patch uses the exclusive flag mainly to reduce controversy, but even for > shared folios: does the recency from a dying process matter? The > recency information only reflects the dying process's usage pattern, which > will soon be irrelevant. Exactly my thoughts. So if we can simplify -- ignore it completely -- that would certainly be nice. -- Cheers, David / dhildenb