From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D09BC433FE for ; Tue, 22 Mar 2022 03:07:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 820596B0072; Mon, 21 Mar 2022 23:07:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CF856B0073; Mon, 21 Mar 2022 23:07:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BDBD6B0074; Mon, 21 Mar 2022 23:07:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 5C11A6B0072 for ; Mon, 21 Mar 2022 23:07:30 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1517492E for ; Tue, 22 Mar 2022 03:07:30 +0000 (UTC) X-FDA: 79270536660.08.ECC12CF Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf28.hostedemail.com (Postfix) with ESMTP id 21399C002D for ; Tue, 22 Mar 2022 03:07:28 +0000 (UTC) Received: from kwepemi100001.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4KMxHB2qKtz1GCpk; Tue, 22 Mar 2022 11:07:18 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by kwepemi100001.china.huawei.com (7.221.188.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 22 Mar 2022 11:07:24 +0800 Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 22 Mar 2022 11:07:23 +0800 Message-ID: Date: Tue, 22 Mar 2022 11:07:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH -next 3/4] arm64: mm: add support for page table check To: Catalin Marinas CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , Pasha Tatashin , Andrew Morton , "Will Deacon" , Paul Walmsley , "Palmer Dabbelt" , Palmer Dabbelt , Albert Ou , , , , References: <20220317141203.3646253-1-tongtiangen@huawei.com> <20220317141203.3646253-4-tongtiangen@huawei.com> From: Tong Tiangen In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 21399C002D X-Stat-Signature: bybciydzu51kxqgco9we3ky6j1gco9az Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com X-Rspamd-Server: rspam01 X-HE-Tag: 1647918448-768086 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/3/22 0:40, Catalin Marinas 写道: > On Mon, Mar 21, 2022 at 02:15:36PM +0800, Tong Tiangen wrote: >> Considering all your suggestions, The final logic should be: >> >> +#define pte_user(pte) (!!(pte_val(pte) & PTE_USER)) >> >> +#define pmd_user(pmd) pte_user(pmd_pte(pmd)) >> +#define pmd_user_exec(pmd) pte_user_exec(pmd_pte(pmd)) >> >> +#define pud_user(pud) pte_user(pud_pte(pud)) >> >> +static inline bool pte_user_accessible_page(pte_t pte) >> +{ >> + return pte_present(pte) && (pte_user(pte)|| pte_user_exec(pte)); >> +} > > This is fine. > >> +static inline bool pmd_user_accessible_page(pmd_t pmd) >> +{ >> + return pmd_present(pmd) && (pmd_user(pmd)|| pmd_user_exec(pmd)); >> +} > > That's fine as well assuming that the function is only called on the > set_pmd_at() path where we know that the pmd would be a block mapping > (huge page). I think that's the case from a quick look at the current > x86 implementation. Yeah, PTC only check pmd block mapping(huge page) and pud is similar. These code logic will be included in V2. Thanks. > >> +static inline bool pud_user_accessible_page(pud_t pud) >> +{ >> + return pud_present(pud) && pud_user(pud); >> +} > > Same here. >