From: Laura Abbott <labbott@redhat.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Hugh Dickins <hughd@google.com>
Cc: Linux-MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>
Subject: mount on tmpfs failing to parse context option
Date: Mon, 30 Sep 2019 12:07:18 -0400 [thread overview]
Message-ID: <d5b67332-57b7-c19a-0462-f84d07ef1a16@redhat.com> (raw)
Hi,
Fedora got a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1757104
of a failure to parse options with the context mount option. From the reporter:
$ unshare -rm mount -t tmpfs tmpfs /tmp -o 'context="system_u:object_r:container_file_t:s0:c475,c690"'
mount: /tmp: wrong fs type, bad option, bad superblock on tmpfs, missing codepage or helper program, or other error.
Sep 30 16:50:42 kernel: tmpfs: Unknown parameter 'c690"'
I haven't asked the reporter to bisect yet but I'm suspecting one of the
conversion to the new mount API:
$ git log --oneline v5.3..origin/master mm/shmem.c
edf445ad7c8d Merge branch 'hugepage-fallbacks' (hugepatch patches from David Rientjes)
19deb7695e07 Revert "Revert "Revert "mm, thp: consolidate THP gfp handling into alloc_hugepage_direct_gfpmask""
28eb3c808719 shmem: fix obsolete comment in shmem_getpage_gfp()
4101196b19d7 mm: page cache: store only head pages in i_pages
d8c6546b1aea mm: introduce compound_nr()
f32356261d44 vfs: Convert ramfs, shmem, tmpfs, devtmpfs, rootfs to use the new mount API
626c3920aeb4 shmem_parse_one(): switch to use of fs_parse()
e04dc423ae2c shmem_parse_options(): take handling a single option into a helper
f6490b7fbb82 shmem_parse_options(): don't bother with mpol in separate variable
0b5071dd323d shmem_parse_options(): use a separate structure to keep the results
7e30d2a5eb0b make shmem_fill_super() static
I didn't find another report or a fix yet. Is it worth asking the reporter to bisect?
Thanks,
Laura
next reply other threads:[~2019-09-30 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 16:07 Laura Abbott [this message]
2019-10-07 14:45 ` Laura Abbott
2019-10-08 0:50 ` Hugh Dickins
2019-10-08 1:26 ` Al Viro
2019-10-08 16:33 ` Laura Abbott
2019-10-08 12:38 ` Ian Kent
2019-10-08 12:52 ` Ian Kent
2019-10-08 12:56 ` Karel Zak
2019-10-08 19:51 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5b67332-57b7-c19a-0462-f84d07ef1a16@redhat.com \
--to=labbott@redhat.com \
--cc=dhowells@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox