From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB57C6FD1F for ; Tue, 2 Apr 2024 09:45:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFB4B6B009A; Tue, 2 Apr 2024 05:45:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DABD46B009B; Tue, 2 Apr 2024 05:45:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C99D76B009C; Tue, 2 Apr 2024 05:45:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A6A9C6B009A for ; Tue, 2 Apr 2024 05:45:49 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 694CFA0E58 for ; Tue, 2 Apr 2024 09:45:49 +0000 (UTC) X-FDA: 81964110018.14.19706F0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 26CAC140025 for ; Tue, 2 Apr 2024 09:45:46 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=h6wjHOy+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ik5BZpXE; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712051147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pDYWPh9W842+NarazX7IGM60Ne3NuUq4V7uhwpL30C8=; b=ulZXWBnENAPqpObQl/k9qHOZBr02qxVL88RwhZtqaCe1VADhvvPTlzSf0jmRunftgrAz1x evFJ3by4ZFg6JjdH+fPs43lYBKBreCEQe9MBci/ypzVijIkszFV3FJDCSeYpO4mTS0HG7T KS74OX89ss0gnJ9eUrJGBJ1Dn51TCRw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712051147; a=rsa-sha256; cv=none; b=GwE8hVkO2GubEA3kqeKimZDaTIEsA28yEbhkaPD63OnWwgL3GV7DMlQAqMlIzu8U/yZmPH yHiilEhwrR5lT5ch5TzjWzw/5N2c1BldBypKKyCn+wL43WVbZ+winRksrh3Wv8JdOVYBTI HNZCRQPg7Qf/38b686tT7pRnHluh7Y8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=h6wjHOy+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ik5BZpXE; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AC1FC20F01; Tue, 2 Apr 2024 09:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712051145; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pDYWPh9W842+NarazX7IGM60Ne3NuUq4V7uhwpL30C8=; b=h6wjHOy+wKQyBBgtWta6IMyhrS/ULjUOZc2b4JTH2b/FcAAwzVCKqAhRHzAx3idWWcY9yv UM5ydFu3xnQdOzRxH1JDEU4WpxTea2mOq3/kixNqSF/z3aPbBnQ7V0g2uEORxuDxXtHUlq Cfdm3WUV+y4uRHFNaatnBtgdAka+Yqo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712051145; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pDYWPh9W842+NarazX7IGM60Ne3NuUq4V7uhwpL30C8=; b=ik5BZpXEngWVzPLH2TQFuHy1B+pO6NR/qPVwZVS6bpWloHZTbh2xZSvinvsOnOtz+s0NH6 Xu7I0D/ltmUoV/DQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 93E6413A90; Tue, 2 Apr 2024 09:45:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id ivHII8nTC2ZfAwAAn2gu4w (envelope-from ); Tue, 02 Apr 2024 09:45:45 +0000 Message-ID: Date: Tue, 2 Apr 2024 11:45:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm/slub: remove the check of !kmem_cache_has_cpu_partial() Content-Language: en-US To: xiongwei.song@windriver.com, rientjes@google.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, chengming.zhou@linux.dev References: <20240331021926.2732572-1-xiongwei.song@windriver.com> <20240331021926.2732572-2-xiongwei.song@windriver.com> From: Vlastimil Babka In-Reply-To: <20240331021926.2732572-2-xiongwei.song@windriver.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 26CAC140025 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: jz5mkp74otmetm4kqs9o43adbxsbsudm X-HE-Tag: 1712051146-413538 X-HE-Meta: U2FsdGVkX1+PGY4IIa2J6CYRkyBJiOzZEPuO52RJzEByy1uz4GUcyfRrxqmFK7auToV/VDOXYtYbTN0PJTutdjaePy0/GgfDs3Shs3KysuBvmYSFuE0bjXl1WkMMdyDzQBP/UWBAUZKnsj1O8g9y5zIeddSA7fVhDlPwAgETXlTmkkEcSuqysVBih7NFK/TF52N9YZLCoJHDkHQ1K50ls57Gj4VMlCpk2WPe973TlcfAGT2Vaaj71kfNTgyFv2pDx2ekP3ebWWLspzt1YnmVp3UCZOlKzvSfOj5bPcBBLXpyDTdwjU+5u6ParCXALkGebcPjSaAhUQ+7qTgr5BcMtqrbLjPN2aQ4aPSP/142+LdWrQMQoslhYv701zKAufO/H/4DLWMB+Qbb8h+2jQwpaFGyD2QMFlWFfKzq6vDq5A8njdI0xV9AXKS9vF7SEah6EQ9DTCcSwffkq/Iin3SeoHiTSbD0cREFCC09A4VcwgGPzyjMNbquSe10AZZ9z9zinNQn0KxhZBAkrDYvpUOeY+KsvrHoDyRh0gbVCENKK7Htl4EKWKGXslYtvXpokyYsQLOcAkiqyvlhD8voV+/UL+F5fneYCod0eXbOU0MFV2LPMYjgSOsFe6ONTSfxszRWNPSp9+LWVeMNYTU+pP/7W+9z/almcoQwZO3b0wFqNCxKdS7qLTgSVM415UVdpTirVb+tr1KOstZnzkfvKjJwIZ8zJnhIdL3+VEUXXZ3XHMJAhv5xKFhbYXhuaHW8rcD2dh7PKmeyxGGo2FYdpOD0pc+JPgIUuCkpgx3MmP+vAOqTdFx/unHxnZoOcUrPRt4aPGKwnaiKOILaaaYO7xDFNfEDVIsVzwmiPgAgjUdOnvSzR/FShLfnJrh38/T7/Qu5mjIpnSW9uwjzGoDx8z6Rw1Tn1KoI2QRI8tXmmwyz4eVRIM8vFWa95FFRJkmr40z8hC4OsFpHpoJJnPnWbtm 6Av/W4lp CDPulkSKxtBfeH0BSi75cbq9emnvMNYhjIWLm+36l1zsjdTmpfu+Oe5dd5KMUVoZ6Nv2FQxv24spKfk1fChk1ZIoAIXVuvIC7I3H6IywW75Ahy7faDcgNOtmxddN456OltAhByH+9EDN8Xmg7VIsQxhEzlMhmlKMLv6EdfEENpE1YxAp818XPOmvxm2cMsSwX5Fk2O5N3AsMliSnuW+HNiHcf8k8KVJPyphMvSdCTX8csrjltBOPib6hX19GA5axLpvSGt9WU0hQdZHeg875xUjIg/uIstzEg7iCEjeHbJYcqNStAVlQYqCNP6Qsf07GijZwHqvkCQlX6kkW0voRnZik+RuZuw3FxQaDNDx7ztqLcdWeHJz87RMXhOEMRaLDhZtt4qJU3ogHcfcGZuTash/cSsA0xmraGwC5aTYjiTbEixj7l78oo8DoPLiN3oimEuSmUvYY4lXpLW6K7+KuWACsdi24BzKcS9sQH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/31/24 4:19 AM, xiongwei.song@windriver.com wrote: > From: Xiongwei Song > > The check of !kmem_cache_has_cpu_partial(s) with > CONFIG_SLUB_CPU_PARTIAL enabled here is always false. We have known the > result by calling kmem_cacke_debug(). Here we can remove it. Could we be more obvious. We have already checked kmem_cache_debug() earlier and if it was true, the we either continued or broke from the loop so we can't reach this code in that case and don't need to check kmem_cache_debug() as part of kmem_cache_has_cpu_partial() again. > Signed-off-by: Xiongwei Song > --- > mm/slub.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 1bb2a93cf7b6..059922044a4f 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2610,8 +2610,7 @@ static struct slab *get_partial_node(struct kmem_cache *s, > partial_slabs++; > } > #ifdef CONFIG_SLUB_CPU_PARTIAL > - if (!kmem_cache_has_cpu_partial(s) > - || partial_slabs > s->cpu_partial_slabs / 2) > + if (partial_slabs > s->cpu_partial_slabs / 2) > break; > #else > break;