From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA200C27C52 for ; Thu, 6 Jun 2024 08:38:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42B9C6B00AB; Thu, 6 Jun 2024 04:38:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DAFE6B00AC; Thu, 6 Jun 2024 04:38:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27B966B00AD; Thu, 6 Jun 2024 04:38:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0B5086B00AB for ; Thu, 6 Jun 2024 04:38:31 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 71BED1C0A2A for ; Thu, 6 Jun 2024 08:38:30 +0000 (UTC) X-FDA: 82199812380.09.6625D4D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 30A20C001A for ; Thu, 6 Jun 2024 08:38:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QgVWrYex; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717663108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SdfTjzBkoj+tg945aw7yDq4wyxvCMWvvxDmKDLcr7LQ=; b=P0i7Drw1/a3m5Omp77GizimaFLJ/br+gMHgmIxahNt7etufhwQyZh39eLlSXsoud9qCORP TuJcP54flucD6ZR+l+5C1pSzzU1x4gczQFgUE/rmhb/UedlHd/Nb2a2SmKFcxV6kGUBix+ WTNJ2XChNrKb4yAd3r2maMq1nHGzxFI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QgVWrYex; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717663108; a=rsa-sha256; cv=none; b=OBLvOXYyaqvyWMC21IrZ3fwAK7CS2lncz46uqUN1t7a9PmLkYUgJo3hRlZqtVr9b7pguvx wmyDmG67kMp9ontfhzgJLeiwYeEmgLJ1O8yglSPZoS8zNWfKIMae+u+5NQwJYcn+Vhl2+O WcCxhMgcBogBIS01wdlm+pKcT1A1qsA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717663107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SdfTjzBkoj+tg945aw7yDq4wyxvCMWvvxDmKDLcr7LQ=; b=QgVWrYexfRE8wqux/EUAdysysWFU9UezBwhesEglUACytWjd9PF2a1v2Pm6dVFiZGQIAR9 DqVB6/GZD9mYFUONw31HzlBeSv8m+TLxO7lC4sYGYrkZ4YNhTKmdTCiyqyhDUl57f+KKLM Yc2Z60YdRQ1N1oFRLZTODzbH+NWspD0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-bV2ZfGtMNyGcIAIUltkajg-1; Thu, 06 Jun 2024 04:38:25 -0400 X-MC-Unique: bV2ZfGtMNyGcIAIUltkajg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4215a38713eso6246025e9.3 for ; Thu, 06 Jun 2024 01:38:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717663104; x=1718267904; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SdfTjzBkoj+tg945aw7yDq4wyxvCMWvvxDmKDLcr7LQ=; b=Q8ZyxtTOutKJaye+KxeP6gD11tcVrgaN3I7/Mblx6iWi4pCBpGgUkJ9JKi0dBWIhHF mQ15DdzzOf29SjN8mbo3UFsPjoGZryy9EekjOui49O5Yo8BVBC+Mvm/IQcRGo8l76j43 8HzxVFZr//+JF2VyTzHwqkA340bJ1v64pF9WePvUZ5r33kJKcuJIr82E+/yrHsJc5pDL OMCxT7ZZbXyAY4N3VazBJTWkmus+Pc8loMsnPdDsEtgkflmrreeA/TF9WOUa5zVctC8r GFar9Y8ldSpqLiztmtgdJfO5slmn4DSiFzNOpPmnE0F3EWk4aL/i6nMnFcGCclfWT+zZ J0UA== X-Forwarded-Encrypted: i=1; AJvYcCV3PT8uq29dMKZY/oIaWl0uHfU99r3iExA01/lfU1fTV++Z3ltSn6dteMPzHJJeezOfqmKHEqbrYvlfrWoZNHSll+o= X-Gm-Message-State: AOJu0YxXa+4tCI6jbt1S/4krGEzt45w2scl5pF8riqpFJSVsGX5Uy8rR v6EjmTyn1R6W1opgMytzuatUiXPSviXeA+8CjNSj68Q33aPdFas4YbMK6T4rLn17BYOKXM4qtkG eBw9IQkjsnzqb/qQ1zT4rjz5T+GhPOSogTOLUR/Xtj+nF/66Wy3Rg4S7Y X-Received: by 2002:a05:600c:470f:b0:421:e89:dd07 with SMTP id 5b1f17b1804b1-421562c66dcmr39690415e9.2.1717663104666; Thu, 06 Jun 2024 01:38:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFG0vfg8rzL3R4n6zyUXGIvtkbUgvaQggEVFubg0B7uiu3yJgFpTvvdUb4JsdIyg9r4yJxyuA== X-Received: by 2002:a05:600c:470f:b0:421:e89:dd07 with SMTP id 5b1f17b1804b1-421562c66dcmr39690175e9.2.1717663104214; Thu, 06 Jun 2024 01:38:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c710:8800:a73c:ec5b:c02c:5e0b? (p200300cbc7108800a73cec5bc02c5e0b.dip0.t-ipconnect.de. [2003:cb:c710:8800:a73c:ec5b:c02c:5e0b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4215811d981sm46101835e9.25.2024.06.06.01.38.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jun 2024 01:38:23 -0700 (PDT) Message-ID: Date: Thu, 6 Jun 2024 10:38:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/6] add mTHP support for anonymous shmem To: Baolin Wang , Daniel Gomez Cc: "akpm@linux-foundation.org" , "hughd@google.com" , "willy@infradead.org" , "wangkefeng.wang@huawei.com" , "ying.huang@intel.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "ryan.roberts@arm.com" , "shy828301@gmail.com" , "ziy@nvidia.com" , "ioworker0@gmail.com" , Pankaj Raghav , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <502fb3df-b42b-4f0c-a98d-348c3d544721@redhat.com> <5mezgqzg7wmd4iq2d2q3aentziosetwcll3tgdbl3mhriseyv3@pgxsux7qvxno> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 30A20C001A X-Stat-Signature: tk6atgfg6twpeeydy9he6wjnz6gzku76 X-HE-Tag: 1717663108-45345 X-HE-Meta: U2FsdGVkX1+KSchHG69zPhi7qafuEvPrBGMIeDfMkEnGfJMhDcnawcl/45a3jlIRVE5rzvc4BKaOBzoJlyf6vnpVsm9MhQv/AFkqSNV+Wxg1MxEM99G95oLWIt9xkXifZCfm0wZ2I0m8Zw0M40mG94mWa7kr2fesKizE0bo3AFta83PyX9RzwF3Rh+NRTB3452/fsCo4g4NDiCUlBOBUr1aVt7n2rKpeevFDyr+MYWTXMzLBDN11HkBlGUyXs/Z/IkrntmP/Fv9ZjflQnTJPbn0qkmYhdTA/2n21ROcAs0p9rQ6l64BIyrTgEchfIyzzWk4YHBofqyn/A6ddn7ZV2xqPnY1VnhiMkJ8wo41gMpWRSUO/LG4M0Maj/Rhz2v8SO/fFDuQNoIofCQKRgodylB3mHYqvmhltYcZ6sSta2QGYuCBbBCW3E64f8aSKC4amWs5kXwzdhOPu/rcv0xAputf1kiH2fjzRcYr9VJVXUgnC0LrM0n/knFgS5yRkGmPXwizq5Aq4j7jP9zOAXAd/9PHez7hShKqP8pHyQGeeA05f9t8e3Syu7mDIF1gE8xMQ+rEYpjuQasVYn2Ma+9G36rdX+z/QOdGBeR0IwPb3Be+Sgfyna4FePfldW3Waj3+2ULPwn196tEk6o/sip2oJ3pi4wQLUEf3xtKJqOyPKZb1dZ9JrVPWi5z96MhaGp5FkAF6ncTil2xBe3ZMgFfgvA+cd8LHHhCPQ8dIx30MXog2eTJht33iWkxbDoEwTxvPTQVmKz9onSq8K8grR8M48Odr9NXIpWpYzrXZISZzC/oO1je/3u4N7HJ6VjZPmD4Re+Dy3Y8GNnV2j2FYXr4dfIWUKXVw+60Gw1fJauAjk2YVWRXkNLyitK6p9z5kmCVNQtD1u1mxgdiY8NShihhBDsoF8g8ii03oXLr6E5vJCfovtqqB3cwBgv0nk3ewIwtyERULZxnUqy4GMVk1eSCz rXXrBqNN yxHPriG7+D9vCO4HBELYbzXPRma4yyFxmc8pXtQzy4aaxwH3SibXhLp4eqm1RMr7tTi8lG/Qf9omV97Lox39aOrYbbefx/J1dllASDuQkezRIHG1PizU9Y6y3ds98hZmFVMvSf3G66+GGarwfd6AdPWtGjonprFksiE2G9qxoyNgLX2gI/pbjXZDvkywkB2q8HiOj3UErWNZBs1B+K3ONK9cMj8xmF0q02ewb1uJG5U/3IZDz+F1jPPgki+DE7Hba1DIU4rVVntg2g07mXjvd6/MeytnO31wVcIeumdLsAxDYSC6G5SzwYWUKg0Y9saG00nuoqoGdFJIinVepQdJds+RJjN1nkUvH1yYniWGqNkGk0wXGMaU3XImyIK99IYso5noYTCXScBY00jKguJg5uyy0dS+xAeMRHwguhsPKxbxzd5kYWVZ7qJvbcsV6xNoTKcSThy8/txMdMyWYjkPtKeyk6Va2g3aZF99hUzoYUIOR540ynyKUaQmdQTlay8jJYngmBPizivviLvClZXCuNDchuGM13yM3d7eNXixtV/uCQV7SU8RA3msEVBvBwPuQj5re6GlqVBVpfjOgw9sjNq/TPRdFTjEZjt3S7zw49RAjgUfxutnO6Km47CRqSa9X+yG3UolVx3BMZl6CnqYtonoapx1+kp7+PHsijHgKtYqbdd+5EUnuUt+Q4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.24 05:31, Baolin Wang wrote: > > > On 2024/6/4 20:05, Daniel Gomez wrote: >> On Tue, Jun 04, 2024 at 05:45:20PM +0800, Baolin Wang wrote: >>> >>> >>> On 2024/6/4 16:18, Daniel Gomez wrote: >>>> On Fri, May 31, 2024 at 01:13:48PM +0200, David Hildenbrand wrote: >>>>>>> >>>>>>> As a default, we should not be using large folios / mTHP for any shmem, >>>>>>> just like we did with THP via shmem_enabled. This is what this series >>>>>>> currently does, and is aprt of the whole mTHP user-space interface design. >>>>>>> >>>>>>> Further, the mTHP controls should control all of shmem, not only >>>>>>> "anonymous shmem". >>>>>> >>>>>> Yes, that's what I thought and in my TODO list. >>>>> >>>>> Good, it would be helpful to coordinate with Daniel and Pankaj. >>>> >>>> I've integrated patches 11 and 12 from the lsf RFC thread [1] on top of Baolin's >>>> v3 patches. You may find a version in my integration branch here [2]. I can >>>> attach them here if it's preferred. >>>> >>>> [1] https://lore.kernel.org/all/20240515055719.32577-1-da.gomez@samsung.com/ >>>> [2] https://protect2.fireeye.com/v1/url?k=a23e7c06-c3b56926-a23ff749-74fe485fb347-371ca2bfd5d9869f&q=1&e=6974304e-a786-4255-93a7-57498540241c&u=https%3A%2F%2Fgitlab.com%2Fdkruces%2Flinux-next%2F-%2Fcommits%2Fnext-20240604-shmem-mthp >>>> >>>> The point here is to combine the large folios strategy I proposed with mTHP >>>> user controls. Would it make sense to limit the orders to the mapping order >>>> calculated based on the size and index? >>> >>> IMO, for !anon shmem, this change makes sense to me. We should respect the >>> size and mTHP should act as a order filter. >> >> What about respecing the size when within_size flag is enabled? Then, 'always' >> would allocate mTHP enabled folios, regardless of the size. And 'never' >> would ignore mTHP and size. So, 'never' can be used for this 'safe' boot case >> mentioned in the discussion. > > Looks reasonable to me. What do you think, David? > That mimics existing PMD-THP behavior, right? With "within_size", we must not exceed the size, with "always", we may exceed the size. > And what about 'advise' option? Silimar to 'within_size'? Good question. What's the behavior of PMD-THP? I would assume it behaves like "within_size", because in the common case we mmap (+advise) only within the size of the file, not exceeding it. (the always option, as I learned during the meeting, is primarily helpful when writing to tmpfs files in an append-fashion. With mmap()+madvise() that doesn't quite happen) -- Cheers, David / dhildenb