From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 905F1C83038 for ; Wed, 2 Jul 2025 09:08:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2163F6B009A; Wed, 2 Jul 2025 05:08:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EDB76B00BA; Wed, 2 Jul 2025 05:08:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DD696B00BC; Wed, 2 Jul 2025 05:08:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ED9C86B009A for ; Wed, 2 Jul 2025 05:08:56 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BD2BC10758C for ; Wed, 2 Jul 2025 09:08:56 +0000 (UTC) X-FDA: 83618749872.17.48A6C37 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 57906180010 for ; Wed, 2 Jul 2025 09:08:54 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IIBdF1Ne; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751447334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3FWUUWWvQmpLIQL4fpxsltF3bjwMUK3ZFkqiJPM4x5M=; b=tjJ0q85kqCnrPiihmTK9802vH19WMRdEAU09CKCbF+uT42WOQpQ7VBL7XTHzLlmp0dm95w g7SRjCB5ylzxST1pkDS60hBLFJhi3k8oMtYrYmg00aa1Vx4bRjdo18iYPaLYp+nmFNqeOh NEIrunFKRo0/2Lq/+Dt9tWpuULhDTBQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IIBdF1Ne; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751447334; a=rsa-sha256; cv=none; b=GceQbg7IBhMw9tM9vPfuPwnlkBPC9GtCzDqN9DeMaT2jUl0+3FbwqQ96XZwQ95hwCKGwnE jfCWCVnCuUrv+Vov/zfdv26vaHAXXkIvTnexKBmsDdhUdqEkDTt2OHEG0o1J+BulgvDSBi +kQNpaqBaqazUhDNHjxdgJmwAgtR+yw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751447333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3FWUUWWvQmpLIQL4fpxsltF3bjwMUK3ZFkqiJPM4x5M=; b=IIBdF1NeYjAhW18KGAZsGMLbdXcaW/l6sxN/koPVJpgneYNd1CrCJpL41nk3NDZPvs1sUr p6bPa+PgNnFFwI55lWvnjB5wrgeY71FvPUNTXwLytRS1C+Vw6T0ZVXav8zB1y+Xt6Fx7qd TnTPx/xwn1e5g6CVqke/AcYW4EPICr8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-jU62fkqJOnSOlP1CPaeY3g-1; Wed, 02 Jul 2025 05:08:52 -0400 X-MC-Unique: jU62fkqJOnSOlP1CPaeY3g-1 X-Mimecast-MFC-AGG-ID: jU62fkqJOnSOlP1CPaeY3g_1751447332 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4ff581df3so3301318f8f.1 for ; Wed, 02 Jul 2025 02:08:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751447331; x=1752052131; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3FWUUWWvQmpLIQL4fpxsltF3bjwMUK3ZFkqiJPM4x5M=; b=tb31JB5Sj91uKNP46a70io1fJ5rIkZvkhS8a88NQGyJli2QjQ3YLQVpNY4HvD2XsJF k0b7UgJDI9eBqFcxSpbIIeCZAQPIqtsxKIgU9KZmU1hsk90Jh/DlpLUWp03LQYd9SAXF XqjEOAiRbgxY1xjvzTdaYBLBo9Biqjdm9Nu6+e2kmOY0ZvG1zzjRtw8G2Ikk3LaA9UPu T2GdenFMixB87zD5Gx1zWcFi0VFWwq6Z6o7yHxCNcFIm6YOmp3aiA6/M9rdGARWtJ4Fq hvOYM0IyyrclrDoEGBmqq0ThyfGTpc6GtzLrFpR9tUNsLrABvtQ7EGqe9PgIqs6o/ElM S1Hw== X-Forwarded-Encrypted: i=1; AJvYcCX4Nf8yVzYTDLBxumiphArK7vPH91FvWvGShrjtpkOYfX1uz6r4mncZqKpSXSUNfSqNX4/6ofPA8A==@kvack.org X-Gm-Message-State: AOJu0YxSaP9BLzarE+ud+knF6e1IFI3/l/6SQbHOrBz15dOnOhT6a5BV hXwj3/N7z+oZhvyqtuh+XxXLglT63oBGNFaN1Z2FH03olDxjbEnsfVx1uY2UpzAeno2MHDSe6wv ATWdUFodEO9Akb+2yPJOrNu0y08gmboLlWSt/XavVAdwLBDY6MmRy X-Gm-Gg: ASbGncsz5yb6gKA1IyNO5xMWsrn3GzEqhX6Ey09sqOvJvpKxgjlRrS6ee4jF1V74G5a te0R4F2i3IdUHThdlUJI/H+mJ0KpBqZh2TyNkeL0fMXC3yauFC47hEvLTtGf+TZ9g+xJGYmtC1p WmTuZizTFnVjfZCVbEdVuls0aGKojtWIEEognqI6z7Xsct15t5P88yHCkmcT1e+xzGtYItI5ff7 PzvKd9i9QQw4w3ztYvE1zodwhhxEZnBEj68gMjpyNH8JSl45YULMNfFAVVoMiNYqMpuSSCkmncw 4WoutkPOopFKpz6vjx7Yc/XUNg8oJqGtUHYgr40e59P5mlvKZ6KgtME= X-Received: by 2002:a05:6000:1786:b0:3a5:1241:afde with SMTP id ffacd0b85a97d-3b1f698b0b6mr1637048f8f.9.1751447331412; Wed, 02 Jul 2025 02:08:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5zMSUwuwLNiQMhcY3yK9VsCPjJJhKQGCXG6QyAkUnBukUgUn8o5MjzLIrKifqceTyYKmK0A== X-Received: by 2002:a05:6000:1786:b0:3a5:1241:afde with SMTP id ffacd0b85a97d-3b1f698b0b6mr1637015f8f.9.1751447330856; Wed, 02 Jul 2025 02:08:50 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e52c99sm15323898f8f.49.2025.07.02.02.08.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 02:08:50 -0700 (PDT) Message-ID: Date: Wed, 2 Jul 2025 11:08:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/4] mm: remove boolean output parameters from folio_pte_batch_ext() To: Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-5-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: J170z2Gk1VDsNKhfHv5xzkBd6ywKxEzr3aCvVsdh0b4_1751447332 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 57906180010 X-Stat-Signature: wrgiuz5411hi3xz6yukzen749wkp66n3 X-HE-Tag: 1751447334-84291 X-HE-Meta: U2FsdGVkX18q7u3JOTbbxoqKb+8vnJb8XsIj65imR4Zom+rhh/zSkL5QKUh6N9lu/Xtgc3no3EprrS9pymYxZKsX9Prlaf13wCdLeDhv4wBCYdZSb0ZRlK40hjTl+2vsqdjrd1tTruVSoue7FmJ4Y8Jl+7iCfImCpYjifJ7g2R0zj028/Aa3t/IbRuE0HwjU/jKDPZKp5C2WBA32J3hR3vTh/rwVKFrDJ24n67FL15T7ZgXD9T+POaMnmqS3ELa7L0QdPw4wINTvi1DW17qjrqqmCdVzPxOjv87OPk8bnteroqhSslfMDBLq4CLejL3LnvkXPU2Y5+k4pLfaWfBZtNKmwSX/9dJSQDN3WbP8rmVPP8eaR4vAmCyhLSnJcGITBV0trvmOSNiC62lkarx8dNbZ87NPuPK9Q1WoSRKjFjc8Fe+zhZDF5ePRrIBJSR4O5v7zWHXeoJec9pnwrZnYlyIiSXCCpJzPkITlaiS7Ar3ze/x/MnLC/LkE/097VFLoUYricKSNRRukCoKf+El77BdY8rUVBCZ4gQRoD261lgAC0MKSWNlADoH5p5TulPj4GxCax/NFHKFIbLGhW9vgLJL9hnAt++M+G8y+XwO5oLh54wLK9hI+9GkstKetiWpWMpaSBcX8g35MV0EhOc3/pvGDvIcDEKtfFXM6M6phwSQS8kmetzMQ+lONG3H8ydSedahi8BPz0ZjdweFMguWSFUyep9jdCfa1i3Tyejr5tvRsjBU4sLNyryI5nSjvnH6PlnDiaxiMJyIDMdAWCBVlt1fsQLcF7M6MqQeZgQCBcl1HPMA4EX+atYysEbMb7EmXsgyCrpfVEPUblk2AB1cI/JYvdz80YBB0MKq0sJUaXf78jUb9qrzyx2zzG5dCQixBFBfZkvyaE8Rfpmvbz/HJeye5ivjgD64zzOkiDc2pdHdRkZAl2ULXrklxGrPZ6P81YBsK7klBqYsDp/Gv2Ja OY7ZyZal +kh40PhDqXUpz6W/jRURrHLs3AJnN/8N7RWV+iw89//zVbDLDpghtYwkBdSDKKUVocYdSyotB2W/eNoLIGKBWblvc1yaM9DQ1FxZOHakpxfRGZvEmKEeejkMpNnpuENPRWanEBz+dZeWiRw/ubk2NC03PgxZ75TUAPkuyv8h7NjuvJEdwIGmklKAEhe1HzJkMmEkyoFfkxhaUiYjngFY4GYjD0j8G0zO7PCtLwLIwHymHjrSDscAMX3aiXrdhNpkjjGN1XYgn/pTJrdXfZKa3WZD4NUDbAn48Z0+RLUYaYD+U34hSBtAVbO9FAA1B9dZugiQnIzP7WGshCTWKqtF7Bcyi70qjccKeFMNA9vU0tU2sBVVcVjZy0KfW7lgojSYaLFQa0uOX85P9lHm4N1TkhUh0zsFsXSwbReq+iLyLm+56XWXkQLl91arYG8cGj64o/m4aTogTaMon0cqYP3PkVWOVIq1aOfOAFyo3qfUaJR+jzdHmdJDBR0ccZUMuVfx036e+Cjdr2cDDg442Mb6kRZZDsXmxaTJdzK4YuID6HIPsf/0ku0P57CRylGrZ6uTZU/CT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.06.25 19:59, Zi Yan wrote: > On 27 Jun 2025, at 7:55, David Hildenbrand wrote: > >> Instead, let's just allow for specifying through flags whether we want >> to have bits merged into the original PTE. >> >> For the madvise() case, simplify by having only a single parameter for >> merging young+dirty. For madvise_cold_or_pageout_pte_range() merging the >> dirty bit is not required, but also not harmful. This code is not that >> performance critical after all to really force all micro-optimizations. >> >> As we now have two pte_t * parameters, use PageTable() to make sure we >> are actually given a pointer at a copy of the PTE, not a pointer into >> an actual page table. >> >> Signed-off-by: David Hildenbrand >> --- >> mm/internal.h | 58 +++++++++++++++++++++++++++++++-------------------- >> mm/madvise.c | 26 +++++------------------ >> mm/memory.c | 8 ++----- >> mm/util.c | 2 +- >> 4 files changed, 43 insertions(+), 51 deletions(-) >> >> diff --git a/mm/internal.h b/mm/internal.h >> index 6000b683f68ee..fe69e21b34a24 100644 >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -208,6 +208,18 @@ typedef int __bitwise fpb_t; >> /* Compare PTEs honoring the soft-dirty bit. */ >> #define FPB_HONOR_SOFT_DIRTY ((__force fpb_t)BIT(1)) >> >> +/* >> + * Merge PTE write bits: if any PTE in the batch is writable, modify the >> + * PTE at @ptentp to be writable. >> + */ >> +#define FPB_MERGE_WRITE ((__force fpb_t)BIT(2)) >> + >> +/* >> + * Merge PTE young and dirty bits: if any PTE in the batch is young or dirty, >> + * modify the PTE at @ptentp to be young or dirty, respectively. >> + */ >> +#define FPB_MERGE_YOUNG_DIRTY ((__force fpb_t)BIT(3)) >> + >> static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >> { >> if (!(flags & FPB_HONOR_DIRTY)) >> @@ -220,16 +232,11 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >> /** >> * folio_pte_batch_ext - detect a PTE batch for a large folio >> * @folio: The large folio to detect a PTE batch for. >> + * @vma: The VMA. Only relevant with FPB_MERGE_WRITE, otherwise can be NULL. >> * @ptep: Page table pointer for the first entry. >> - * @pte: Page table entry for the first page. >> + * @ptentp: Pointer at a copy of the first page table entry. >> * @max_nr: The maximum number of table entries to consider. >> * @flags: Flags to modify the PTE batch semantics. >> - * @any_writable: Optional pointer to indicate whether any entry except the >> - * first one is writable. >> - * @any_young: Optional pointer to indicate whether any entry except the >> - * first one is young. >> - * @any_dirty: Optional pointer to indicate whether any entry except the >> - * first one is dirty. >> * >> * Detect a PTE batch: consecutive (present) PTEs that map consecutive >> * pages of the same large folio in a single VMA and a single page table. >> @@ -242,28 +249,26 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >> * must be limited by the caller so scanning cannot exceed a single VMA and >> * a single page table. >> * >> + * Depending on the FPB_MERGE_* flags, the pte stored at @ptentp will >> + * be modified. >> + * >> * This function will be inlined to optimize based on the input parameters; >> * consider using folio_pte_batch() instead if applicable. >> * >> * Return: the number of table entries in the batch. >> */ >> static inline unsigned int folio_pte_batch_ext(struct folio *folio, >> - pte_t *ptep, pte_t pte, unsigned int max_nr, fpb_t flags, >> - bool *any_writable, bool *any_young, bool *any_dirty) >> + struct vm_area_struct *vma, pte_t *ptep, pte_t *ptentp, >> + unsigned int max_nr, fpb_t flags) >> { >> + bool any_writable = false, any_young = false, any_dirty = false; >> + pte_t expected_pte, pte = *ptentp; >> unsigned int nr, cur_nr; >> - pte_t expected_pte; >> - >> - if (any_writable) >> - *any_writable = false; >> - if (any_young) >> - *any_young = false; >> - if (any_dirty) >> - *any_dirty = false; >> >> VM_WARN_ON_FOLIO(!pte_present(pte), folio); >> VM_WARN_ON_FOLIO(!folio_test_large(folio) || max_nr < 1, folio); >> VM_WARN_ON_FOLIO(page_folio(pfn_to_page(pte_pfn(pte))) != folio, folio); >> + VM_WARN_ON(virt_addr_valid(ptentp) && PageTable(virt_to_page(ptentp))); > > Why not just VM_WARN_ON(!pte_same(*ptep, *ptentp)) ? > > ptep points to the first page table entry and ptentp points to the copy of it. > I assume ptep should point to a valid page table entry to begin with. That would also work, only miss the case where someone would by accident flip both pointers :) -- Cheers, David / dhildenb