From: Vineet Gupta <vineet.gupta1@synopsys.com>
To: William Kucharski <william.kucharski@oracle.com>
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org,
Peter Zijlstra <peterz@infradead.org>,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARC: show_regs: avoid page allocator
Date: Wed, 19 Dec 2018 13:36:43 -0800 [thread overview]
Message-ID: <d58e8389-3e27-b1cf-7787-52808a0c22a7@synopsys.com> (raw)
In-Reply-To: <114881A8-8960-4436-AAE4-DE40BFFCFB4B@oracle.com>
On 12/19/18 12:46 PM, William Kucharski wrote:
> I would rather see 256 as a #define somewhere rather than a magic number sprinkled
> around arch/arc/kernel/troubleshoot.c.
That bothered me as well, but I was too lazy to define one and the existing ones
don't apply. PATH_MAX is 4K which will blow up the stack usage.
>
> Still, that's what the existing code does, so I suppose it's OK.
I'll define one locally.
> Otherwise the change looks good.
Thx for taking a look.
> Reviewed-by: William Kucharski <william.kucharski@oracle.com>
I'll add this to the patch.
Thx,
-Vineet
next prev parent reply other threads:[~2018-12-19 21:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 18:53 [PATCH 0/2] ARC show_regs fixes Vineet Gupta
2018-12-18 18:53 ` [PATCH 1/2] ARC: show_regs: avoid page allocator Vineet Gupta
2018-12-19 17:04 ` Eugeniy Paltsev
2018-12-19 17:36 ` Vineet Gupta
2018-12-20 1:16 ` Vineet Gupta
2018-12-20 13:30 ` Tetsuo Handa
2018-12-20 18:36 ` Vineet Gupta
2018-12-20 18:43 ` Vineet Gupta
2018-12-19 20:46 ` William Kucharski
2018-12-19 21:36 ` Vineet Gupta [this message]
2018-12-20 12:57 ` Michal Hocko
2018-12-20 18:38 ` Vineet Gupta
2018-12-18 18:53 ` [PATCH 2/2] ARC: show_regs: fix lockdep splat for good Vineet Gupta
2018-12-20 13:04 ` Michal Hocko
2018-12-20 18:45 ` Vineet Gupta
2018-12-21 13:04 ` Michal Hocko
2018-12-21 13:27 ` Michal Hocko
2018-12-21 17:55 ` Vineet Gupta
2018-12-21 17:55 ` Vineet Gupta
2018-12-24 19:10 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d58e8389-3e27-b1cf-7787-52808a0c22a7@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=peterz@infradead.org \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox