From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C3F1C001DE for ; Tue, 1 Aug 2023 02:52:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD8A72800CD; Mon, 31 Jul 2023 22:52:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A88932800C8; Mon, 31 Jul 2023 22:52:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 950872800CD; Mon, 31 Jul 2023 22:52:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 81A9D2800C8 for ; Mon, 31 Jul 2023 22:52:25 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5407180447 for ; Tue, 1 Aug 2023 02:52:25 +0000 (UTC) X-FDA: 81074012250.28.093E9A8 Received: from out199-15.us.a.mail.aliyun.com (out199-15.us.a.mail.aliyun.com [47.90.199.15]) by imf06.hostedemail.com (Postfix) with ESMTP id BABE5180004 for ; Tue, 1 Aug 2023 02:52:22 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.15 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690858343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=meFvWRPJs0ApYGYYoNZkPIF8V3aqRlCwBrMi75pmt/s=; b=kG785bhyFSN0x1KdGTUgMDi7TelKI3YwbNjSUlTXoqeKwCWvFHGPJ5BK4Q3+v+Hm85v77N B8CjTUzigAxQfSWR+wmMkh0SkKmfFoZ8SD+bo/TtnuG/krcJBroRCwRdCnleeYolaBCxDT Yk+DnH4ByVN6wPFccP4KayPwxHutqzQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690858343; a=rsa-sha256; cv=none; b=BUXBOqE/nslljc9kCsRuhKCPsiT42Qs4ndcAkSULjj1rR4YnCQYucebYsCfSWDGHe1qYT1 uvjBiTDWt/aoFz4fbrvUgwg3YfkEHdSmoTKGHvIld0/b3OL+npQy4horPN65YM+jaOa6IL cRpDpj26npx/AfMnMCjCg2YmvOOK9rk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.15 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R631e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VojMtct_1690857735; Received: from 30.97.48.66(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VojMtct_1690857735) by smtp.aliyun-inc.com; Tue, 01 Aug 2023 10:42:17 +0800 Message-ID: Date: Tue, 1 Aug 2023 10:42:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/8] mm/compaction: remove stale fast_find_block flag in isolate_migratepages To: Kemeng Shi , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mgorman@techsingularity.net, willy@infradead.org, david@redhat.com References: <20230728171037.2219226-1-shikemeng@huaweicloud.com> <20230728171037.2219226-5-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230728171037.2219226-5-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: rbaj1iptfkxpqf4ci66kphqhrbjk85me X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BABE5180004 X-Rspam-User: X-HE-Tag: 1690858342-835894 X-HE-Meta: U2FsdGVkX18rYMdKyi9oPaNbf9p0OUIxRydrainola1EyNa3lVDoOkEltYY+rgYGlC0Zw6VpbgROIyWcNKzwu908J0Jmcnl4jIDIV//y7VPRpnHfmOvcowNa6iCKpYm77SSvfq8uy2BHUelBlcyKgPvEFhNnGeILjhULwMTtbW2r68tI+AQl1lhF5hEzpXiVEtHURNn/Egs378d2VPwgSQorrCSbkQjzuQrfB6xa96fAV1/7GRoefMOOgbbfISwi6LF6eQAVveykSxStBnybSX6jqAr/rgaTErnHeMX+A2fTWV7hURo8wpvs7iIr1Nr6DiuDu2nvKdrPkJaXJ+K/L75EySTABlC/N/k6mxDV9BUI4zJhnNb8kIP2dHi1eypdESnrDmDvFTFsmFsgNth70Rgfh9QHQiQSFAP9qsPJ2nXl40U2xXgY1cDCKN0QqtjzkSEDOyP2O1sEVj0cJZYtjQzy2LQdQn1Q2F5FSk1YNbkCMwhQ5coYQeoEUfiUKaevbHpNaBqfY/F3pEzX7P9AgtZZNZMeWSiTkw6nmhVt7m6yaGksy+iYROWdsca4AACxnthlaeCXoCKLsobmItD0FOBHuZwI/+LZ4PKyp8BTkfg9oCoIYIpETXfSysJAbgsQHzlZZUqh+69uTW6zzI0okyoY7F2wdUn8SJyv6yXetq8Z1H2XliFkBThobb5xwGRAhnNeHReD2vHbxYefGqANNt+H6/xTpzn4gelv9CvlFTd9yzhUKBdoXMGD0BgGiaAS0s+Q3UBXMBPQMHTBSXDKd8TqCWEzEQ9q0Ie4iYgLC3B+mvhA9+SUAmfly3gkdDCtt6/tHHFOkkVH8Xv/M3ZgUyJH/kzeXgIPDC3M+GgdV9VXbjtlCLHvS60c77VCxTZrORhi4W1iPxxAccE1Xpt4ongcO75oMeh7xmvHXPwWzxQqq0xMefRK2vHd6Tx1NiVGe+XzwD8lRnKciNgKBd9 RjQCqy4Q kZ4iaRTC2HIy+FcigORcGf0Y9ApyQSMjdvFZkaJOUCVWitYgt5fz+ZfNoFTAZqYDtVp3a2mP0phacYAtlEX0A/0NMtSu8mOi9xlAPe2RHXCUxezJ+dd5lIePfhl499oN1d3BX7fqJSN4npER56ymW+oqaSAV3pH7pC72skRuKP0zdxd2dQhw5/j8Ylg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/29/2023 1:10 AM, Kemeng Shi wrote: > In old code, we set skip to found page block in fast_find_migrateblock. So > we use fast_find_block to avoid skip found page block from > fast_find_migrateblock. > In 90ed667c03fe5 ("Revert "Revert "mm/compaction: fix set skip in > fast_find_migrateblock"""), we remove skip set in fast_find_migrateblock, > then fast_find_block is useless. > > Signed-off-by: Kemeng Shi > --- > mm/compaction.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index ad535f880c70..09c36251c613 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1949,7 +1949,6 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc) > const isolate_mode_t isolate_mode = > (sysctl_compact_unevictable_allowed ? ISOLATE_UNEVICTABLE : 0) | > (cc->mode != MIGRATE_SYNC ? ISOLATE_ASYNC_MIGRATE : 0); > - bool fast_find_block; > > /* > * Start at where we last stopped, or beginning of the zone as > @@ -1961,13 +1960,6 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc) > if (block_start_pfn < cc->zone->zone_start_pfn) > block_start_pfn = cc->zone->zone_start_pfn; > > - /* > - * fast_find_migrateblock marks a pageblock skipped so to avoid > - * the isolation_suitable check below, check whether the fast > - * search was successful. > - */ > - fast_find_block = low_pfn != cc->migrate_pfn && !cc->fast_search_fail; > - > /* Only scan within a pageblock boundary */ > block_end_pfn = pageblock_end_pfn(low_pfn); > > @@ -1976,7 +1968,6 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc) > * Do not cross the free scanner. > */ > for (; block_end_pfn <= cc->free_pfn; > - fast_find_block = false, > cc->migrate_pfn = low_pfn = block_end_pfn, > block_start_pfn = block_end_pfn, > block_end_pfn += pageblock_nr_pages) { > @@ -2007,8 +1998,7 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc) > * before making it "skip" so other compaction instances do > * not scan the same block. > */ > - if (pageblock_aligned(low_pfn) && > - !fast_find_block && !isolation_suitable(cc, page)) > + if (pageblock_aligned(low_pfn) && !isolation_suitable(cc, page)) I do not think so. If the pageblock is found by fast_find_migrateblock(), that means it definitely has not been set the skip flag, so there is not need to call isolation_suitable() if fast_find_block is true, right?