From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D00C4727E for ; Fri, 25 Sep 2020 08:55:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 76D8921D91 for ; Fri, 25 Sep 2020 08:55:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76D8921D91 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D5A4E6B0062; Fri, 25 Sep 2020 04:55:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D09FF6B006C; Fri, 25 Sep 2020 04:55:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C47676B006E; Fri, 25 Sep 2020 04:55:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id B05D26B0062 for ; Fri, 25 Sep 2020 04:55:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 748418249980 for ; Fri, 25 Sep 2020 08:55:42 +0000 (UTC) X-FDA: 77300975724.19.cakes44_5a09d2327166 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 4C6541ACEA2 for ; Fri, 25 Sep 2020 08:55:42 +0000 (UTC) X-HE-Tag: cakes44_5a09d2327166 X-Filterd-Recvd-Size: 2325 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Fri, 25 Sep 2020 08:55:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9C234ACB5; Fri, 25 Sep 2020 08:55:40 +0000 (UTC) Subject: Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs To: Joonsoo Kim , Mel Gorman Cc: Andrew Morton , Linux Memory Management List , LKML , Michal Hocko , "Aneesh Kumar K . V" , kernel-team@lge.com, Joonsoo Kim References: <1598331582-19923-1-git-send-email-iamjoonsoo.kim@lge.com> <20200827133523.GC3090@techsingularity.net> From: Vlastimil Babka Message-ID: Date: Fri, 25 Sep 2020 10:55:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/25/20 6:59 AM, Joonsoo Kim wrote: > 2020=EB=85=84 8=EC=9B=94 28=EC=9D=BC (=EA=B8=88) =EC=98=A4=EC=A0=84 8:5= 4, Joonsoo Kim =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: >=20 > Hello, Andrew and Vlastimil. >=20 > It's better to fix this possible bug introduced in v5.9-rc1 before > v5.9 is released. > Which approach do you prefer? > If it is determined, I will immediately send a patch as you suggested. Hmm both Mel and I preferred the bypass approach and nobody else weighted= in, so if you don't mind, you can use my suggestion. Hmm maybe alloc_flags & ALL= OC_CMA check should precede migratetype check in the if () to optimize for users= pace allocations? Thanks, Vlastimil > Thanks. >=20