From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <js1304@gmail.com>, Mel Gorman <mgorman@techsingularity.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
kernel-team@lge.com, Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs
Date: Fri, 25 Sep 2020 10:55:36 +0200 [thread overview]
Message-ID: <d587d057-75f1-288e-49d2-0c6ea387d414@suse.cz> (raw)
In-Reply-To: <CAAmzW4NabiAc+Nh=jtg9fUZTodQHHjf=mFTn=w32AJ43L9o2Aw@mail.gmail.com>
On 9/25/20 6:59 AM, Joonsoo Kim wrote:
> 2020년 8월 28일 (금) 오전 8:54, Joonsoo Kim <js1304@gmail.com>님이 작성:
>
> Hello, Andrew and Vlastimil.
>
> It's better to fix this possible bug introduced in v5.9-rc1 before
> v5.9 is released.
> Which approach do you prefer?
> If it is determined, I will immediately send a patch as you suggested.
Hmm both Mel and I preferred the bypass approach and nobody else weighted in, so
if you don't mind, you can use my suggestion. Hmm maybe alloc_flags & ALLOC_CMA
check should precede migratetype check in the if () to optimize for userspace
allocations?
Thanks,
Vlastimil
> Thanks.
>
next prev parent reply other threads:[~2020-09-25 8:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 4:59 js1304
2020-08-25 5:10 ` Andrew Morton
2020-08-25 5:34 ` Joonsoo Kim
2020-08-26 0:42 ` Andrew Morton
2020-08-26 5:21 ` Joonsoo Kim
2020-08-25 9:43 ` Vlastimil Babka
2020-08-26 5:12 ` Joonsoo Kim
2020-08-27 12:15 ` Vlastimil Babka
2020-08-27 13:35 ` Mel Gorman
2020-08-27 23:54 ` Joonsoo Kim
2020-09-25 4:59 ` Joonsoo Kim
2020-09-25 8:55 ` Vlastimil Babka [this message]
2020-09-25 8:58 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d587d057-75f1-288e-49d2-0c6ea387d414@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox