From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF2EECE564 for ; Tue, 10 Sep 2024 13:04:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8ACD8D0062; Tue, 10 Sep 2024 09:04:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B397B8D0056; Tue, 10 Sep 2024 09:04:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A28908D0062; Tue, 10 Sep 2024 09:04:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7DA4C8D0056 for ; Tue, 10 Sep 2024 09:04:02 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2B9ACA7657 for ; Tue, 10 Sep 2024 13:04:02 +0000 (UTC) X-FDA: 82548846324.07.115B203 Received: from mail-40131.protonmail.ch (mail-40131.protonmail.ch [185.70.40.131]) by imf27.hostedemail.com (Postfix) with ESMTP id 1258240018 for ; Tue, 10 Sep 2024 13:03:58 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=proton.me header.s=hw457d576rdmvabsgqk6my4jny.protonmail header.b=iFudpvHW; spf=pass (imf27.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.131 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725973337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QL/xny+7YZ+HuSdSBDWfILutCZ1cQLnIIC+OF84XN2U=; b=cmfhhWcXcq/37VNFjCiV2A7MszpPpeMQx9kWiF8MGJBzWVOA/hJHEr2Nt3dWYNRp1FjZxF kx3XnWd3x3DrFRQomvwyNkxhNWkqhoQk97my92/JkvcBtq6SDnZFAkwjD5OeTPPPUyoE6u 2FEiqgqLFaYndqfJclV3whNxpHTYsZQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725973337; a=rsa-sha256; cv=none; b=ZMvGJAaD3UX8PQ8Io4AdLdlPlIZiJ3ZQoAynOZke0Yay0Nhszm891eUf7JL0h9bhMo729p BEZJd1jf+8jwboA3JNbwd17bVfFf32EZOkumZJus4UlBkAaBixtduHVlPvpdHwiLolOWjF Dg/Z48LnO+YjHZNwgLrIepvutsyuCXA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=proton.me header.s=hw457d576rdmvabsgqk6my4jny.protonmail header.b=iFudpvHW; spf=pass (imf27.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.131 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=hw457d576rdmvabsgqk6my4jny.protonmail; t=1725973436; x=1726232636; bh=QL/xny+7YZ+HuSdSBDWfILutCZ1cQLnIIC+OF84XN2U=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=iFudpvHWDUScSVTix+YcNVhOyw09PRzCHdSiyV7hMLU1erXMdLwPZvxTT2YVSB7Ox GJ9cR68zOWbmrJLfx4CgpcDnxBoe2TAmAMAt+TgKAj2aUD0oDrAZtr2eiZ/BJP4ezh 7x49q374LYEY820SLi80fvRDKUw0Ze/PP8NoH86SzWqWMTfQwV/WeJFlMj0D5jWyWS jNIqRmblXxHBZ5wRfRc95xrIQESyitdZpiNpRak9wbOSLxwJUBS/8il6RACtjZ0MyR 29DC9rE4D3pY45jGuV5SRFq1B2uAbIcZ9Q/UwtUcEuUGrUDhlsh9TfR9NorO/PJp0l ownJjUGQNCAMg== Date: Tue, 10 Sep 2024 13:03:48 +0000 To: Danilo Krummrich From: Benno Lossin Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 01/26] rust: alloc: add `Allocator` trait Message-ID: In-Reply-To: References: <20240816001216.26575-1-dakr@kernel.org> <20240816001216.26575-2-dakr@kernel.org> <60253988-37e7-4acb-b2ae-748b30a4ac21@proton.me> <44b80095-8b03-4558-967e-138ea712f780@proton.me> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 529a7b2793b9f2585f48e36eb06cf94ffed7918e MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1258240018 X-Stat-Signature: wb4d7ocoxzbmm7trcur6a6fr4p13jdbf X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725973438-938912 X-HE-Meta: U2FsdGVkX19civh9iT3ypZpDnOVw3KLEgtgLEGftlXO4cYIYNstvd3p1nsykAUeuyf/RT7TmyJePizMLy0AfjjKc/qNTyQ0m98EjlHuDbVsm09XgnGfi1WmZRBG5Pv9T7M0jlvN7jJf6cqG02gwAFOlPrMyI+sgEEWnY4ugfn+j1kWX8D9/MX9+UqOVrE07PTSc7Xtsve/HE1eWzaBmQPf8nTM4AgXAA/iuXVvH3OGdR9RKAAqNwILXCd9TCU3dHPnUMqQh/GCeiLOrFHbvMDD8xvKeWv/2TLL8zPRWLuFSY/wwQ/oD7/Jv2MJLEnRIqwB01qB7PLxuzZ64lFiuZ+ZNNDYlLQj+CwPYrQMHd9yx8bEqtkG+87xI9aCJNSNe8QPgIPtVJKpyUlrIjSKYn5JkOnwOVbuX3Bl3sURonVsK01JDAey1bIn1HdG8uZlIHu95YQNmBV1eNtezNXfhBUrzq6Chf1x12FDKbfKiAzn81qucIbHN7j1SZjEFj1csEp2NA4E9g+WiQ9jDPe7OcW5B7pgFknitHwEudvR3iYfJxdXGaaXWmNCuVX1bZyePo3CjWqr1IoAaPAqOxA4LOWMWt3oIxuzuGTrx8c08qwFsuaz9GbmKsrburm/qV/y2KSkmFHE+0iw4YyPDQ7gKWPds11eTlHP/qwj8+5ubdyu7F5PWeM/hhjvg0W1yyct5qcODnG6csCwZbL7VoXs51aFPEaZNiRsrZCBP38CciljL299kyZ5jUDnEtmL4I9tZlg54iR3WTQYsCnQrouLFgN6c1ZyIsVxW3rjy5c438k8M60aZaEjaeb3ElxSlikNG8dvkrzwLwZgb2dEFcu0I+bVdHiadx+zJKYncdRC4xrIOyWQ3GEcApb4pSnB6PlBldblYY03E+A26+ZD6QWfzLjf832cMCPBkFeEEiysuSAfmgT5gn6EXRRDeUdAhZooajdd2Vsvm937kMaSIf/qT wkFTIaIP 4z3P/ejW7f/DmtaF94ivPzgUdfkscLqkYc9ppnvRVqX4qh7tuOOtGMJ9N2oHRwq4Js+t7VOBKhs9MNqGjVmacV4jhlfmcqw5iJ7q03c3Inr4p3vEfEEmqRs9JokZZ53B4UAkpUgoMF2wm2HFGb9CwJJPgTK7yBxm2htGKJODwIE1pAKs8i5mZ+BOEXNh0T3WMkG5kqW6BRp1ayiCKmdOrVRrbRnV6lqAvTZr9CN5q5PHMiEyxDTfwv9zVCkpUUXbBvvcSIGOljKlEVIJMXSIm6st656hvqiYV2UBKyVj4ehyw/rv/b0eNBtM5Mw8vt3tEsd9HL43o2mkLQ7GwBUAM4I2+YM1QvOreo1ArrfllZ/KJa7z+cmzREjyrDm0UfZlLWgCZTFQYCwhH/A1DxKTXr1LQrq0pnFMMB4yn3+5dOaj3IHJltzK57wNQVhNa41lNiyyhf3pUgZcYyIEobHWfv1tJm7j0Sc0fFgv4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.09.24 13:56, Danilo Krummrich wrote: > On Fri, Aug 30, 2024 at 01:06:00PM +0000, Benno Lossin wrote: >> On 29.08.24 23:56, Danilo Krummrich wrote: >>> On Thu, Aug 29, 2024 at 06:19:09PM +0000, Benno Lossin wrote: >>>> On 16.08.24 02:10, Danilo Krummrich wrote: >>>>> Add a kernel specific `Allocator` trait, that in contrast to the one = in >>>>> Rust's core library doesn't require unstable features and supports GF= P >>>>> flags. >>>>> >>>>> Subsequent patches add the following trait implementors: `Kmalloc`, >>>>> `Vmalloc` and `KVmalloc`. >>>>> >>>>> Reviewed-by: Alice Ryhl >>>>> Signed-off-by: Danilo Krummrich >>>> >>>> We discussed this in our weekly meeting (I think ~one week ago?). If y= ou >>>> give me a draft version of the comment that you plan to add regarding >>>> the `old_layout` parameter, I can see if I am happy with it. If I am, = I >>>> would give you my RB. >>> >>> May I propose you let me know what you would like to see covered, rathe= r than >>> me trying to guess it. :-) >> >> I was hoping that we put that in our meeting notes, but I failed to find >> them... I would put this in a normal comment, so it doesn't show up in t= he >> documentation. Preface it like implementation decision/detail: >> - Why do `Allocator::{realloc,free}` not have an `old_layout` parameter >> like in the stdlib? (the reasons you had for that decision, like we >> don't need it etc.) >=20 > Ok. >=20 >> - Then something along the lines of "Note that no technical reason is >> listed above, so if you need/want to implement an allocator taking >> advantage of that, you can change it" >=20 > I don't really want to set the conditions for this to change in the > documentation. It really depends on whether it's actually needed or the > advantage of having it is huge enough to leave the core kernel allocators= with > unused arguments. >=20 > This can really only be properly evaluated case by case in a discussion. Agreed, but I don't want people to think that we have a reason against doing it in the future. Do you have an idea how to convey this? --- Cheers, Benno