From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBB94C7EE23 for ; Tue, 28 Feb 2023 01:47:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D24F6B0071; Mon, 27 Feb 2023 20:47:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25CC56B0072; Mon, 27 Feb 2023 20:47:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D54D6B0073; Mon, 27 Feb 2023 20:47:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ECB056B0071 for ; Mon, 27 Feb 2023 20:46:59 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8CFD51C5B03 for ; Tue, 28 Feb 2023 01:46:59 +0000 (UTC) X-FDA: 80515012158.24.AF690ED Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf21.hostedemail.com (Postfix) with ESMTP id 1ECC61C000C for ; Tue, 28 Feb 2023 01:46:55 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677548817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dDOT931/1KLDc7nKpDMyNij6IKjkDXvAL06nlK2ayZU=; b=iYRLwBvQNtBFVX4ADIMvjJ+akoHqcsOmpaS0nlqhEUGenYTCxFkjNyw0ZM/f0XBhgPCXjV w5TNXzsZolrL7zX67LOjoijFWVFJrnrqjfVsoimGZIoXN0t2D8KfhgnL0hZBYXFBzfWizP FvSZamtiC5vXIROd2bfEj03+Dx0taE4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677548817; a=rsa-sha256; cv=none; b=neIOJeiuit7mpQvw6ywc68mHG8MvpYfpD+x9Mh5gne81F5dmT9Zmf2A5EdScgmHlWC+gzZ oKLpaFBDIBO8w+amWLm4r3Qc2GkyHN9J6XSC07mnGYvDoF6s61G1UuJoJWq3gfoqEYgf2J P+3b1o9pAnsmB4iJkMxWsuwKrcPS5bA= Received: from dggpemm100009.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PQgBl0ycNzSkPW; Tue, 28 Feb 2023 09:43:59 +0800 (CST) Received: from [10.174.179.24] (10.174.179.24) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 28 Feb 2023 09:46:50 +0800 Subject: Re: [PATCH RFC] arm64/vmalloc: use module region only for module_alloc() if CONFIG_RANDOMIZE_BASE is set To: Linux regressions mailing list , Ard Biesheuvel References: <20221227092634.445212-1-liushixin2@huawei.com> <20230129134147.f19ca0641f1133f3e3bc185b@linux-foundation.org> <20230131150644.GA2605@willie-the-truck> <20230131150750.GB2605@willie-the-truck> <20230207112940.GA12147@willie-the-truck> <8c287b1d-476c-7b00-27f6-76c3a1a5fd46@leemhuis.info> CC: Andrew Morton , Catalin Marinas , Uladzislau Rezki , Christoph Hellwig , , , , Will Deacon From: Liu Shixin Message-ID: Date: Tue, 28 Feb 2023 09:46:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <8c287b1d-476c-7b00-27f6-76c3a1a5fd46@leemhuis.info> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 1ECC61C000C X-Stat-Signature: ez5uyccq6s1j851xkpia3ni9jr4iyekq X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677548815-672704 X-HE-Meta: U2FsdGVkX1/6rE9UeSuZKETuBySmoo3Rs1IUdImlPrmu+VCwZ3K7vzNPrZHYSnBy5urlmBqhozjv59nXyFSsR5cwyqGKce+w8+oG0AEB3sZTtEtjbPUxHxfEDOTpZQvBWeCgirLOQ2R9gNVMm6YlWeTj4mvJU+IKMplJQdJc2WLWrSK6h2Bm9EDhFm8+FPJ98vyqKFM6l+eg7olxxz194tgZ0aflT7l+42r7iQ2vvpf2kPxYKJiPYjaDHg+gK6arwQBYSbhBpeC8zaMjonjysu8JzqhsIb7HHdBvwhrKTlFMD3rA+cUNUBVpNY7uXJVXDmg6ml5IfMW2V4IsExEZaD3qwyIWwl6Z9sJJhOPMfkhsHY44M5QTMsTp05gPLlI/g7G3k2VxEQPCGdeAVXtGEdvoYt+yO7+gl0o52GJxA+SXEokwGNnkoXswyG3yEFxOVcVqdQDHMyaaaKWfF/5ZqJ2TVn5w+SSi7t7AK2zt6yjC6JZfO64uhVk5tig0zL0AzcRLFy5rKWkZArbgxT5DKFIK16QqzIh6sPDCkiAht+qZnGW1CNNib2xUyIGqVp8Edr/nCuKIfxuTKXIENWMOrBNIS7I4K96aloW9HUyFmHQ2nsQ2vK4JLCqnkf7y0s8vrtIxorSWgEq6xcbvB4qV5JrjAHb0tQS/Gg03t3TLO12pwGhUQkX72ND8rK4WinfGSQs9mjQN5900wGhA5l0s6ldnba8YqWE5dR6urSFj5bv8p2Kr5hWTKjiSPAZNcrBtAeVOsoyGXer+LFwAuBERl+llxK7FPBaE7exjRJxLdvKDi1px9buJflia3hYcdpmt6QMi4QjYz3dFfxtXBvewnciGYwg3mmVSwV3T8z3DkhDReECsT8vD0luoBGRoHKMStbxfdBbYaQL0b5o74oNMqoHwIxteArJ/p+zzgoZMiNpb077WKCFA9l/aO3yHjCF7Zk4EZF+zgzHK+yApzrU GaSVkD8t P+ClZTL+sIcPf0mqA0kDQK7/vIZSG7C0H+wF1Ouw7NrAY2OfHuUcMqYW0+pS3kKLMIq8lj922Zs6Ls0LzgI7tQhq2GSp+RVSK2VkldFglFuN6G4170+1u+g759YKkA8+AGm9SPgJ0wz6GJE+uN/hPkZrsnyubTOjYuVMh4KwWr+O8mujuwkrDix7qkNBepSSXeC52KhmBBVEA2wI3egeNRSBTHYEy8qoUcbhRc6nm33Vv3zW71tymVWsgoWDZPFC3CqLc5d4ilj5heCqDRbDhcYGbkSgT2/qrelCiRfxiH1Vrj7AxsPR90HK6lNxEFdVsuMFDrZ7sCAYCWOLjHUTtP6PwcihegqKDKmeYKnzGwUium/c3pwJhazeim4LrdLukF52LYCtWRm4hOboMWoofUa3p0T0qIQmw4kFi1T7/Vihk9qo2LG2i444aiZamwZlmrT9Jy73+G/Xrb1GJBFPYlF2nSeZsSSAcwN2Os4Rt+eJE6Dr8dvmJiLfrp7n+7cF3ghfltJk1tDpKO+XuJlk5Di4MMIUj2EMWqCd2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/2/27 23:08, Linux regression tracking (Thorsten Leemhuis) wrote: > [CCing the regression list, as it should be in the loop for regressions: > https://docs.kernel.org/admin-guide/reporting-regressions.html] > > On 07.02.23 12:29, Will Deacon wrote: >> On Tue, Jan 31, 2023 at 05:03:32PM +0100, Ard Biesheuvel wrote: >>> On Tue, 31 Jan 2023 at 16:07, Will Deacon wrote: >>>> On Tue, Jan 31, 2023 at 03:06:44PM +0000, Will Deacon wrote: >>>>> On Sun, Jan 29, 2023 at 01:41:47PM -0800, Andrew Morton wrote: >>>>>> On Sun, 29 Jan 2023 10:44:31 +0800 Liu Shixin wrote: >>>>>>> On 2022/12/27 17:26, Liu Shixin wrote: >>>>>>>> After I add a 10GB pmem device, I got the following error message when >>>>>>>> insert module: >>>>>>>> >>>>>>>> insmod: vmalloc error: size 16384, vm_struct allocation failed, >>>>>>>> mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0 >>>>>>>> >>>>>>>> If CONFIG_RANDOMIZE_BASE is set, the module region can be located in the >>>>>>>> vmalloc region entirely. Although module_alloc() can fall back to a 2GB >>>>>>>> window if ARM64_MODULE_PLTS is set, the module region is still easily >>>>>>>> exhausted because the module region is located at bottom of vmalloc region >>>>>>>> and the vmalloc region is allocated from bottom to top. >>>>>>>> >>>>>>>> Skip module region if not calling from module_alloc(). >>>>>> I'll assume this is for the arm tree. >>>>>> >>>>>> Acked-by: Andrew Morton >>>>> This looks like the same issue previously reported at: >>>>> >>>>> https://lore.kernel.org/all/e6a804de-a5f7-c551-ffba-e09d04e438fc@hisilicon.com/ >>>>> >>>>> where Ard had a few suggestions but, afaict, they didn't help. >>>>> >>> Thanks for the cc. >>> >>> So this is a bit clunky, and I wonder whether we wouldn't be better >>> off just splitting the vmalloc region into two separate regions: one >>> for the kernel and modules, and one for everything else. That way, we >>> lose one bit of entropy in the randomized placement, but the default >>> 48-bit VA space is vast anway, and even on 39-bit VA configs (such as >>> Android), I seriously doubt that we come anywhere close to exhausting >>> the vmalloc space today. >> That sounds like a good idea to me. >> >> Liu Shixin -- do you think you could have a go at implementing Ard's >> suggestion instead? > Liu Shixin, did you ever look into realizing this idea? This is in my work list, but I haven't implemented it yet. Sorry for the long delay. > Or was some progress already made and I just missed it? > > I'm asking, as the idea discussed afaics is not only supposed to fix the > regression you tried to address, but also one that is now three months > old and stalled since Mid-December -- which is really unfortunate, as > that's not how regressions should be handled. :-/ But well, it afaik was > caused by a patch from Ard, so it's obviously not your job to address > it. But it seems you were working on it. > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > -- > Everything you wanna know about Linux kernel regression tracking: > https://linux-regtracking.leemhuis.info/about/#tldr > If I did something stupid, please tell me, as explained on that page. > > . >