linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Matthew Wilcox <willy@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@lst.de>, Hugh Dickins <hughd@google.com>,
	Alex Sierra <alex.sierra@amd.com>,
	Alistair Popple <apopple@nvidia.com>,
	Miaohe Lin <linmiaohe@huawei.com>,
	Mike Rapoport <rppt@kernel.org>,
	William Kucharski <william.kucharski@oracle.com>
Subject: Re: [GIT PULL] Folio patches for 5.18 (MM part)
Date: Mon, 21 Mar 2022 16:24:08 +0100	[thread overview]
Message-ID: <d5676cf0-30f9-8497-95a8-332767dede46@redhat.com> (raw)
In-Reply-To: <9ae0a8e4-41b7-04f4-4435-17cbba9850fb@redhat.com>

On 21.03.22 16:16, David Hildenbrand wrote:
> On 21.03.22 14:30, Matthew Wilcox wrote:
>> Hi Linus,
>>
>> This is the first of two folio-related pull requests for this merge
>> window.  This is the MM side of things and we had some unfortunate
>> complex merge conflicts to resolve.  I decided to redo my changes on
>> top of Hugh's and Christoph's patches, so I'm the one sending the
>> pull request.
>>
>> The following changes since commit f71077a4d84bbe8c7b91b7db7c4ef815755ac5e3:
>>
>>   Merge tag 'mmc-v5.17-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc (2022-02-16 12:09:22 -0800)
>>
>> are available in the Git repository at:
>>
>>   git://git.infradead.org/users/willy/pagecache.git tags/folio-5.18
>>
>> for you to fetch changes up to 5063f22c914e3e5f2239cf91f4986042dc705bde:
>>
>>   mm/damon: minor cleanup for damon_pa_young (2022-03-16 10:09:50 -0400)
>>
>> ----------------------------------------------------------------
>> Folio changes for 5.18
>>
>> Several of us had overlapping, conflicting changes to the MM this
>> round, and I volunteered to send the pull request.
>>
>>  - Hugh rewrote how munlock works to massively reduce the contention
>>    on i_mmap_rwsem:
>>    https://lore.kernel.org/linux-mm/8e4356d-9622-a7f0-b2c-f116b5f2efea@google.com/
>>  - Christoph sorted out the page refcount mess for ZONE_DEVICE pages:
>>    https://lore.kernel.org/linux-mm/20220210072828.2930359-1-hch@lst.de/
>>  - I converted GUP to use folios and make pincount available for order-1
>>    pages.
>>  - I converted a few more truncation functions to use folios
>>  - I converted page_vma_mapped_walk to use PFNs instead of pages
>>  - I converted rmap_walk to use folios
>>  - I converted most of shrink_page_list() to use a folio
>>  - I added support for creating large folios in readahead
>>
>> ----------------------------------------------------------------
>> Alex Sierra (10):
>>       mm: add zone device coherent type memory support
>>       mm: add device coherent vma selection for memory migration
>>       mm/gup: fail get_user_pages for LONGTERM dev coherent type
>>       drm/amdkfd: add SPM support for SVM
>>       drm/amdkfd: coherent type as sys mem on migration to ram
>>       lib: test_hmm add ioctl to get zone device type
>>       lib: test_hmm add module param for zone device type
>>       lib: add support for device coherent type in test_hmm
>>       tools: update hmm-test to support device coherent type
>>       tools: update test_hmm script to support SP config
>>
>> Alistair Popple (2):
>>       mm: remove the vma check in migrate_vma_setup()
>>       mm/gup: migrate device coherent pages when pinning instead of failing
> 
> ... I thought DEVICE_COHERENT is still under development?
> 

After verifying that I'm not daydreaming [1] (and realizing that I had
review comments to some of these patches that have not been resolved
yet) and also not spotting these change in your changelog above, I
assume this stuff was included by mistake. NACK to merging
DEVICE_COHERENT at this point.

[1] https://lkml.kernel.org/r/20220310172633.9151-1-alex.sierra@amd.com


-- 
Thanks,

David / dhildenb



  reply	other threads:[~2022-03-21 15:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21 13:30 Matthew Wilcox
2022-03-21 15:16 ` David Hildenbrand
2022-03-21 15:24   ` David Hildenbrand [this message]
2022-03-21 15:31     ` Matthew Wilcox
2022-03-21 15:38       ` David Hildenbrand
2022-03-21 16:54         ` Matthew Wilcox
2022-03-21 17:03           ` David Hildenbrand
2022-03-21 17:49             ` Matthew Wilcox
2022-03-23  2:27               ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5676cf0-30f9-8497-95a8-332767dede46@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.sierra@amd.com \
    --cc=apopple@nvidia.com \
    --cc=hch@lst.de \
    --cc=hughd@google.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rppt@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=william.kucharski@oracle.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox