From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F7EC369AB for ; Mon, 21 Apr 2025 07:17:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CF626B0006; Mon, 21 Apr 2025 03:17:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57D0A6B0007; Mon, 21 Apr 2025 03:17:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F6CC6B0008; Mon, 21 Apr 2025 03:17:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1ED6C6B0006 for ; Mon, 21 Apr 2025 03:17:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 997EE161AC9 for ; Mon, 21 Apr 2025 07:17:47 +0000 (UTC) X-FDA: 83357196174.01.4992979 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 233B640007 for ; Mon, 21 Apr 2025 07:17:44 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WLtaX82A; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745219865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T5mW9NCCHCkay/jPJBmMQL4bt1khz2U8sjcPo5OyGgM=; b=nyWzRnw6ENbm1O2VTfrUM8bg0dzF8QmEqaYBSrktdeKmVfvAcg33ibx05jRRSF4rwqOrrI fdZ1b1txsWQJsX1N2SurCx60gHZFL9HcMEfx52nkW+86cZLekFYA4pRdgH/JtzCV4r6WC8 0OASKUlLiW0nkD9ovAeynedPAE4e9xs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WLtaX82A; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745219865; a=rsa-sha256; cv=none; b=q3GzVfIYB99KpkrdFcf12JmEsUgA7IpMqBdWG2U7GtKIe3WQKHAsdjvWGBs1WBAID6Cn/+ F2F9ag65ShHzHI5R4dAIcLH89KXO+/ZuyYsb4nZqjAxd+4U+z0IFAyBYv87OoxdpmxwjyK /tZY5+L0Stdv3bdzT6Glocm2M8AjAsc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745219864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=T5mW9NCCHCkay/jPJBmMQL4bt1khz2U8sjcPo5OyGgM=; b=WLtaX82ANZZq+llUHR5s1TzYNrgRrtFC94rVWO6oBh0KpLHicrewVTtbAPSVnaMDo11QBb BK87G+ygZyhL/dFoDQ+6oXnJC9SS8Obe1HzfVxhnEMmBBO83YGBoDYZ8n505gpJ/rm6lii ZOiV299TcIHS2/YoL2ufjgGUFw+Xg1I= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-186-MyUrjIH8Mh6Hg9MOs6FJrA-1; Mon, 21 Apr 2025 03:17:40 -0400 X-MC-Unique: MyUrjIH8Mh6Hg9MOs6FJrA-1 X-Mimecast-MFC-AGG-ID: MyUrjIH8Mh6Hg9MOs6FJrA_1745219859 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39979ad285bso1609481f8f.2 for ; Mon, 21 Apr 2025 00:17:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745219859; x=1745824659; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=T5mW9NCCHCkay/jPJBmMQL4bt1khz2U8sjcPo5OyGgM=; b=iU+zGPZr0EOr8WX9i4FwGlTrFkT4ZKYmBbUdZABjaElulY7Up+EfhvYKmi6jT3vGQc VQL6jTu9FPjrPo54eO1v2b7DsEmFxaqJrxkM7fgVdGsP0DJiNqz+Z2/YWyK2MeIxihdI QHk6QbPht1+7mTkC0fWsRLQRgyg91HA4jF46Z+NjQxK0gTpDkWGavHpg2gCvYbToM8pF ze/ygJkq0eWeXHR86Kta3tkOea/koq4Fs/x1JLEGEaAz/p7nAGI6EjHAjo7lQ4gNU+6p ZBX+Qugrkx+RBKWd0P4+tu7fJZIOlJ8bBfJrfO2Tx9D+iPyn7V5jHXov0DHC8GTUJvtn aIxg== X-Forwarded-Encrypted: i=1; AJvYcCXf5XDUeCnXnqnG3crFAqIP1A6ltt/9IoKqJa36FHSYE3Mz++bERDw6lFwMGFQtwtxhaywoKRUxww==@kvack.org X-Gm-Message-State: AOJu0Yy1j/v00FjejsDtu0F0u84hfxM4/hvwqOVj8wHWRRKcc1rYNDOb 4PmldqmhbTVxQiQASk0qklE5usX+RLilGRtzBD+5BzoX09eGNy+j8gYqOIvMdFdi+KcP2oIMWV+ 9zMO+eo1GnFJrFwPe3nwPy4M8ufkph8JQKycGjPDgWSQsrdMZ X-Gm-Gg: ASbGncsyf5ykPn52MWSAzo8341DcGFCEoE+DkxED/qCQcM3W0jS+IY5NIA/a4YZIv+W Ewh2APBSIg+nZK3tybAxLBCOYwXYdrrA2ic6anyfVY72pJltqzk5EP1hWkp0k4fUmbhIRD9IH3n zoCf+U4s3XEhVOWyY3fvl5sHAX4SeFSTkfGllQkA0F0Fj8f0HN7BCug9QmZZYee9+gtK9Yfgw9Z Szw3lIEGhMe6T2XfDFaJOFxrGJBBEOXlsGnUeYzVDIF5csx19Q6vU7bO2g7bsTdPjner97UbR4f wDCmQARIcpNquwHyX6ztKREP4h0sJ3gN+ZUZvA+CkwOwRyIpy1c/Msisp2MMj56DyLVNFIOHWii MvpHNZ09Xni195tDGm+NKP2FLje73Q2uUWSvc9SU= X-Received: by 2002:a5d:648d:0:b0:39c:141b:904a with SMTP id ffacd0b85a97d-39efba2ca27mr7845169f8f.11.1745219859450; Mon, 21 Apr 2025 00:17:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEa5JpNd0bUwH4c2uwFSJFx8GqNF4KiWfX89tD5Q6hv3uVQ6xAc5kB997MPn1gXgsFzCR/NCw== X-Received: by 2002:a5d:648d:0:b0:39c:141b:904a with SMTP id ffacd0b85a97d-39efba2ca27mr7845148f8f.11.1745219859055; Mon, 21 Apr 2025 00:17:39 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa43bf20sm10774796f8f.48.2025.04.21.00.17.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Apr 2025 00:17:38 -0700 (PDT) Message-ID: Date: Mon, 21 Apr 2025 09:17:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH v2 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared() To: Lance Yang , Andrew Morton Cc: mingzhe.yang@ly.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lance Yang References: <20250418152228.20545-1-lance.yang@linux.dev> <20250420162925.2c58c018defee9ee192be553@linux-foundation.org> <641755b75b4ecb9c9822e15e707a0ebf1e250788@linux.dev> <1c81b176893c349dfb12feaebd17e0694fedec0b@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1c81b176893c349dfb12feaebd17e0694fedec0b@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: T8fNvqURf3j5G06GELSXC4s106951b3WpE84iueNMWw_1745219859 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: detrmmt16gjcotqg5f8pe3om9hf5ari9 X-Rspamd-Queue-Id: 233B640007 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745219864-749014 X-HE-Meta: U2FsdGVkX184smDTyDTiRGNX/q96EEotToMbm6M6ePH6bU8Dp3X+7JbAZCkHZO+UGzUHOwMZTBRLGTlgh/xciceHnWJl9uvYlshl3Txa1cGDojxYr30B/xVL1d+kbEC/IUFgvTrAsVmFt6S+vzT+rXIazvDjX8W/dqm+XNhWty/XzPPbbhKu6UTaXqMZa13j8LbvRl6XaT8n2O4bJuRCyIb3CAVGrFrB5wMCjNbvEVCIvfoiQgsU0VWo/JgNN/Y+ydh3U/zRAw//L97XJ/SJzXTFzWelMUsZSPiVBbsY3Bmxvj4K4QQpK0jbfT+N7zXMXAK6mbJkRJA609FQMPUhcLFmP2VRYRT8au21LBd0Y9iSH+JxH24S/OH4UGd+h/UJq2jZlUThB4Dl9yAvu0NxzhQGb2yslMN62ZnM/JM3jLw3P0SjW0Z3+4WdF89lWGlRqbJHJulawetDUUKQYwz4tQ5N1nshTSoqWpL4dVJPnV3G+X0cWOWtpfvH0oNtCWz3Z5RRDGZdfT6vPHx+VtJN2Oq2DhWlbHmN3lWjmSsTZ/tvYJh6nuOdCTQXtnNJu+me62AiCaZM0Bylrl8wYf45RbgaoWQlMZFfMFQxpONGze4i7YmgeIqPee0y9VngdVBLDW8Bra9+yj5j04eRBccL6n3l4PiKbquTVMT28jbryaRv2at6RFG7ZhiiJ8rM6WDBD9jKkwScNp7ZkfC/ctT6qFTjS9wjdf+RGElyhICCXmAuiRpuXm1qnfOM9USs9BCSfpmzQywhvrinJZyVFGVfBuiththBFLzLLHmVykqHy0lNdfrbHzCyeA53NYsnqzKcZMXDbZzcvnbkT6RhuKi4IUKbo7FSwuzi4KS/M98vLz/nBOkXpGuWK71eO1xAyxiRfBEn7p4Ym6KNhko+XqFhmSXrMZNe/QNRYOpcHo/3NfeN1L0ZvXrRl5k1fiUn11ZOvd31EgUtu50KByot/DW 2PM57Zby nhl384GdXUOQfifhdtPT42My0PwEt4A78GlrlpeVAywqif2asURL3fDay8cd9Ui+9GM5B2AWz7KgfO68vo6Lm9YWteBV3yaAAB4jc8ld8FLWaN0hqlBR2BfLW3lYW/LDt/2SJ4ftagiWC3im5OgLVocfSjV36Eff5/yF+y4Od6Wzi3hkgm/EYDZqkGeKdzI79J4agGL8by5ZpzMZKV2VcQsFNzvfP6Hgsd/Hv3lRLYLMQwOtTCiE6pK38Spxq/a5WAxZJMnlCm4m/7XlU9EvKo1ul+FCIzUoXpx64XQ/iv2cqkUtFzElblSzYl4KHuCcOnOJtD/5BCye2EQ0HSp3GmZsSUL8/1KacrDZMd0r072xZ7JUaPCDsWH9/s/mwBVaezZH/1e7uGEla8VvxwGcP5/aiaeat2adqMZB0BU1i4zZqfh2n9TX31CeCBaz7bPyozjqcnYKJVL7DzRcx+5miCCXZ4H6FuAhNs8CMu7qTe8X5hw4ZHK9bcfvL+JBuQquh7Pl+p7eBS47QS26fec/g1E/gog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.04.25 07:16, Lance Yang wrote: > April 21, 2025 at 1:13 PM, "Lance Yang" wrote: > > > >> >> April 21, 2025 at 7:29 AM, "Andrew Morton" wrote: >> >>> >>> On Fri, 18 Apr 2025 23:22:28 +0800 Lance Yang wrote: >>> >>> >>> >>> >>> >>> From: Lance Yang >>> >>> >>> >>> >>> >>> >>> >>> To prevent folio_test_large_maybe_mapped_shared() from being used without >>> >>> >>> >>> CONFIG_MM_ID, we add a compile-time check rather than wrapping it in >>> >>> >>> >>> '#ifdef', avoiding even more #ifdef in callers that already use >>> >>> >>> >>> IS_ENABLED(CONFIG_MM_ID). >>> >>> >>> >>> >>> >>> >>> >>> Also, we used plenty of IS_ENABLED() on purpose to keep the code free of >>> >>> >>> >>> '#ifdef' mess. >>> >>> >>> >>> >>> >>> I dunno, this just seems really whacky. >>> >> >> I'd hope David could leave some comments on that. >> >>> >>> --- a/include/linux/page-flags.h >>> >>> >>> >>> +++ b/include/linux/page-flags.h >>> >>> >>> >>> @@ -1232,6 +1232,8 @@ static inline int folio_has_private(const struct folio *folio) >>> >>> >>> >>> >>> >>> >>> >>> static inline bool folio_test_large_maybe_mapped_shared(const struct folio *folio) >>> >>> >>> >>> { >>> >>> >>> >>> + /* This function should never be called without CONFIG_MM_ID enabled. */ >>> >>> >>> >>> >>> >>> A correcter comment would be "This function should never be compiled >>> >>> >>> >>> without CONFIG_MM_ID enabled". >>> >> >> Yes, that is more exact ;) >> >>> >>> Which lets the cat out of the bag. Why the heck is it being compiled >>> >>> >>> >>> with CONFIG_MM_ID=n?? We have tools to prevent that. >>> >>> >>> >>> Can we just slap "#ifdef CONFIG_MM_ID" around the whole function? It >>> >>> >>> >>> should have no callers, right? If the linker ends up complaining then >>> >>> >>> >>> something went wrong. >>> >> >> The reason we can't simply add #ifdef CONFIG_MM_ID around folio_test_large_maybe_mapped_shared() >> >> is because its caller folio_maybe_mapped_shared() relies on IS_ENABLED(CONFIG_MM_ID). > > static inline bool folio_maybe_mapped_shared(struct folio *folio) > { > [...] > if (!IS_ENABLED(CONFIG_MM_ID)) > return true; > [...] > return folio_test_large_maybe_mapped_shared(folio); > } > > folio_maybe_mapped_shared() is always available - doesn't depend on > CONFIG_MM_ID or CONFIG_TRANSPARENT_HUGEPAGE. We could #ifdef in folio_maybe_mapped_shared(), which I find rather suboptimal ... or simply inline it into the 4 callers. That might be the best approach, given that only selected user should be using the low-level primitive and everybody else should be using folio_maybe_mapped_shared(). -- Cheers, David / dhildenb